From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Ethan Tidmore <ethantidmore06@gmail.com>
Cc: "Antoniu Miclaus" <antoniu.miclaus@analog.com>,
"Jonathan Cameron" <jic23@kernel.org>,
"Lars-Peter Clausen" <lars@metafoo.de>,
"Michael Hennerich" <Michael.Hennerich@analog.com>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] iio: filter: admv8818: Simplify locking with guard()
Date: Fri, 27 Feb 2026 09:08:25 +0200 [thread overview]
Message-ID: <aaFC6XGKFb49rmHw@smile.fi.intel.com> (raw)
In-Reply-To: <20260227061424.1135505-3-ethantidmore06@gmail.com>
On Fri, Feb 27, 2026 at 12:14:23AM -0600, Ethan Tidmore wrote:
> Use guard() instead of manual locking to simplify code.
...
> ret = __admv8818_lpf_select(st, lpf_corner_target);
> -exit:
> - mutex_unlock(&st->lock);
> - return ret;
> + if (ret)
> + return ret;
> +
> + return 0;
Why not
return __admv8818_lpf_select(...);
?
...
> ret = regmap_update_bits(st->regmap, ADMV8818_REG_WR0_FILTER,
> ADMV8818_HPF_WR0_MSK |
> ADMV8818_LPF_WR0_MSK,
> FIELD_PREP(ADMV8818_HPF_WR0_MSK, 0) |
> FIELD_PREP(ADMV8818_LPF_WR0_MSK, 0));
> + if (ret)
> + return ret;
>
> -exit:
> - mutex_unlock(&st->lock);
> -
> - return ret;
> + return 0;
In the similar way?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-02-27 7:08 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-27 6:14 [PATCH 0/3] iio: filter: admv8818: Bug fix and other improvements Ethan Tidmore
2026-02-27 6:14 ` [PATCH 1/3] iio: filter: admv8818: Add missing error code Ethan Tidmore
2026-02-27 6:42 ` Ethan Tidmore
2026-02-27 7:06 ` Andy Shevchenko
2026-02-27 16:01 ` David Lechner
2026-02-27 16:06 ` Andy Shevchenko
2026-02-27 7:04 ` Andy Shevchenko
2026-02-27 16:02 ` David Lechner
2026-02-27 6:14 ` [PATCH 2/3] iio: filter: admv8818: Simplify locking with guard() Ethan Tidmore
2026-02-27 7:08 ` Andy Shevchenko [this message]
2026-02-27 16:08 ` David Lechner
2026-03-02 22:34 ` Ethan Tidmore
2026-02-27 6:14 ` [PATCH 3/3] iio: filter: admv8818: Minor cleanups Ethan Tidmore
2026-02-27 7:18 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aaFC6XGKFb49rmHw@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=Michael.Hennerich@analog.com \
--cc=andy@kernel.org \
--cc=antoniu.miclaus@analog.com \
--cc=dlechner@baylibre.com \
--cc=ethantidmore06@gmail.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox