From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 829BC334C14 for ; Fri, 27 Feb 2026 07:12:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772176372; cv=none; b=ZWyNB9L/nAn2KMJsqXfyErubvGHO3jK50Gdcq+uP9o35InnVT04dgcHJMzuyYy72/4F6I6MTN+kfadhaANBizGvb2R7GGfeLgGaLNBW+j4P1KZTlxvf5TTaHnuoDwlyIR8npFqG+bbI6wL5Ks6JKTtICLNaW7jcd4ZAgdehHk4M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772176372; c=relaxed/simple; bh=Te2ETwPe8CTD46q3uzO+m962OmKAm9X4ezXV9BbOCdw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=UfcwGQw0ONTsMDN6fqYVeQMM9rd4q11zGj9i2xCSE/p2tcjRxk1kHHW6a+av8JqGK6x8wVXQKipqnUVVJ/O/UdQ6i3+V1uFPHXgC0fq43QQZ2tR4poAfRNaxM7LLeKxGalvy99p4Ph8OslNBo3zssBTWpSGQujhSC29VMngPiqA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=if9diZXJ; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="if9diZXJ" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-4834826e5a0so18047175e9.2 for ; Thu, 26 Feb 2026 23:12:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1772176370; x=1772781170; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=BLodLJsKkEVRBTm6dIfGWy/9mRbAh2N811+5cjpyuYk=; b=if9diZXJ6mbhcBI0QdPAE3zK5G7HVsMKkEf1VavFJ5D9e0OJaoDv9EKcCB7b4BFQfe Z8jJB1I/UmS+ITE3L5sv3XnVqg8b/KqkjVyHL3w6SZx1unmWjSEu2scXYYLukc2+AXHS WENZWojyGKFAxf2UCpOxrI/8TRMxxu7TeAPPr7LcXthCi6DZAigcm3fZTfxgAn0xW8rR 467+N6UdxYKaBcMAFeMlCn71dZpx5o/o6m6xz80PMVbapbNaLqcm+YiT6T3rMzsD/csw erhFz6EotxiRIkq9HVhWUbCaQhWCxs7B2/gDCp7CgNo1462cl1KaQ/8DZLLmh0Zvrdka BPJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772176370; x=1772781170; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=BLodLJsKkEVRBTm6dIfGWy/9mRbAh2N811+5cjpyuYk=; b=gKK1VKmK4NiKWmJGCMghL3v0CeP65UBgJt20UKVvYqKsaCpsebntM/9Cpy5lTznlLY UBh8oWarRkkbEJ3a/0mMiaPSd5sy5bElSLQubWvHTaKfnPhzKySdQzkHoDo4Jl/Q9ScR gI7kzsKkPEIE/+HLi77SY9lqbw+GhUku2Rfv8WAItMRqfqvWM6hspwxuV2FVo0vCnxUg tHECB1G3tEFsrR+M6ZwEROUSjHObC54d97bXDQMbAybNh1GTOC3qX38MCWYkFGfkTXO0 bn0hxU8TeOmj05c1Z22PeFEhZI3bNOYwADYy1tacdUmXJeVvku+Kib5RFzW4NcPgecW9 bwrA== X-Forwarded-Encrypted: i=1; AJvYcCXYhc0MFV+pyE3E84m/0Znn0qBrO+XxWiipP924bJK38Bj8zwlXuIuwI+Sc1ZBF2R244lSQivhczRDDEPM=@vger.kernel.org X-Gm-Message-State: AOJu0YyGjXhAGAJotJHMAlbSyKleAjH75f3Ju2DXHQcDRsoHy1d9Fxe/ 8cY73Y1Ztxz/qoy81gVYY4a3fMBkJ05CzVphnOtxAMUZr+SeuI7qgZ57FyzpVI2c1RgKeES7Ti+ U7vae X-Gm-Gg: ATEYQzww1fZ89MJ/yDrmF0/lgTs0Phm9skgPFyIr5sQn/So1XfhHk9v+7It13tTJGkV 5KIAwI9xsMQ3QSpX8TWi7I1XjV3musd4lrfbb5wEXA3m7ADLC6m5mk2d2v+5vGdtD/LoXpnt5oL vfOG3Wee0HZk4NEAizPq4eehLNt8HKPIILZ+I8F5A9CYrcE2zov0m90pVYw/ugcMlgwKktuTnMs zxwLVPq0VApTJt0lctAQU6iOLd4HQcR5J+gCHU5bN5eYSyupqS35CdHfe2BRufHCo5zazE88/N5 pZ7g2YjMYYzhwEfNRPcPMBqrm/HG0FiiA6CJ4R/RIYvz7O86UDqnVwIdAr3F7rHRCbLfJxfoFzC Og4bdweIHtegekFtSWDSCpAvgDw84KjFiHSw/huNkH1GOrpR+XiT7QFXqWxrSM8a8EYGQfgB59i UDrc3V6B6FgrWXgnQmQ2xJIFFQ1PHF X-Received: by 2002:a05:600c:4591:b0:482:eec4:74c with SMTP id 5b1f17b1804b1-483c9bf0b3cmr22333205e9.22.1772176369643; Thu, 26 Feb 2026 23:12:49 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-483bd6f26d7sm210823865e9.3.2026.02.26.23.12.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Feb 2026 23:12:49 -0800 (PST) Date: Fri, 27 Feb 2026 10:12:46 +0300 From: Dan Carpenter To: Ethan Tidmore Cc: Mariyam Shahid , gregkh@linuxfoundation.org, ethan.tidmore@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: rtl8723bs: Fix logical continuation placement Message-ID: References: <20260226093811.30659-1-mariyam.shahid135@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Thu, Feb 26, 2026 at 07:31:34PM -0600, Ethan Tidmore wrote: > On Thu Feb 26, 2026 at 3:38 AM CST, Mariyam Shahid wrote: > > Move logical operators to the end of the previous line > > to fix checkpatch warnings. > > > > Signed-off-by: Mariyam Shahid > > --- > > ... > > > > - if (!(pmlmepriv->ht_op_mode & IEEE80211_HT_OP_MODE_NON_GF_STA_PRSNT) > > - && pmlmepriv->num_sta_ht_no_gf) { > > + if (!(pmlmepriv->ht_op_mode & IEEE80211_HT_OP_MODE_NON_GF_STA_PRSNT) && > > + pmlmepriv->num_sta_ht_no_gf) { > > This should be: > > if (!(pmlmepriv->ht_op_mode & IEEE80211_HT_OP_MODE_NON_GF_STA_PRSNT) && > pmlmepriv->num_sta_ht_no_gf) { Ideally, it would be aligned. if (!(pmlmepriv->ht_op_mode & IEEE80211_HT_OP_MODE_NON_GF_STA_PRSNT) && pmlmepriv->num_sta_ht_no_gf) { [tab][space * 4]pmlmepriv->num_sta_ht_no_gf) { regards, dan carpenter