From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8D6183603DD for ; Fri, 27 Feb 2026 07:53:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772178838; cv=none; b=fX5V7YsP8GTbXNxmsGF+Mdv+g9mX1MlCBVMrzrtgV+fCYNuRF7Oq8xWzgGmfa2i+HPUL/IbJsb9HFQFOtnEIRxTkGLvtMmjALhk/qRjEDnJw+aeLuzPOMZxzhbiKPmgh1Xiyk/QcnAm+gqfjtq85DOo62ndM3enUMuGk+yJh+Ww= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772178838; c=relaxed/simple; bh=h9syD6WVkAmzTGwQ3i1VIb80j/B9jUPw/Vy3A2x0Fv4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Ste/KBiwLns62VNnjne6eGizf16GJi6x3i0+qxrav8eV/NBDfOPPSbRfBtJpn1Hg3OrV2CeLieEIGnRjB2ozxnbWEUXILQwFpJ4fRhagidU8DzRfEPlzKKTpKDW+RZWlKPZf8PGQ67AFslnCKzf/wbv1jLw6eI7KfCwFB0rOrXk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ER/OexAf; arc=none smtp.client-ip=209.85.214.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ER/OexAf" Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-2addb31945aso12966245ad.1 for ; Thu, 26 Feb 2026 23:53:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772178836; x=1772783636; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=evrPnhC7VvTZpi7YgqhzDnPSPz72Yoy2AMHX8h76Rd4=; b=ER/OexAfSaNT2a8Zn4t9yC+HtuLjm5H6DDp1rLwM67p15aMrxbUgPkkdqUh4Uk+99l KEZwLGdQO0bkr82e3uh550EMK87ySO+n4Wv5LWcL6fIOIlm0qXYLHnH2Am1fJStQATHg 7Vk4gPNgNUB6suw4bj0/TRqy0m2aikdyL9O3BV7SPrk/KH9UmWxHuowZdit17Y7MQB4m dlhkTuSSZG8n51tdV1E9MqbYuSMGfEvfcAh9fvTtIHutmxp2V7hBioLy//yCtiRwiKAG 7Kk+p9DLLP3n/H3v7eUgNUxZGenpp3363Zp3YipchJ+D5la2WFGI02t8j4DVx1TXRwo5 KcVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772178836; x=1772783636; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=evrPnhC7VvTZpi7YgqhzDnPSPz72Yoy2AMHX8h76Rd4=; b=qt8XLPY7Mk848+k/K94wrWhkCZdCgt9XjAk07cR9DeL2SO5/OtDdicLukJM1S0K7Rj R59cIpag2ZN5Rekv9ofUFbHsAB/z3SOHMoC/++Fiw1Rp0YGHzas3tEec4TO7nMYq9MaG zBmR+WGM/7+Q6Y0eEjgSOs1QfhYh89onaTn8+w8YSYeARqKRTTMEmh3LSujhrLX5UUYY VS3Sp0l+NrtiL7UrG1TBw6ZAwtj2Ji1WnZY54tmq8rYELSInZZRbOWIL7VZj5NqJL0R+ UwEqaxM8xwEAQ65ycCo9KZf28zi5ob89Zx0QoUwtAIerv0JkbCEankhpr3vKRbzUWB07 biYA== X-Forwarded-Encrypted: i=1; AJvYcCVWLjZZlFY69QK+EHkptu0W9ZvexEN0rRBOp69xgIV0W9FWoS4RTqky6cCGlRs33+6fGzWcJcIJwPwkf3Q=@vger.kernel.org X-Gm-Message-State: AOJu0Yx8KfvQShn2YcD/rVP4CPBoCH9v0PCbry1xauObgXAbS7YDEabU y9rZL558/ayeJUM2W4UZe5gmu1lQ0Y712pLjihg1e8jxRc3GRK8e2eaB X-Gm-Gg: ATEYQzxIzfnmqUrk1SYZUcVEHXsRiZsF5fd3L5fPtFoVUGvywiWMGZ/CNz5/L7v8aLR k7BsjRqCsSfnoN7IrFJMc6o2XZ18cAiaqQ8BrQDc0HCgyor0+tiqOZ5XzlbMlqI2iUcwQVYHyKJ nyM4isdtAfjluJWmIbZ/aUNT2d8UwaJ5XwTQJH6mEcXKPwxyz0o/NONARS0kAp1rfWeA7afW4MI 1xqMQ1PqdYtDoew8GSQdXbyIqa4dWsMyV8FplqDX5L8I83E/7BmMSaa1Z/hdM6f7qNEj2xolPec mpT5RtudoNKOAn6HCYEJIkkO+FbME15IOaMBQ/4/1CFmIuk7KBs/nDacIAuyFE2uv7iO3ajvZrH mVWE/A0SjHChua3BwDPVsboF3L6pi7HFVUjP8Jry6QFlz5bpgQXdmZAeLRxpJZkD14oeAtJA7DR oH9LAXm4mT8Ykt4WsMOdv1Fq72CYA= X-Received: by 2002:a17:903:1208:b0:2ab:3cba:42fa with SMTP id d9443c01a7336-2ae2e4b4c52mr19615825ad.46.1772178835895; Thu, 26 Feb 2026 23:53:55 -0800 (PST) Received: from fedora ([209.132.188.88]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2adfb5b257esm46817515ad.4.2026.02.26.23.53.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Feb 2026 23:53:55 -0800 (PST) Date: Fri, 27 Feb 2026 07:53:46 +0000 From: Hangbin Liu To: netdev@vger.kernel.org Cc: Jay Vosburgh , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Sridhar Samudrala , Jiri Pirko , Simon Horman , Nikolay Aleksandrov , Ido Schimmel , Stanislav Fomichev , Kuniyuki Iwashima , Samiullah Khawaja , Alexander Lobakin , linux-kernel@vger.kernel.org, bridge@lists.linux.dev Subject: Re: [RFC PATCH net-next 2/3] net: use ndo_update_offloads for bonding/bridge/team Message-ID: References: <20260226114208.27774-1-liuhangbin@gmail.com> <20260226114208.27774-3-liuhangbin@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260226114208.27774-3-liuhangbin@gmail.com> On Thu, Feb 26, 2026 at 11:42:07AM +0000, Hangbin Liu wrote: > Convert bonding, bridge, and team drivers to use the new > ndo_update_offloads callback instead of manually calling > netdev_compute_master_upper_features() during port add/remove operations. > > This change centralizes the feature computation flow: > > Before: > - netdev_compute_master_upper_features() > - compute offload features > - netdev_change_features() > - __netdev_update_features() > - update other features > > After: > - netdev_master_upper_dev_link() > - __netdev_upper_dev_link() > - netdev_change_features() > - __netdev_update_features() > - ndo_update_offloads() > - netdev_compute_master_upper_features() > - update other features > > This ensures offload features are computed automatically when > upper/lower device links change, removing the need for manual > feature computation calls in the driver code. > > The netdev_change_features() call in team_uninit() is also removed > since it calls team_port_del() for each port, which now triggers > feature updates automatically. > > Signed-off-by: Hangbin Liu > --- > drivers/net/bonding/bond_main.c | 10 +++++++--- > drivers/net/team/team_core.c | 11 +++++++---- > net/bridge/br_device.c | 6 ++++++ > net/bridge/br_if.c | 4 ---- > net/core/dev.c | 8 ++++++-- > 5 files changed, 26 insertions(+), 13 deletions(-) > > diff --git a/net/core/dev.c b/net/core/dev.c > index d05837c0713a..7043ee022980 100644 > --- a/net/core/dev.c > +++ b/net/core/dev.c > @@ -8893,6 +8893,9 @@ static int __netdev_upper_dev_link(struct net_device *dev, > __netdev_walk_all_upper_dev(upper_dev, __netdev_update_lower_level, > priv); > > + /* re-compute all features after adding link */ > + netdev_change_features(upper_dev); > + > return 0; Another benefit for this change is, after calling netdev_change_features() here, the later netdev_sync_lower_features() will disable LRO automatically. So we don't need to call dev_disable_lro() manually in bonding/bridge/team/VLAN. I will add this patch in next version. Hangbin