From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 31DB8155A5D for ; Fri, 27 Feb 2026 08:03:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=198.175.65.16 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772179431; cv=fail; b=guPoKfqDnVm8uZRYH+At0UI3ZGVthte6T045TRSIpstvJFle0yqsC0PETCzrIaD4zsTayIGh1xPm6k8/3g0kmsgEZdpLiEV+WNAHSWzYioJMmIokAZKezRQVb7xqRXdOtsBToYPtq4+Sy216pMXp56mbrIjNCnPS0kCiBdCCJCg= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772179431; c=relaxed/simple; bh=1aIttrS4oqqa/6FtUQDV7bBPsFimSM1IJXg8mBpCHgg=; h=Date:From:To:CC:Subject:Message-ID:References:Content-Type: Content-Disposition:In-Reply-To:MIME-Version; b=rsdGfvcW1Sm2G3w7PoIqh+1Fn8AHJPGXB67yRdrJnEhSDkBHH1eIccLMyUam4a79X76vIw5yxhaNHjaeeZG4otEQK28RAp8VgUEBHs+2tevnCAvaIJkpYArv1E7Poq8MbOt8hLnvsbZXUwrHz3B8UxYdK9vhuJavU5FTrpi/Hwk= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=ZSh3cXYa; arc=fail smtp.client-ip=198.175.65.16 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="ZSh3cXYa" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1772179430; x=1803715430; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=1aIttrS4oqqa/6FtUQDV7bBPsFimSM1IJXg8mBpCHgg=; b=ZSh3cXYaEl8n/gnbu+zjGHwm9tGpILA9Yv9ryKwhgehGqHKccUl4cITc kIuf4M7oUVhjrXnMAvUOA0k1E6szq6xEXfz8OZvDUg9H7F882hnxct/MC yZPJH/8PxMEwLkXxP9ukYfoo1cAimnSKXZ+IMPl04d/j25CmKzWHy1r9v pxL8+OYAF+F9lHxJ49mh7lEuGNFl61LCuDTg7I9/L2bxJUQdI6hm/vveg PnbE33xb0iSvglD1Ha1o2EW1k/XS9ixAccPOSNC+73kZBa3yb4ithso/7 MiKEpL0hAJ2Mo/P8r9tT3hiG9QOzQgGtSx1gZuIbn/3FaRfcZNluy5x8G w==; X-CSE-ConnectionGUID: xAsNaqwtQmKk3D2oA5l9ng== X-CSE-MsgGUID: uUOy7wz7S8GykgL3ixRq0Q== X-IronPort-AV: E=McAfee;i="6800,10657,11713"; a="73442972" X-IronPort-AV: E=Sophos;i="6.21,313,1763452800"; d="scan'208";a="73442972" Received: from fmviesa006.fm.intel.com ([10.60.135.146]) by orvoesa108.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Feb 2026 00:03:49 -0800 X-CSE-ConnectionGUID: iJ8REfuvS8i1neSGtplflg== X-CSE-MsgGUID: LtL9DMCJRqCCVF0ulp5UyA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,313,1763452800"; d="scan'208";a="214277705" Received: from fmsmsx901.amr.corp.intel.com ([10.18.126.90]) by fmviesa006.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Feb 2026 00:03:50 -0800 Received: from FMSMSX901.amr.corp.intel.com (10.18.126.90) by fmsmsx901.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37; Fri, 27 Feb 2026 00:03:49 -0800 Received: from fmsedg902.ED.cps.intel.com (10.1.192.144) by FMSMSX901.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37 via Frontend Transport; Fri, 27 Feb 2026 00:03:49 -0800 Received: from CO1PR03CU002.outbound.protection.outlook.com (52.101.46.5) by edgegateway.intel.com (192.55.55.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37; Fri, 27 Feb 2026 00:03:48 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=W50Sv++aEIyawzRQtWeia+Ow298bTEdcIYMgyToYZFfdN/hT4ym49pVxiAkP+CSOUDqwx8PqVC6JE9uAm5LEq7etyPQMn/HJoe4rOVof3+rv57L5HPlrM7sgvar4z8DFuTBN9K5Wbz/IEWjKZGgB5g+UwBAFiIGsUsF3ym0a2ZtOgS92tXIGBFJL5VMDIfpigQeXIAWzGuTeJgfquo1ckzcgJcAUNR6J+01mvHaM+Dk8nXY7OiQctASAl9Pj3S3UXK2A20SKEFNhvP5i47s0opPWHeMnYfF1EOZh+5wv1GxEwK+Tsw1FkjzVCCX7uiHV0OFzpPl/vOvPTwNW+wdmhA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=t4avIhTtHSWcWLAhoRK0KAPktXnBs3epH9d9XDgU33U=; b=eF6OX9lCEXki6jdxXuwUdLn7njaSNXmI73p8/ozXJOCSC5/V4Nyaam8ncZwzV0OSXOiRXx2TuEzI5SjBxm+ujYIOEaIuFsPjFil2tW8TMKwFTQHj1A83nDdV/rnjhxsGgI1J5XGXfZjodXl0V42bhHLfHM5xubEcqCgvOuZsFX7g9smHLQhzI8XfjcXjq5udRZY01x6sDyIwopwRseIHdma8O/X5hCQekTwsfCUWzp6YUB1R3AKTlFNYG0aXfLwjQ8bFJkgdNUjC2YMArc5PRjTAoDPv5lBmFy89TDSSHjIMztxFv9V4ryi5bLtwKXiFVTGUI0WR6sAAZC5okZhDRw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from SA1PR11MB8393.namprd11.prod.outlook.com (2603:10b6:806:373::21) by IA4PR11MB9279.namprd11.prod.outlook.com (2603:10b6:208:561::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9587.18; Fri, 27 Feb 2026 08:03:47 +0000 Received: from SA1PR11MB8393.namprd11.prod.outlook.com ([fe80::804e:63d1:f2ce:7ce4]) by SA1PR11MB8393.namprd11.prod.outlook.com ([fe80::804e:63d1:f2ce:7ce4%6]) with mapi id 15.20.9654.014; Fri, 27 Feb 2026 08:03:46 +0000 Date: Fri, 27 Feb 2026 16:02:53 +0800 From: Yujie Liu To: CC: Alex Deucher , Christian =?iso-8859-1?Q?K=F6nig?= , David Airlie , Simona Vetter , Kenneth Feng , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Patrik Jakobsson , Matthew Brost , Danilo Krummrich , Thomas =?iso-8859-1?Q?Hellstr=F6m?= , Rodrigo Vivi , Pierre-Eric Pelloux-Prayer , "Srinivasan Shanmugam" , Tvrtko Ursulin , Sunil Khatri , Lijo Lazar , Asad Kamal , Yang Wang , Hawking Zhang , Tao Zhou , Gangliang Xie , Candice Li , YiPeng Chai , Matthew Auld , Luben Tuikov , Ville =?iso-8859-1?Q?Syrj=E4l=E4?= , =?utf-8?Q?Micha=C5=82?= Winiarski , "Michal Wajdeczko" , , , , Subject: Re: [PATCH 2/7] drm/scheduler: fix kernel-doc warning for drm_sched_job_done() Message-ID: References: <20260226030038.1182961-1-yujie.liu@intel.com> <20260226030038.1182961-3-yujie.liu@intel.com> Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: KL1P15301CA0057.APCP153.PROD.OUTLOOK.COM (2603:1096:820:3d::19) To SA1PR11MB8393.namprd11.prod.outlook.com (2603:10b6:806:373::21) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SA1PR11MB8393:EE_|IA4PR11MB9279:EE_ X-MS-Office365-Filtering-Correlation-Id: d4b1dfa1-bf26-47a0-1efe-08de75d6bb99 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|366016|1800799024|7416014|7053199007; X-Microsoft-Antispam-Message-Info: c7c+tCQPMWcTQYHUIPr3EmW2NtVx/aqd4wOQgUK+xfwHLQK0y2J1S6LOwW+P+i1W7lf/RLn8tE9QdNUvs12w2nDGCScM4unn6eHyOYXxCaR8uXf5gdmNoPPU0ew4X2D1JV+kfF0mquKMeYnnx9jwuFtTDP3MX8F1uC9I1tBsfVTYlQpOBFNQ0ckVkUunN2+Zewn6arYbcG53HxPDfpE0mEIb/ztNEUgN7fBviySumiVgLykL8CHgacaQ/tUGJTYJBMhWhw4ctDdmYTET0tepb7Yrzy0itXUxaWr7gSHcoVY2BvMS4gECYnzvl/ItjvuEgqBcTNhNnEWL3fetldiNEhyIbjPzv2E2XW5UM2O3bcA8l+VDprpthHRl5pQn2C58HiB+4SYsBdcjt3ePt8ZQ978wThNN6Bl4zy96oIn/pF+H0PquUlfYFXZcctIgEiPnLDxV7OrLTD1j6H2ZWyq2WTO5ayvG5LoV+K0d+D+YomGCSHvgSXGcHgVXy3+M4h7e5aoUKTHn8qR+DRGWqVgOBr4IPVz3ZJJWikJ2udo9wybVSBJ8Mbarf/fa+Q1hkeFMODcdAxEnq2aXUINdf9ykEqvTVwrx7BMd2F9U98rHeXRcKOYDJcWwg7lQFnmFk8TzQr6xZNPXfBHQgqWOXUfeSy1o54I3UCT7/mEPmCbkDCe9dFE5wMzqMayBUEXtZWQz X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SA1PR11MB8393.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(366016)(1800799024)(7416014)(7053199007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?735Qe0xfBNLVOrPyNf5MBIV9G1zK3tibA72wiCKLqT3Li5TlNxqBlxhCA0?= =?iso-8859-1?Q?frlU6RDUOxSZwVV/k1v5+iihUPen3BBGrhvhEOqof/yFfPRxbTPxaf96II?= =?iso-8859-1?Q?O1qdn2pCMppQzntyDaxhtcRMYjdhjkUXk+CnsOhF7hRma2yq414OMkz7Pm?= =?iso-8859-1?Q?ntjuk/Nx0VIj4iwx9P06E7ZDH/rJfDRZzhx/ChPMz5Mp8CtFh1XgfWOK7i?= =?iso-8859-1?Q?GjYQi+LoGOR9XEQRvDzY1VqmgT9mw5V2b1CX8j/wdIedROOB1ijvsR/y6Z?= =?iso-8859-1?Q?n3pBduKCijfDKPfikiW3vpLO7KtVRszFCarV9xX7SLpyv6I0gqakDLaCDQ?= =?iso-8859-1?Q?fmJAVXFqjchnKSfTZUih4SUFUBG93wbfV9jQo4y6idkhVXL/PsB99jkQqY?= =?iso-8859-1?Q?MwtfMfuiaIIwEvwQQ+bKzbk5wRG7uBtMpsmqpchNKqRFq9vbf2iwrP75kr?= =?iso-8859-1?Q?dUbiBTewHhsz/AOBNZMAyhp7nA+6p6TlrqwnafURRqY111i+JKfYrJi1l1?= =?iso-8859-1?Q?mlWDPY4Ape0pO7u+oejY6CEwXcIRfYhJVP9M/hqILkdRlF47Look+Cq3fF?= =?iso-8859-1?Q?rNOj+sO5TzjHy0M8eO8Ykpw1+F6U/b9SCmPDHJWQtnGiwgQJKnQuLrxxX8?= =?iso-8859-1?Q?e10XNKIwPOxCf4E7t8qBKqNEu07TBF0QSYDExZQEZQRoTRg5dKP9Q/8a59?= =?iso-8859-1?Q?4CKhAUer0pEPSl2kDvdGGxELA7wKyA8SP+WQyfcVFm8WPm19sXIIsWuqOo?= =?iso-8859-1?Q?5FXSyrY7tghgUaTPKqTGhcILTJkeAF4kV4jz/zGG05Uq/f/PyUY8Z4cho9?= =?iso-8859-1?Q?EJlzGFW4I/E/bJT5f9qkdfksP4JrbIsVpBdhjcw3sGQLL/3SFziip7lpwl?= =?iso-8859-1?Q?hmYWvZBm1FKKmVbIYEgVzk3APTVEo2ZfKAwDMJNCPgGdo6HrYuvVC8+uoF?= =?iso-8859-1?Q?urnn01vmjVI5h3XktTsDhM4xlfcJugaj5AnNPqTMwCXpMLab9dWzPgskAq?= =?iso-8859-1?Q?H8zDSE+lHfjzrBFdEqSTMA7QMq5sP6sL1aICEHyaDLZFhq0wDuq5vkM/mq?= =?iso-8859-1?Q?Mj5sIaNko8ZXaIwnLvDnCV1xvejBvn6pXxoJTbgUZGp5nJr8pAqeBUCjM+?= =?iso-8859-1?Q?SUfhexCb3zWiVPjlB9u9iqpL0ifJkZyEA3BaR2pK/t9HdfCAAWf8l/QC/F?= =?iso-8859-1?Q?0EJy2akaX+UwuK0eMGiEDpbQ8VhA5JJ7fqZ/VlCQeKv7l5YqPbgjyAyCCf?= =?iso-8859-1?Q?+PiGrqnFSFcZEOKucTtH3eb6UcVOeIJa2qIT0Hy1H3IQE9OxJIEZfgho+6?= =?iso-8859-1?Q?yIsixLiu1OtQBLpqcj+kSYUo9xY0OcMYlZjo1/EQofcfpX+F0tDukgaNdc?= =?iso-8859-1?Q?VmAY4RecRPnwF9eY9kNi4SeIXB4qJ0XNa++ylfkXcasbGHZLzI7yZ39PcX?= =?iso-8859-1?Q?1vq27c3S6Hx6CgJpKbIQntVti4osoU7DSvBRDyuMkUGDF/hObgIkpI4zRP?= =?iso-8859-1?Q?BYLvR8Hdox0DN4XGtJsyEjtHzAcVgdMm5NOKWSN1nYB/ySq6F9uvLp+2j2?= =?iso-8859-1?Q?KdRWCHC/b5vb+4gWvxuMU7fpaO40xM5MIcPNymnbWvbTZE57hHZP278Bxd?= =?iso-8859-1?Q?11+RdX8SrMeseq2XE8G1ZX8tjk8++uMTmF4TSpTbl0ZBommqy2hNhJovbt?= =?iso-8859-1?Q?WmnrwPDwo7hjocwtIieLDvp9AI0g6Z2TbH0KFUf906dwc8N3983Aj/pDQT?= =?iso-8859-1?Q?0nbOEnqvR1DjnNbS0efYL5kSbeGlrK8iubNbrEuT4lCa70t9mIbYXam0OG?= =?iso-8859-1?Q?sbeuyof0IA=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: d4b1dfa1-bf26-47a0-1efe-08de75d6bb99 X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB8393.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Feb 2026 08:03:46.8074 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: U4UMKWqmM+/vcnXEe3zVJ2TxWGibG5ImG0FddD4NthQ1/rt8KccdZ0jH5ranEMrfauux5ec34opPW7g7NzgkmA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA4PR11MB9279 X-OriginatorOrg: intel.com On Fri, Feb 27, 2026 at 07:47:42AM +0100, Philipp Stanner wrote: > On Thu, 2026-02-26 at 11:00 +0800, Yujie Liu wrote: > > Warning: drivers/gpu/drm/scheduler/sched_main.c:367 function parameter 'result' not described in 'drm_sched_job_done' > > > > Fixes: 539f9ee4b52a ("drm/scheduler: properly forward fence errors") > > Signed-off-by: Yujie Liu > > Thanks for fixing this! > > Acked-by: Philipp Stanner Hi Philipp, Thanks for reviewing this. Following Christian's suggestion to split this set into individual patches for different subsystem branches, I've sent a v2 at [1] with less audience. Sorry for bothering too many people on these minor kernel-doc fixes. [1] https://lore.kernel.org/all/20260227061052.1752354-1-yujie.liu@intel.com/ > > > --- > >  drivers/gpu/drm/scheduler/sched_main.c | 1 + > >  1 file changed, 1 insertion(+) > > > > diff --git a/drivers/gpu/drm/scheduler/sched_main.c b/drivers/gpu/drm/scheduler/sched_main.c > > index e6ee35406165..fe4c1017734b 100644 > > --- a/drivers/gpu/drm/scheduler/sched_main.c > > +++ b/drivers/gpu/drm/scheduler/sched_main.c > > @@ -361,6 +361,7 @@ static void drm_sched_run_free_queue(struct drm_gpu_scheduler *sched) > >  /** > >   * drm_sched_job_done - complete a job > >   * @s_job: pointer to the job which is done > > + * @result: 0 on success; -errno on failure > > nit: shouldn't it be -ERRNO? But idk. Thanks, indeed it should be capital letters. Will respin a v3 with you CC'd. > > >   * > >   * Finish the job's fence and resubmit the work items. > >   */ >