[PATCH 0/7] drm: fix some kernel-doc warnings

[PATCH 0/7] drm: fix some kernel-doc warnings

[Yujie Liu]

Yujie Liu (7):
  drm/gpusvm: fix kernel-doc warning for
    drm_gpusvm_pages_valid_unlocked()
  drm/scheduler: fix kernel-doc warning for drm_sched_job_done()
  drm/gma500: fix kernel-doc warning for framebuffer init/create
    functions
  drm/amdgpu: fix kernel-doc warning for
    amdgpu_ttm_alloc_mmio_remap_bo()
  drm/xe/pf: fix kernel-doc warning for SR-IOV VF restore function
  drm/amd/pm: fix kernel-doc warning for smu_msg_v1_send_msg()
  drm/amd/ras: fix kernel-doc warning for ras_eeprom_append()

 drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c      | 2 +-
 drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c       | 2 +-
 drivers/gpu/drm/amd/ras/rascore/ras_eeprom.c | 4 ++--
 drivers/gpu/drm/drm_gpusvm.c                 | 4 ++--
 drivers/gpu/drm/gma500/framebuffer.c         | 2 ++
 drivers/gpu/drm/scheduler/sched_main.c       | 1 +
 drivers/gpu/drm/xe/xe_gt_sriov_pf_control.c  | 2 +-
 7 files changed, 10 insertions(+), 7 deletions(-)

-- 
2.43.0

[PATCH 1/7] drm/gpusvm: fix kernel-doc warning for drm_gpusvm_pages_valid_unlocked()

[Yujie Liu]

Warning: drivers/gpu/drm/drm_gpusvm.c:1351 function parameter 'svm_pages' not described in 'drm_gpusvm_pages_valid_unlocked'
Warning: drivers/gpu/drm/drm_gpusvm.c:1351 expecting prototype for drm_gpusvm_range_pages_valid_unlocked(). Prototype was for drm_gpusvm_pages_valid_unlocked() instead

Fixes: 6364afd532bc ("drm/gpusvm: refactor core API to use pages struct")
Signed-off-by: Yujie Liu <yujie.liu@intel.com>
---
 drivers/gpu/drm/drm_gpusvm.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/drm_gpusvm.c b/drivers/gpu/drm/drm_gpusvm.c
index 24180bfdf5a2..93f7e594256d 100644
--- a/drivers/gpu/drm/drm_gpusvm.c
+++ b/drivers/gpu/drm/drm_gpusvm.c
@@ -1338,9 +1338,9 @@ bool drm_gpusvm_range_pages_valid(struct drm_gpusvm *gpusvm,
 EXPORT_SYMBOL_GPL(drm_gpusvm_range_pages_valid);
 
 /**
- * drm_gpusvm_range_pages_valid_unlocked() - GPU SVM range pages valid unlocked
+ * drm_gpusvm_pages_valid_unlocked() - GPU SVM range pages valid unlocked
  * @gpusvm: Pointer to the GPU SVM structure
- * @range: Pointer to the GPU SVM range structure
+ * @svm_pages: Pointer to the GPU SVM pages structure
  *
  * This function determines if a GPU SVM range pages are valid. Expected be
  * called without holding gpusvm->notifier_lock.
-- 
2.43.0

Re: [PATCH 1/7] drm/gpusvm: fix kernel-doc warning for drm_gpusvm_pages_valid_unlocked()

[Matthew Brost]

On Thu, Feb 26, 2026 at 11:00:32AM +0800, Yujie Liu wrote:
> Warning: drivers/gpu/drm/drm_gpusvm.c:1351 function parameter 'svm_pages' not described in 'drm_gpusvm_pages_valid_unlocked'
> Warning: drivers/gpu/drm/drm_gpusvm.c:1351 expecting prototype for drm_gpusvm_range_pages_valid_unlocked(). Prototype was for drm_gpusvm_pages_valid_unlocked() instead
> 
> Fixes: 6364afd532bc ("drm/gpusvm: refactor core API to use pages struct")

I fix this one already. Believe it merged yesterday.

74b6e83942dc drm/gpusvm: Fix drm_gpusvm_pages_valid_unlocked() kernel-doc

Matt

> Signed-off-by: Yujie Liu <yujie.liu@intel.com>
> ---
>  drivers/gpu/drm/drm_gpusvm.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/drm_gpusvm.c b/drivers/gpu/drm/drm_gpusvm.c
> index 24180bfdf5a2..93f7e594256d 100644
> --- a/drivers/gpu/drm/drm_gpusvm.c
> +++ b/drivers/gpu/drm/drm_gpusvm.c
> @@ -1338,9 +1338,9 @@ bool drm_gpusvm_range_pages_valid(struct drm_gpusvm *gpusvm,
>  EXPORT_SYMBOL_GPL(drm_gpusvm_range_pages_valid);
>  
>  /**
> - * drm_gpusvm_range_pages_valid_unlocked() - GPU SVM range pages valid unlocked
> + * drm_gpusvm_pages_valid_unlocked() - GPU SVM range pages valid unlocked
>   * @gpusvm: Pointer to the GPU SVM structure
> - * @range: Pointer to the GPU SVM range structure
> + * @svm_pages: Pointer to the GPU SVM pages structure
>   *
>   * This function determines if a GPU SVM range pages are valid. Expected be
>   * called without holding gpusvm->notifier_lock.
> -- 
> 2.43.0
> 

Re: [PATCH 1/7] drm/gpusvm: fix kernel-doc warning for drm_gpusvm_pages_valid_unlocked()

[Yujie Liu]

On Wed, Feb 25, 2026 at 07:06:25PM -0800, Matthew Brost wrote:
> On Thu, Feb 26, 2026 at 11:00:32AM +0800, Yujie Liu wrote:
> > Warning: drivers/gpu/drm/drm_gpusvm.c:1351 function parameter 'svm_pages' not described in 'drm_gpusvm_pages_valid_unlocked'
> > Warning: drivers/gpu/drm/drm_gpusvm.c:1351 expecting prototype for drm_gpusvm_range_pages_valid_unlocked(). Prototype was for drm_gpusvm_pages_valid_unlocked() instead
> > 
> > Fixes: 6364afd532bc ("drm/gpusvm: refactor core API to use pages struct")
> 
> I fix this one already. Believe it merged yesterday.

Thanks. I will drop this patch and respin the series after waiting
briefly for possible comments on other patches.

Yujie

> 
> 74b6e83942dc drm/gpusvm: Fix drm_gpusvm_pages_valid_unlocked() kernel-doc
> 
> Matt

Re: [PATCH 1/7] drm/gpusvm: fix kernel-doc warning for drm_gpusvm_pages_valid_unlocked()

[Christian König]

On 2/26/26 06:56, Yujie Liu wrote:
> [Some people who received this message don't often get email from yujie.liu@intel.com. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
> 
> On Wed, Feb 25, 2026 at 07:06:25PM -0800, Matthew Brost wrote:
>> On Thu, Feb 26, 2026 at 11:00:32AM +0800, Yujie Liu wrote:
>>> Warning: drivers/gpu/drm/drm_gpusvm.c:1351 function parameter 'svm_pages' not described in 'drm_gpusvm_pages_valid_unlocked'
>>> Warning: drivers/gpu/drm/drm_gpusvm.c:1351 expecting prototype for drm_gpusvm_range_pages_valid_unlocked(). Prototype was for drm_gpusvm_pages_valid_unlocked() instead
>>>
>>> Fixes: 6364afd532bc ("drm/gpusvm: refactor core API to use pages struct")
>>
>> I fix this one already. Believe it merged yesterday.
> 
> Thanks. I will drop this patch and respin the series after waiting
> briefly for possible comments on other patches.

I also strongly suggest to split that patch set up by driver/subsystem and send it out individually. So that we can upstream it through different branches.

When it is send out as one patch set then that usually indicates that in needs to be applied in that order. That is clearly not the case here, but it would be nice to have it separately in my inbox.

Apart from that, thanks for taking care of that.

Christian.

> 
> Yujie
> 
>>
>> 74b6e83942dc drm/gpusvm: Fix drm_gpusvm_pages_valid_unlocked() kernel-doc
>>
>> Matt

Re: [PATCH 1/7] drm/gpusvm: fix kernel-doc warning for drm_gpusvm_pages_valid_unlocked()

[Yujie Liu]

On Thu, Feb 26, 2026 at 12:39:01PM +0100, Christian König wrote:
> On 2/26/26 06:56, Yujie Liu wrote:
> > [Some people who received this message don't often get email from yujie.liu@intel.com. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
> > 
> > On Wed, Feb 25, 2026 at 07:06:25PM -0800, Matthew Brost wrote:
> >> On Thu, Feb 26, 2026 at 11:00:32AM +0800, Yujie Liu wrote:
> >>> Warning: drivers/gpu/drm/drm_gpusvm.c:1351 function parameter 'svm_pages' not described in 'drm_gpusvm_pages_valid_unlocked'
> >>> Warning: drivers/gpu/drm/drm_gpusvm.c:1351 expecting prototype for drm_gpusvm_range_pages_valid_unlocked(). Prototype was for drm_gpusvm_pages_valid_unlocked() instead
> >>>
> >>> Fixes: 6364afd532bc ("drm/gpusvm: refactor core API to use pages struct")
> >>
> >> I fix this one already. Believe it merged yesterday.
> > 
> > Thanks. I will drop this patch and respin the series after waiting
> > briefly for possible comments on other patches.
> 
> I also strongly suggest to split that patch set up by driver/subsystem and send it out individually. So that we can upstream it through different branches.
> 
> When it is send out as one patch set then that usually indicates that in needs to be applied in that order. That is clearly not the case here, but it would be nice to have it separately in my inbox.

Thank you very much for the guidance. I'll keep this in mind and
carefully follow the rules and upstream workflow.

Since patch 1 and 5 have already been fixed, and patch 4, 6, 7 have been
picked up by Alex, I'll respin to send out patch 2 and 3 individually.

Best Regards,
Yujie

[PATCH 2/7] drm/scheduler: fix kernel-doc warning for drm_sched_job_done()

[Yujie Liu]

Warning: drivers/gpu/drm/scheduler/sched_main.c:367 function parameter 'result' not described in 'drm_sched_job_done'

Fixes: 539f9ee4b52a ("drm/scheduler: properly forward fence errors")
Signed-off-by: Yujie Liu <yujie.liu@intel.com>
---
 drivers/gpu/drm/scheduler/sched_main.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/scheduler/sched_main.c b/drivers/gpu/drm/scheduler/sched_main.c
index e6ee35406165..fe4c1017734b 100644
--- a/drivers/gpu/drm/scheduler/sched_main.c
+++ b/drivers/gpu/drm/scheduler/sched_main.c
@@ -361,6 +361,7 @@ static void drm_sched_run_free_queue(struct drm_gpu_scheduler *sched)
 /**
  * drm_sched_job_done - complete a job
  * @s_job: pointer to the job which is done
+ * @result: 0 on success; -errno on failure
  *
  * Finish the job's fence and resubmit the work items.
  */
-- 
2.43.0

Re: [PATCH 2/7] drm/scheduler: fix kernel-doc warning for drm_sched_job_done()

[Philipp Stanner]

On Thu, 2026-02-26 at 11:00 +0800, Yujie Liu wrote:
> Warning: drivers/gpu/drm/scheduler/sched_main.c:367 function parameter 'result' not described in 'drm_sched_job_done'
> 
> Fixes: 539f9ee4b52a ("drm/scheduler: properly forward fence errors")
> Signed-off-by: Yujie Liu <yujie.liu@intel.com>

Thanks for fixing this!

Acked-by: Philipp Stanner <phasta@kernel.org>

> ---
>  drivers/gpu/drm/scheduler/sched_main.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/scheduler/sched_main.c b/drivers/gpu/drm/scheduler/sched_main.c
> index e6ee35406165..fe4c1017734b 100644
> --- a/drivers/gpu/drm/scheduler/sched_main.c
> +++ b/drivers/gpu/drm/scheduler/sched_main.c
> @@ -361,6 +361,7 @@ static void drm_sched_run_free_queue(struct drm_gpu_scheduler *sched)
>  /**
>   * drm_sched_job_done - complete a job
>   * @s_job: pointer to the job which is done
> + * @result: 0 on success; -errno on failure

nit: shouldn't it be -ERRNO? But idk.

>   *
>   * Finish the job's fence and resubmit the work items.
>   */

Re: [PATCH 2/7] drm/scheduler: fix kernel-doc warning for drm_sched_job_done()

[Yujie Liu]

On Fri, Feb 27, 2026 at 07:47:42AM +0100, Philipp Stanner wrote:
> On Thu, 2026-02-26 at 11:00 +0800, Yujie Liu wrote:
> > Warning: drivers/gpu/drm/scheduler/sched_main.c:367 function parameter 'result' not described in 'drm_sched_job_done'
> > 
> > Fixes: 539f9ee4b52a ("drm/scheduler: properly forward fence errors")
> > Signed-off-by: Yujie Liu <yujie.liu@intel.com>
> 
> Thanks for fixing this!
> 
> Acked-by: Philipp Stanner <phasta@kernel.org>

Hi Philipp,

Thanks for reviewing this.

Following Christian's suggestion to split this set into individual
patches for different subsystem branches, I've sent a v2 at [1] with
less audience. Sorry for bothering too many people on these minor
kernel-doc fixes.

[1] https://lore.kernel.org/all/20260227061052.1752354-1-yujie.liu@intel.com/

> 
> > ---
> >  drivers/gpu/drm/scheduler/sched_main.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/gpu/drm/scheduler/sched_main.c b/drivers/gpu/drm/scheduler/sched_main.c
> > index e6ee35406165..fe4c1017734b 100644
> > --- a/drivers/gpu/drm/scheduler/sched_main.c
> > +++ b/drivers/gpu/drm/scheduler/sched_main.c
> > @@ -361,6 +361,7 @@ static void drm_sched_run_free_queue(struct drm_gpu_scheduler *sched)
> >  /**
> >   * drm_sched_job_done - complete a job
> >   * @s_job: pointer to the job which is done
> > + * @result: 0 on success; -errno on failure
> 
> nit: shouldn't it be -ERRNO? But idk.

Thanks, indeed it should be capital letters. Will respin a v3 with you
CC'd.

> 
> >   *
> >   * Finish the job's fence and resubmit the work items.
> >   */
> 

[PATCH 3/7] drm/gma500: fix kernel-doc warning for framebuffer init/create functions

[Yujie Liu]

Warning: drivers/gpu/drm/gma500/framebuffer.c:34 function parameter 'info' not described in 'psb_framebuffer_init'
Warning: drivers/gpu/drm/gma500/framebuffer.c:101 function parameter 'info' not described in 'psb_user_framebuffer_create'

Fixes: 4a792c59203b ("drm/gma500: Pass along the format info from .fb_create() to drm_helper_mode_fill_fb_struct()")
Signed-off-by: Yujie Liu <yujie.liu@intel.com>
---
 drivers/gpu/drm/gma500/framebuffer.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/gma500/framebuffer.c b/drivers/gpu/drm/gma500/framebuffer.c
index fe1f43f0abff..5263eff6e462 100644
--- a/drivers/gpu/drm/gma500/framebuffer.c
+++ b/drivers/gpu/drm/gma500/framebuffer.c
@@ -21,6 +21,7 @@ static const struct drm_framebuffer_funcs psb_fb_funcs = {
  *	psb_framebuffer_init	-	initialize a framebuffer
  *	@dev: our DRM device
  *	@fb: framebuffer to set up
+ *	@info: pixel format information
  *	@mode_cmd: mode description
  *	@obj: backing object
  *
@@ -91,6 +92,7 @@ struct drm_framebuffer *psb_framebuffer_create(struct drm_device *dev,
  *	psb_user_framebuffer_create	-	create framebuffer
  *	@dev: our DRM device
  *	@filp: client file
+ *	@info: pixel format information
  *	@cmd: mode request
  *
  *	Create a new framebuffer backed by a userspace GEM object
-- 
2.43.0

[PATCH 4/7] drm/amdgpu: fix kernel-doc warning for amdgpu_ttm_alloc_mmio_remap_bo()

[Yujie Liu]

Warning: drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c:1923 expecting prototype for amdgpu_ttm_mmio_remap_bo_init(). Prototype was for amdgpu_ttm_alloc_mmio_remap_bo() instead

Fixes: 96e97a562d06 ("drm/amdgpu: Drop MMIO_REMAP domain bit and keep it Internal")
Signed-off-by: Yujie Liu <yujie.liu@intel.com>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
index eeaa56c8d129..9789b778d491 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
@@ -1908,7 +1908,7 @@ static void amdgpu_ttm_pools_fini(struct amdgpu_device *adev)
 }
 
 /**
- * amdgpu_ttm_mmio_remap_bo_init - Allocate the singleton MMIO_REMAP BO
+ * amdgpu_ttm_alloc_mmio_remap_bo - Allocate the singleton MMIO_REMAP BO
  * @adev: amdgpu device
  *
  * Allocates a global BO with backing AMDGPU_PL_MMIO_REMAP when the
-- 
2.43.0

Re: [PATCH 4/7] drm/amdgpu: fix kernel-doc warning for amdgpu_ttm_alloc_mmio_remap_bo()

[Alex Deucher]

Applied.  Thanks!

On Wed, Feb 25, 2026 at 10:09 PM Yujie Liu <yujie.liu@intel.com> wrote:
>
> Warning: drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c:1923 expecting prototype for amdgpu_ttm_mmio_remap_bo_init(). Prototype was for amdgpu_ttm_alloc_mmio_remap_bo() instead
>
> Fixes: 96e97a562d06 ("drm/amdgpu: Drop MMIO_REMAP domain bit and keep it Internal")
> Signed-off-by: Yujie Liu <yujie.liu@intel.com>
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
> index eeaa56c8d129..9789b778d491 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
> @@ -1908,7 +1908,7 @@ static void amdgpu_ttm_pools_fini(struct amdgpu_device *adev)
>  }
>
>  /**
> - * amdgpu_ttm_mmio_remap_bo_init - Allocate the singleton MMIO_REMAP BO
> + * amdgpu_ttm_alloc_mmio_remap_bo - Allocate the singleton MMIO_REMAP BO
>   * @adev: amdgpu device
>   *
>   * Allocates a global BO with backing AMDGPU_PL_MMIO_REMAP when the
> --
> 2.43.0
>

[PATCH 5/7] drm/xe/pf: fix kernel-doc warning for SR-IOV VF restore function

[Yujie Liu]

Warning: drivers/gpu/drm/xe/xe_gt_sriov_pf_control.c:1261 This comment starts with '/**', but isn't a kernel-doc comment. Refer to Documentation/doc-guide/kernel-doc.rst
 * xe_gt_sriov_pf_control_trigger restore_vf() - Start an SR-IOV VF migration data restore sequence.

Fixes: ed46ff0d51e4 ("drm/xe/pf: Add save/restore control state stubs and connect to debugfs")
Signed-off-by: Yujie Liu <yujie.liu@intel.com>
---
 drivers/gpu/drm/xe/xe_gt_sriov_pf_control.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/xe/xe_gt_sriov_pf_control.c b/drivers/gpu/drm/xe/xe_gt_sriov_pf_control.c
index bf48b05797de..5cb705c7ee7a 100644
--- a/drivers/gpu/drm/xe/xe_gt_sriov_pf_control.c
+++ b/drivers/gpu/drm/xe/xe_gt_sriov_pf_control.c
@@ -1259,7 +1259,7 @@ int xe_gt_sriov_pf_control_process_restore_data(struct xe_gt *gt, unsigned int v
 }
 
 /**
- * xe_gt_sriov_pf_control_trigger restore_vf() - Start an SR-IOV VF migration data restore sequence.
+ * xe_gt_sriov_pf_control_trigger_restore_vf() - Start an SR-IOV VF migration data restore sequence.
  * @gt: the &xe_gt
  * @vfid: the VF identifier
  *
-- 
2.43.0

Re: [PATCH 5/7] drm/xe/pf: fix kernel-doc warning for SR-IOV VF restore function

[Michal Wajdeczko]

On 2/26/2026 4:00 AM, Yujie Liu wrote:
> Warning: drivers/gpu/drm/xe/xe_gt_sriov_pf_control.c:1261 This comment starts with '/**', but isn't a kernel-doc comment. Refer to Documentation/doc-guide/kernel-doc.rst
>  * xe_gt_sriov_pf_control_trigger restore_vf() - Start an SR-IOV VF migration data restore sequence.

this is already fixed, see [1]

[1] https://gitlab.freedesktop.org/drm/xe/kernel/-/commit/b47239bc30ef85e70b93e357ce76b205baac3b77


> 
> Fixes: ed46ff0d51e4 ("drm/xe/pf: Add save/restore control state stubs and connect to debugfs")
> Signed-off-by: Yujie Liu <yujie.liu@intel.com>
> ---
>  drivers/gpu/drm/xe/xe_gt_sriov_pf_control.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_gt_sriov_pf_control.c b/drivers/gpu/drm/xe/xe_gt_sriov_pf_control.c
> index bf48b05797de..5cb705c7ee7a 100644
> --- a/drivers/gpu/drm/xe/xe_gt_sriov_pf_control.c
> +++ b/drivers/gpu/drm/xe/xe_gt_sriov_pf_control.c
> @@ -1259,7 +1259,7 @@ int xe_gt_sriov_pf_control_process_restore_data(struct xe_gt *gt, unsigned int v
>  }
>  
>  /**
> - * xe_gt_sriov_pf_control_trigger restore_vf() - Start an SR-IOV VF migration data restore sequence.
> + * xe_gt_sriov_pf_control_trigger_restore_vf() - Start an SR-IOV VF migration data restore sequence.
>   * @gt: the &xe_gt
>   * @vfid: the VF identifier
>   *

[PATCH 6/7] drm/amd/pm: fix kernel-doc warning for smu_msg_v1_send_msg()

[Yujie Liu]

Warning: drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu_cmn.c:415 expecting prototype for smu_msg_proto_v1_send_msg(). Prototype was for smu_msg_v1_send_msg() instead

Fixes: 4f379370a49c ("drm/amd/pm: Add smu message control block")
Signed-off-by: Yujie Liu <yujie.liu@intel.com>
---
 drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c b/drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c
index 6fd50c2fd20e..c471c0e2cbd1 100644
--- a/drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c
+++ b/drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c
@@ -405,7 +405,7 @@ static int __smu_msg_v1_ras_filter(struct smu_msg_ctl *ctl,
 }
 
 /**
- * smu_msg_proto_v1_send_msg - Complete V1 protocol with all filtering
+ * smu_msg_v1_send_msg - Complete V1 protocol with all filtering
  * @ctl: Message control block
  * @args: Message arguments
  *
-- 
2.43.0

Re: [PATCH 6/7] drm/amd/pm: fix kernel-doc warning for smu_msg_v1_send_msg()

[Alex Deucher]

Applied.  Thanks!

On Wed, Feb 25, 2026 at 10:19 PM Yujie Liu <yujie.liu@intel.com> wrote:
>
> Warning: drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu_cmn.c:415 expecting prototype for smu_msg_proto_v1_send_msg(). Prototype was for smu_msg_v1_send_msg() instead
>
> Fixes: 4f379370a49c ("drm/amd/pm: Add smu message control block")
> Signed-off-by: Yujie Liu <yujie.liu@intel.com>
> ---
>  drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c b/drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c
> index 6fd50c2fd20e..c471c0e2cbd1 100644
> --- a/drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c
> +++ b/drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c
> @@ -405,7 +405,7 @@ static int __smu_msg_v1_ras_filter(struct smu_msg_ctl *ctl,
>  }
>
>  /**
> - * smu_msg_proto_v1_send_msg - Complete V1 protocol with all filtering
> + * smu_msg_v1_send_msg - Complete V1 protocol with all filtering
>   * @ctl: Message control block
>   * @args: Message arguments
>   *
> --
> 2.43.0
>

[PATCH 7/7] drm/amd/ras: fix kernel-doc warning for ras_eeprom_append()

[Yujie Liu]

Warning: drivers/gpu/drm/amd/amdgpu/../ras/rascore/ras_eeprom.c:845 function parameter 'ras_core' not described in 'ras_eeprom_append'
Warning: drivers/gpu/drm/amd/amdgpu/../ras/rascore/ras_eeprom.c:845 expecting prototype for ras_core_eeprom_append(). Prototype was for ras_eeprom_append() instead

Fixes: 5c3be5defc92 ("drm/amd/ras: Add eeprom ras functions")
Signed-off-by: Yujie Liu <yujie.liu@intel.com>
---
 drivers/gpu/drm/amd/ras/rascore/ras_eeprom.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/amd/ras/rascore/ras_eeprom.c b/drivers/gpu/drm/amd/ras/rascore/ras_eeprom.c
index cd6b057bdaf3..65c1812a10fb 100644
--- a/drivers/gpu/drm/amd/ras/rascore/ras_eeprom.c
+++ b/drivers/gpu/drm/amd/ras/rascore/ras_eeprom.c
@@ -829,8 +829,8 @@ static int ras_eeprom_update_header(struct ras_eeprom_control *control)
 }
 
 /**
- * ras_core_eeprom_append -- append records to the EEPROM RAS table
- * @control: pointer to control structure
+ * ras_eeprom_append -- append records to the EEPROM RAS table
+ * @ras_core: pointer to ras core context
  * @record: array of records to append
  * @num: number of records in @record array
  *
-- 
2.43.0

Re: [PATCH 7/7] drm/amd/ras: fix kernel-doc warning for ras_eeprom_append()

[Alex Deucher]

Applied.  Thanks!

Alex

On Wed, Feb 25, 2026 at 10:02 PM Yujie Liu <yujie.liu@intel.com> wrote:
>
> Warning: drivers/gpu/drm/amd/amdgpu/../ras/rascore/ras_eeprom.c:845 function parameter 'ras_core' not described in 'ras_eeprom_append'
> Warning: drivers/gpu/drm/amd/amdgpu/../ras/rascore/ras_eeprom.c:845 expecting prototype for ras_core_eeprom_append(). Prototype was for ras_eeprom_append() instead
>
> Fixes: 5c3be5defc92 ("drm/amd/ras: Add eeprom ras functions")
> Signed-off-by: Yujie Liu <yujie.liu@intel.com>
> ---
>  drivers/gpu/drm/amd/ras/rascore/ras_eeprom.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/ras/rascore/ras_eeprom.c b/drivers/gpu/drm/amd/ras/rascore/ras_eeprom.c
> index cd6b057bdaf3..65c1812a10fb 100644
> --- a/drivers/gpu/drm/amd/ras/rascore/ras_eeprom.c
> +++ b/drivers/gpu/drm/amd/ras/rascore/ras_eeprom.c
> @@ -829,8 +829,8 @@ static int ras_eeprom_update_header(struct ras_eeprom_control *control)
>  }
>
>  /**
> - * ras_core_eeprom_append -- append records to the EEPROM RAS table
> - * @control: pointer to control structure
> + * ras_eeprom_append -- append records to the EEPROM RAS table
> + * @ras_core: pointer to ras core context
>   * @record: array of records to append
>   * @num: number of records in @record array
>   *
> --
> 2.43.0
>