* [PATCH] iio: adc: ade9000: remove unused AD9000_CHANNELS_PER_PHASE macro
@ 2026-02-27 8:58 Giorgi Tchankvetadze
2026-02-27 9:07 ` Andy Shevchenko
0 siblings, 1 reply; 3+ messages in thread
From: Giorgi Tchankvetadze @ 2026-02-27 8:58 UTC (permalink / raw)
To: antoniu.miclaus, lars, Michael.Hennerich, jic23
Cc: dlechner, nuno.sa, andy, linux-iio, linux-kernel,
Giorgi Tchankvetadze
Remove the AD9000_CHANNELS_PER_PHASE macro which is unused, has a
misspelled prefix (AD9000 instead of ADE9000), and has an incorrect
value (10 instead of 11, there are 33 total channels and 3 phases, so 11
for each).
Signed-off-by: Giorgi Tchankvetadze <giorgitchankvetadze1997@gmail.com>
---
drivers/iio/adc/ade9000.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/iio/adc/ade9000.c b/drivers/iio/adc/ade9000.c
index 5dcc26a08970..4be8df34428d 100644
--- a/drivers/iio/adc/ade9000.c
+++ b/drivers/iio/adc/ade9000.c
@@ -283,7 +283,6 @@ enum ade9000_wfb_cfg {
#define ADE9000_PHASE_C_POS_BIT BIT(6)
#define ADE9000_MAX_PHASE_NR 3
-#define AD9000_CHANNELS_PER_PHASE 10
/*
* Calculate register address for multi-phase device.
--
2.52.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] iio: adc: ade9000: remove unused AD9000_CHANNELS_PER_PHASE macro
2026-02-27 8:58 [PATCH] iio: adc: ade9000: remove unused AD9000_CHANNELS_PER_PHASE macro Giorgi Tchankvetadze
@ 2026-02-27 9:07 ` Andy Shevchenko
2026-02-28 12:10 ` Jonathan Cameron
0 siblings, 1 reply; 3+ messages in thread
From: Andy Shevchenko @ 2026-02-27 9:07 UTC (permalink / raw)
To: Giorgi Tchankvetadze
Cc: antoniu.miclaus, lars, Michael.Hennerich, jic23, dlechner,
nuno.sa, andy, linux-iio, linux-kernel
On Fri, Feb 27, 2026 at 12:58:13PM +0400, Giorgi Tchankvetadze wrote:
> Remove the AD9000_CHANNELS_PER_PHASE macro which is unused, has a
> misspelled prefix (AD9000 instead of ADE9000), and has an incorrect
> value (10 instead of 11, there are 33 total channels and 3 phases, so 11
> for each).
for --> per
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] iio: adc: ade9000: remove unused AD9000_CHANNELS_PER_PHASE macro
2026-02-27 9:07 ` Andy Shevchenko
@ 2026-02-28 12:10 ` Jonathan Cameron
0 siblings, 0 replies; 3+ messages in thread
From: Jonathan Cameron @ 2026-02-28 12:10 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Giorgi Tchankvetadze, antoniu.miclaus, lars, Michael.Hennerich,
dlechner, nuno.sa, andy, linux-iio, linux-kernel
On Fri, 27 Feb 2026 11:07:42 +0200
Andy Shevchenko <andriy.shevchenko@intel.com> wrote:
> On Fri, Feb 27, 2026 at 12:58:13PM +0400, Giorgi Tchankvetadze wrote:
> > Remove the AD9000_CHANNELS_PER_PHASE macro which is unused, has a
> > misspelled prefix (AD9000 instead of ADE9000), and has an incorrect
> > value (10 instead of 11, there are 33 total channels and 3 phases, so 11
> > for each).
>
> for --> per
Hmm. per each is weird. per phase makes more sense so I'll change it to that.
Applied with that commit message tweak.
Thanks
Jonathan
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-02-28 12:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-02-27 8:58 [PATCH] iio: adc: ade9000: remove unused AD9000_CHANNELS_PER_PHASE macro Giorgi Tchankvetadze
2026-02-27 9:07 ` Andy Shevchenko
2026-02-28 12:10 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox