From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A9B4F413253 for ; Fri, 27 Feb 2026 15:16:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772205418; cv=none; b=b/gK/HRA9TTppMfw+8TXcTp0wJQH5LLfq1pFwJvn2ZuQDaYX9X1xfM/s6W/WWKJM2sUQavuAGLaFH23HpMFkhHqrMdBIqJeF2+3sB6DZPLe7zSpJ7TnMu6vSSQ5wI+H//acYAiM4JAJyqTX7Sm3bnCdwrBRDQqgRhH80qS0PodY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772205418; c=relaxed/simple; bh=3RD4LUZ80aze8TAeEIchYKqFPnCkLoGuWO2eUU4OyFk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=AeTpEZWWBjQiVq+TSigHug6a9OChv4jMkW671pEDPoIoCjX/N4I0y/z1rfVg9zHz1Q9n1cmke1m5bdcipaHMbi0xg5VdVhdDbSooMpjBjvHrpmIWRUqcPxEgWuUsiumzLIV7opgs/xWsoVFeViecYm2KeM+4Ts54fx3tQWrIwKE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=Bau98NVl; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="Bau98NVl" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-4837f27cf2dso18801775e9.2 for ; Fri, 27 Feb 2026 07:16:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1772205415; x=1772810215; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=2HZLCVSoL8uPOb5uIS0KrR8+8oqmL6ZBVdtWORIX0g0=; b=Bau98NVlLJYE5qOo8CpYhHhGvR4sfAo8+iDXuFQGam+5h4PAIOvI8ZHtZA5yHHdPGB JYRN+JMXkFIRfno2KyC/KstsFKsrMRfSZme65f9SqR7nbVk0SXubioMNdFp7r+odYXb4 FVpToTG8CV08sIEl7zBdMKjId6o0QDHMjFYOdcrV5hAYF/Ksfyz5/Jniw4u1gEJCpL6k 0lmZg+pmWFAL6y2/ew6oW/jwk0uQNkZxN6oKvBXBYnctOe5pzd1eHWXyCW9C4Kezzd5z wuWXn9/we1Rf9b1LDg7wVAWUxiMQJERGrzkMcHkTo8+KRNuzdl7v/1smzaqHcMpf0hbX 7IBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772205415; x=1772810215; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2HZLCVSoL8uPOb5uIS0KrR8+8oqmL6ZBVdtWORIX0g0=; b=mo1ayQRCeyrIn1n+tXrJ4o3hN4ZPj6RhKylBQozXmYfsUcUVKZ4866qzrwTNx2PqbZ Qscho/BVw0PVW6uNBGRkdTD+S4z48kjFuBnqLD2HA4X9lI+5TFNp3r9OkYHPxB6X9JFJ YVKZZj6OYgMgUHaFLXxS53ZXn/SALAP8p3ZYKRsAxfiwf/B72r96ctPE7SMfYng4Z76M wEtSVeJJxWzTR+dWXhQbVknELxFgzrd4nSRwr1ub38xApjQICAI19SjmVtZJvk37aRLM gocV1aHDHWyO1hkh9Kb05wYoWlYN/f5AHxBlq0EU2yth6MJHkVGBq/tTylY3qqxl5X1Q xQ6A== X-Forwarded-Encrypted: i=1; AJvYcCV6XML+t90bhD1pP8EjC8xbw8La1MSaF7L0V6lcjStzOPFKzYgYengwnWBxGjwUlQFGBjc6hq15PbOI8ak=@vger.kernel.org X-Gm-Message-State: AOJu0YwDvbYqJiNA2zvr6hu6hXDdXBydQ15W/FlSFX4Gq4FiOPJo/S7K y7GTLs6pDCrjaPEGcruXz+8XOOISfCmFuWnywDjFKDE8SIukzTNNXcAxG16YdtfX2g== X-Gm-Gg: ATEYQzzra7c6xLzXudDm9rERfCdlNx09/U3+OQ84bIGk5Ny70rc0DMi92DiJZBQIddE Q+LLqEFzunCrq2fHn71gzFKYnFDUuNPc31i+C8tC94Om6h2fDYMEZsxamrMyxSCnqxwxa+IzsJA ZPfa+vt6vMWgDVf+lumUqerpFcXWyIoJBTB2XjL93qtEuiEZ3XVYr4Ze3fH8OTDvHqzil3aEvx7 FMwU40Hegz7dizE+w8uVdSf0Rjgpo9ii6pKVCNAQoNvWvCEPLcOAx2mCL7UvAZqNsmNV5hCa2On FzoWth1SKsVW82xFK4QALzISFTEJrIfu6AQuxbbGeiO8qi3ir8CuiKVNnunwVx4LaP2+1I5KPvD UNCVqc9qOYDoLk97YriGFt33ar1RnJLVV9FjuCpg3mQn5V5oGncxMOadHw6BUAK+B4eK7sRmrf2 LMRF6ow+19SSbdsWPkOfWSL7NnCmplhArtLz4BGvrwaivCit5OqSvTg/99Jzqw1s3U76M= X-Received: by 2002:a05:600c:b90:b0:483:abeb:7a5c with SMTP id 5b1f17b1804b1-483c9bdb600mr53847895e9.12.1772205414739; Fri, 27 Feb 2026 07:16:54 -0800 (PST) Received: from google.com (135.91.155.104.bc.googleusercontent.com. [104.155.91.135]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-483bfba9a5esm144533085e9.4.2026.02.27.07.16.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Feb 2026 07:16:54 -0800 (PST) Date: Fri, 27 Feb 2026 15:16:50 +0000 From: Vincent Donnefort To: Steven Rostedt Cc: Qing Wang , Masami Hiramatsu , Mathieu Desnoyers , linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, syzbot+3b5dd2030fe08afdf65d@syzkaller.appspotmail.com Subject: Re: [PATCH] tracing: Fix WARN_ON in tracing_buffers_mmap_close Message-ID: References: <20260227025842.1085206-1-wangqing7171@gmail.com> <20260227101002.614add75@gandalf.local.home> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260227101002.614add75@gandalf.local.home> On Fri, Feb 27, 2026 at 10:10:02AM -0500, Steven Rostedt wrote: > On Fri, 27 Feb 2026 10:41:17 +0000 > Vincent Donnefort wrote: > > > > Hum, not sure this is entirely correct. We do set VM_DONTCOPY when creating the > > > mapping (see __rb_map_vma). So AFAICT ->open() is not called in this situation (see > > > dup_mmap()) > > > > Ah right, Syzkaller is using madvise(MADVISE_DOFORK) which resets VM_DONTCOPY. > > Hmm, > > So this means user space can override the DONTCOPY? Can this cause bugs > elsewhere that DONTCOPY is used? Indeed, user space can clear DONTCOPY... unless we also set VM_IO. > > -- Steve