From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Giorgi Tchankvetadze <giorgitchankvetadze1997@gmail.com>
Cc: antoniu.miclaus@analog.com, lars@metafoo.de,
Michael.Hennerich@analog.com, jic23@kernel.org,
dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: adc: ade9000: fix wrong macro names in ADE9000_ST_ERROR
Date: Fri, 27 Feb 2026 16:44:47 +0200 [thread overview]
Message-ID: <aaGt38ePGhonQRmd@ashevche-desk.local> (raw)
In-Reply-To: <CAE7dp2qN4mxJfSYXxFQY9sdLR3eQemwDOEur3QxcMU2TNBZTig@mail.gmail.com>
On Fri, Feb 27, 2026 at 02:52:45PM +0400, Giorgi Tchankvetadze wrote:
> On Fri, Feb 27, 2026 at 2:33 PM Andy Shevchenko
> <andriy.shevchenko@intel.com> wrote:
>
> > What about the current code that uses it? Is it even in use currently?
> >Please, elaborate more in the commit message that we clearly understand
> >that you spent time and investigated code and/or datasheet before crafting
> >this change.
>
> Hi Andy. Thanks for the feedback !
> The macro is currently unused in the driver, so this does not cause
> a build failure.
Drop it then?
> Reference: ADE9000 datasheet (Rev. B, Page 61), STATUS1 register (0x403),
> bits 28-31 define ERROR0 through ERROR3 status flags.
Yes, good, this should be in the commit message.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-02-27 14:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-27 10:09 [PATCH] iio: adc: ade9000: fix wrong macro names in ADE9000_ST_ERROR Giorgi Tchankvetadze
2026-02-27 10:33 ` Andy Shevchenko
2026-02-27 10:52 ` Giorgi Tchankvetadze
2026-02-27 14:44 ` Andy Shevchenko [this message]
2026-02-28 12:08 ` Jonathan Cameron
2026-03-02 5:57 ` Giorgi Tchankvetadze
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aaGt38ePGhonQRmd@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=Michael.Hennerich@analog.com \
--cc=andy@kernel.org \
--cc=antoniu.miclaus@analog.com \
--cc=dlechner@baylibre.com \
--cc=giorgitchankvetadze1997@gmail.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox