From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3A1B142668D for ; Fri, 27 Feb 2026 14:46:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772203605; cv=none; b=P5NqFki7Kd3cJ8IOUdGEl2CJ4NYKs3jMrptvOytmHjOFWZYnRTOY7Sv05tVNMAU2CxPNJrCIsd36f3Qp5w8GfNEuUz9Vs5OdGa/I9iSvt9yd84gJ19b5o/0QRGM59nyMaxpd9X5ChncBtzr5aHSG94rWoa7J1pbsWAXez2Ztimo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772203605; c=relaxed/simple; bh=S0elBaqzdSTOcHC3fi2owYM/NUXzMqJZoXqPjanC/0c=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=OQnrlMjeoXFqDlCAzw3iDTAvpCaLTT9cqdQv4GwqnKsSACFQRJ5jCF3/M2THuSjybvY8PfR+H0CiWWrCSJFSe88fSTn/YwcIDeSyQ9s1KSTywyY5txCmVxQLpz+g1GJFAHf0Kja02E9Hhcnymao/uByOtXADBFgpk9NIETkTa/4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=VP0bcD2y; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=DFaH2Chq; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="VP0bcD2y"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="DFaH2Chq" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1772203602; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=INxHBhm1Qtgs5FsmxXRA+ozCcO035JVGQgBykqYXu7U=; b=VP0bcD2yZIJplL7lKSL3oHugv5PNjtS1jRkbbx9Jmab+r+EZXJCNlTbbkc0GKHuVYxiNlx kpQS/EezNPiYwK5jD6X+hxdBwVOUwnKEZNeMmBver5EGkPil6FZvI9Oyphczg0GB8wIVyz J/zD9X0GbpFhhNu0sZ/6/KJCSYFbAfs= Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-627-6dB8gjWwMvmCqJL1jz5faA-1; Fri, 27 Feb 2026 09:46:41 -0500 X-MC-Unique: 6dB8gjWwMvmCqJL1jz5faA-1 X-Mimecast-MFC-AGG-ID: 6dB8gjWwMvmCqJL1jz5faA_1772203600 Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-899c3239a28so427549246d6.0 for ; Fri, 27 Feb 2026 06:46:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1772203600; x=1772808400; darn=vger.kernel.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=INxHBhm1Qtgs5FsmxXRA+ozCcO035JVGQgBykqYXu7U=; b=DFaH2ChqygdE24mVwao6r892DL41wmXkAGqq1ceRB7NRPs7qTVcrDDGPBm0Ys2G66c n+A4TJCrrPdDU+Sq2Zn8+gz64BmvIzCdVChshOgqhwYV/i4mwSikHQ7Pc60nyWzT43gu BN2+gZABycg47kPEh8z6mlybA+AA1/klX/nW6m2DnAKdivLEeMI9z8D+BXmkRzN0gCHv IUhv89hgJPGxbtXFhx5lmxakfLE8Mfu4LNN7o7lB55h18eASf74BInvYTzqAjkmvt9NF hB3mkLwVmbIuXphxk2/KG3NwogRVkO8t3iTs5Hjj2ggjVw2v/XYIvFYriGH9Ppb4hEqD pxpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772203600; x=1772808400; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=INxHBhm1Qtgs5FsmxXRA+ozCcO035JVGQgBykqYXu7U=; b=bKP9Lp7RpxNhGJltwcV1H9IQgWdmKzqRRTYNhnq6gc1DRLXEq814Cd3+sw6rkbNfEF Hcp01xXUHFZ4r06TljPRa318g1LwRbAKs8YW8n+oRz0FeL+jkyNBncFKB4I5JXFfL638 amBCYWYFfOESZbdErp8gqXUmV33Ck68wzsjJfl1dC0P9c5SETO2lxIC/V29dF29DlikH jJEK/9GZmcKNy9PKUHXijpYw35tUkRKu73OwwySiLe76AWYFOf6fgDOm32bD9NPQSWOH 5yoib0VN0Jo0oMuU4cvDbo09p2rq3bNWheS9urjwysZjHpB7N8L1zztg5e7WoOs/7BE1 IMMg== X-Forwarded-Encrypted: i=1; AJvYcCX6QG1CXrPqhlxpmP1UcsE7TrVclVRX0xZIZF/q1QuclqB6CkjzcgLjTn0UTAOP7IYBXZ6l+8/g4pXTYiw=@vger.kernel.org X-Gm-Message-State: AOJu0Yywk5bQT8d4/RD6p8pnWRSjtSHqHxlP2iSSFfnN4e21QJInHY/Z qg4NtEjjRIu5JA7ZXE4H0F11LrHFAG89GyciMFT7/H4CFg+FZcFnqlsfoUzR0T/cRUR5wxRTjkp kL3LWn2WanytDRBg670ZfT/IZKRm8nIez+5hKeloPby0FrSwf3kx3DK/6Ym/odWRovg== X-Gm-Gg: ATEYQzwLoQotmQrxWTweUytfwL6tL9GvYBtpNtXFC5FAnYMxNgAg7quaJofWTMOX+Iu 2e9BqEq1TphkekjiyO0KgdI1qhi4wGnFgNzPPVAmwZjbUniHoLoObzCKa01BauT9q08BCZCvcjN KW/TtuwRvnRvCi3E0wP35O2Ey6kNLasjCSq6NUsvalj3GclMGz5WGaXNQxAFVtYVfoKoD3ClNmF xnM3DlgYZ3LC1iGhQR0lUqM6+lwX3lGu7iyLPvYg8M+b+pAKBfPa0h0XTmr6PtdNZEjtdnrzbcC zH9LEVpGest1VjKVjTu5alQGn0b3D2sbFSvYHSaGzKgF4o2pgZon7IaiQ45voweR0Wgt0x0WDRg RvDzkFny/ekNd32R47ScqrzW0bTSrCbws964lNcmzRUhdsNMHqNXIW8iG X-Received: by 2002:a05:620a:d82:b0:8b2:d256:d064 with SMTP id af79cd13be357-8cbc8df094emr374422285a.41.1772203600510; Fri, 27 Feb 2026 06:46:40 -0800 (PST) X-Received: by 2002:a05:620a:d82:b0:8b2:d256:d064 with SMTP id af79cd13be357-8cbc8df094emr374418785a.41.1772203600084; Fri, 27 Feb 2026 06:46:40 -0800 (PST) Received: from redhat.com (c-73-183-52-120.hsd1.pa.comcast.net. [73.183.52.120]) by smtp.gmail.com with ESMTPSA id af79cd13be357-8cbbf73451csm490604385a.47.2026.02.27.06.46.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Feb 2026 06:46:39 -0800 (PST) Date: Fri, 27 Feb 2026 09:46:38 -0500 From: Brian Masney To: Geert Uytterhoeven Cc: Michael Turquette , Stephen Boyd , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Biju Das Subject: Re: [PATCH 11/13] clk: renesas: rzg2l-cpg: drop determine_rate op and use CLK_ROUNDING_FW_MANAGED flag Message-ID: References: <20260226-clk-det-rate-fw-managed-v1-0-4421dd2f6dc6@redhat.com> <20260226-clk-det-rate-fw-managed-v1-11-4421dd2f6dc6@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/2.2.14 (2025-02-20) On Fri, Feb 27, 2026 at 09:20:09AM +0100, Geert Uytterhoeven wrote: > On Thu, 26 Feb 2026 at 19:18, Brian Masney wrote: > > This clk driver has a noop determine_rate clk op. Drop this empty > > function, and enable the CLK_ROUNDING_FW_MANAGED flag. > > > > Signed-off-by: Brian Masney > > Thanks for your patch! > > > --- a/drivers/clk/renesas/rzg2l-cpg.c > > +++ b/drivers/clk/renesas/rzg2l-cpg.c > > @@ -938,12 +938,6 @@ static unsigned long rzg2l_cpg_sipll5_recalc_rate(struct clk_hw *hw, > > return pll5_rate; > > } > > > > -static int rzg2l_cpg_sipll5_determine_rate(struct clk_hw *hw, > > - struct clk_rate_request *req) > > -{ > > - return 0; > > -} > > - > > static int rzg2l_cpg_sipll5_set_rate(struct clk_hw *hw, > > unsigned long rate, > > unsigned long parent_rate) > > @@ -1015,7 +1009,6 @@ static int rzg2l_cpg_sipll5_set_rate(struct clk_hw *hw, > > > > static const struct clk_ops rzg2l_cpg_sipll5_ops = { > > .recalc_rate = rzg2l_cpg_sipll5_recalc_rate, > > - .determine_rate = rzg2l_cpg_sipll5_determine_rate, > > .set_rate = rzg2l_cpg_sipll5_set_rate, > > }; > > > > @@ -1041,7 +1034,7 @@ rzg2l_cpg_sipll5_register(const struct cpg_core_clk *core, > > init.name = core->name; > > parent_name = __clk_get_name(parent); > > init.ops = &rzg2l_cpg_sipll5_ops; > > - init.flags = 0; > > + init.flags = CLK_ROUNDING_FW_MANAGED; > > Iff this is the Right Thing To Do (TM), it needs a comment, as this > clock is not managed by firmware. It needs a better name for the flag. I'll reply on patch 1 where more people are CCed to see if we can come up with a better idea. Brian