From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5ACE81EEA31 for ; Fri, 27 Feb 2026 15:01:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772204470; cv=none; b=I7FdPHUdfWIWmvhE5vUhd/ANZo86k65VXFhbCUgcxqeCt8ZqqGbRAv6YO/3t6eo6433RUpHQlEXYJyXKS3bUvGByVUFZi0Duy434mEifmucOeQ5mK9zJOyAmoLMOAxk1yYWIReVCfG8USoOrPH5L8SbvPGCge7kcik4P1cHMmP0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772204470; c=relaxed/simple; bh=Tdad2tDIZ4nlg5lofGib/mnCiNPcPkT7O6vIqYQRG4s=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=DuIRxawNzsbsJhnu3WVIog1doFL5zFOeCMYIXhyKbFrywSFsyjsdapoUSPtlDbdlWNgJrUb71U/ccA2esSF6DFN8ovC5pT9ECfrDYoWpX61nO0nyg38k3PxjH4i4bRrUZCSmIOGxmFI7QVjm53mhT/G94IufP8eJiDv1Txr81Xo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=ehrioAt3; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=RVRnmYFO; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="ehrioAt3"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="RVRnmYFO" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1772204468; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=bLr3NmqNXmYh6BXBWQg2YMvnGrmssYaz8RuukrCvN6E=; b=ehrioAt3+p4EeiCoJ4zPS+TgLYwuusvgX0I32A8jv4ku15efGPltsZ/5vretwC7GhjPgFs 3bu1XiZijycryyi7Wu3KSfzX+YvwZJlhsC6T16HoXzTsQkMVHgh94GREQmYx8pCSeWbyi3 vEeWIVrrWOge39IDtL8BlX0vZYJKlsA= Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-516-NTIRCzgkNRq3nfUYEMTdtw-1; Fri, 27 Feb 2026 10:01:06 -0500 X-MC-Unique: NTIRCzgkNRq3nfUYEMTdtw-1 X-Mimecast-MFC-AGG-ID: NTIRCzgkNRq3nfUYEMTdtw_1772204466 Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-896fae4073fso31897106d6.2 for ; Fri, 27 Feb 2026 07:01:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1772204466; x=1772809266; darn=vger.kernel.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=bLr3NmqNXmYh6BXBWQg2YMvnGrmssYaz8RuukrCvN6E=; b=RVRnmYFOdq8FZ7+1BF52dY639avt63nk4eXgeDtPnyBa2bgoyOUfMfHGpOPP6jdw3+ 7E7zyBPmq3SWJ5Br+R8PIHT1+XHVdnSicDnThmoOpb4AV7W5jzg6nUauDCzVcVMHlczU a55KslQOs5/D49ggfi99rszvtyZ7NrbdC1yysJv/Sgm4vNW1X5t2W+vsnNM9tmXJyaFo 73cJCurrtu4jZ9C1khbKF6hDDQeFck8heV9Y1pD3eCfkk3UNz1Mp3T6ImhzZLBcpYq0Z Z7xZNlluYTvgUroSucE/nd4aj7tB1PKED2SqZPoUqP/nCNO7v9P5Nc2xp0shyAqBumc9 AmVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772204466; x=1772809266; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=bLr3NmqNXmYh6BXBWQg2YMvnGrmssYaz8RuukrCvN6E=; b=eRnNix3R+0hnRGMctxKz0lfCT2tWykNOMy7h5fq/jnlNBzxVybw6y/j2wVAwYB2U3S 3fCl9Gnwwj1B39zltm78b1OqBvmyP3Dz/+6GuBhDYrnPvsvoihlJd5HbyrT1b8u7Z+ZT cwY2K1z/23bjIjBvBsq7tEPWKwZZsQUo08P7aLN/vCnmTloYrXNC/JmZHSn91A+yblsi TWxJ/Zy1uto9YnloEXFhYlQNrYE8SRH1FUjtD9m/GyJXh9yuHUMxP7k9SD0CzpQuNy7z mohotnxr/8EPLNZ5fNQL7BFpPFg3/58/Ra0+XbYqZOBLjPeBuN/gg93mOr/odjLCh8dO AEBg== X-Forwarded-Encrypted: i=1; AJvYcCUn9nVTuOFRcYcHs6lKvqpeyShMKHz2XMCI/ub/+1WDLycBxi1DJDcQ1mftjW01fHQhtbxVPLHfMVykd2g=@vger.kernel.org X-Gm-Message-State: AOJu0Yy030uSBjcytLyBlUtb0oZ6RhWoQP/fdEqlrkEMHsCfBmL6b7H0 HwlDMU9CaYA5OzJghvM8uYLPgr4HNgis5/Itk8itILsn+gTycnLhsPvvxpJaHGVfOkhnb1q66Sv DiZbGktE1kR6QB3PT8xsA+yMFs9wCuIvJbyPPPT6lpVFcLkQJkOT5TTItRHljhVTBhsgMRVXVvg == X-Gm-Gg: ATEYQzyJDRESpuswf75S3LQ9QG3xkFY340ROqvpZSKMiw2no7eOL0Rdic1dleFKBboZ 1IVSXVofG/Yyu0Pu91IhEJMGmNcSRSX5h+MxUTKhTqc9IoBe5cNBvppgQdCVy6bpwQtQv1TnYt/ GPkYNjSwhedoETbsYSY5irnzxMfx/uoPLpHKeUKcx9aCK+ALxCyYnaicohuf8bO1bxFmA1TEvTB kjRKynjWr3PUuuxcD3J55TFRD/2dKjFyEvtwlXL4iY4ruRZ3k1QJSXNWGqgRF0O6Cwq/X/dwWZN QY82MBMnKXz1JrMNAliTVU3NXYagwOuX2M7KpH01bHssG8rSYOSKZRHoGYy9L4Ke38wdJuij7v+ 7FuMLZyGz1/0TLBqngMjhGUbHGXKvnO/XUjXyWuJJmp7FzPhHNEE/KRgP X-Received: by 2002:a05:6214:48d:b0:899:bc85:7b68 with SMTP id 6a1803df08f44-899d1dbd513mr43676576d6.16.1772204464872; Fri, 27 Feb 2026 07:01:04 -0800 (PST) X-Received: by 2002:a05:6214:48d:b0:899:bc85:7b68 with SMTP id 6a1803df08f44-899d1dbd513mr43675746d6.16.1772204464174; Fri, 27 Feb 2026 07:01:04 -0800 (PST) Received: from redhat.com (c-73-183-52-120.hsd1.pa.comcast.net. [73.183.52.120]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-899c7374600sm46063276d6.29.2026.02.27.07.01.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Feb 2026 07:01:03 -0800 (PST) Date: Fri, 27 Feb 2026 10:01:02 -0500 From: Brian Masney To: Geert Uytterhoeven Cc: Michael Turquette , Stephen Boyd , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Biju Das Subject: Re: [PATCH 11/13] clk: renesas: rzg2l-cpg: drop determine_rate op and use CLK_ROUNDING_FW_MANAGED flag Message-ID: References: <20260226-clk-det-rate-fw-managed-v1-0-4421dd2f6dc6@redhat.com> <20260226-clk-det-rate-fw-managed-v1-11-4421dd2f6dc6@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/2.2.14 (2025-02-20) Hi Geert, On Fri, Feb 27, 2026 at 09:20:09AM +0100, Geert Uytterhoeven wrote: > On Thu, 26 Feb 2026 at 19:18, Brian Masney wrote: > > This clk driver has a noop determine_rate clk op. Drop this empty > > function, and enable the CLK_ROUNDING_FW_MANAGED flag. > > > > Signed-off-by: Brian Masney > > Thanks for your patch! > > > --- a/drivers/clk/renesas/rzg2l-cpg.c > > +++ b/drivers/clk/renesas/rzg2l-cpg.c > > @@ -938,12 +938,6 @@ static unsigned long rzg2l_cpg_sipll5_recalc_rate(struct clk_hw *hw, > > return pll5_rate; > > } > > > > -static int rzg2l_cpg_sipll5_determine_rate(struct clk_hw *hw, > > - struct clk_rate_request *req) > > -{ > > - return 0; > > -} > > - > > static int rzg2l_cpg_sipll5_set_rate(struct clk_hw *hw, > > unsigned long rate, > > unsigned long parent_rate) > > @@ -1015,7 +1009,6 @@ static int rzg2l_cpg_sipll5_set_rate(struct clk_hw *hw, > > > > static const struct clk_ops rzg2l_cpg_sipll5_ops = { > > .recalc_rate = rzg2l_cpg_sipll5_recalc_rate, > > - .determine_rate = rzg2l_cpg_sipll5_determine_rate, > > .set_rate = rzg2l_cpg_sipll5_set_rate, > > }; > > > > @@ -1041,7 +1034,7 @@ rzg2l_cpg_sipll5_register(const struct cpg_core_clk *core, > > init.name = core->name; > > parent_name = __clk_get_name(parent); > > init.ops = &rzg2l_cpg_sipll5_ops; > > - init.flags = 0; > > + init.flags = CLK_ROUNDING_FW_MANAGED; > > Iff this is the Right Thing To Do (TM), it needs a comment, as this > clock is not managed by firmware. Before I start a larger discussion on patch 1 with more people about a name for this flag, help me understand why this provider has a noop determine rate. Is the hardware eventually programmed with a rate that's close enough to what was passed in? Or it doesn't really matter what the clock rate is, just as long as it is running? Or should the determine_rate function be filled out in this particular case? Thanks, Brian