From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f43.google.com (mail-dl1-f43.google.com [74.125.82.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2EFD423ABAA for ; Sat, 28 Feb 2026 00:44:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772239451; cv=none; b=CtDYd0rkNLrV+E+lyuY40+m5bcHyRyLkDGj5sZeiPdv2zDTXdjdDO8k7KrkFyZwrxaHetmEqsJuixO/ZbHiRkk6ljQwFKm/tEzQ4h/WcI/H6eodc4XMiiIMzzSlECltaxe1n3G2JuExqeFas8JFyZfALldApl3ALvZa/0r9PojU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772239451; c=relaxed/simple; bh=Hk9PxgGB2IPDLZCgxwfCz5fhs/7C1kw4u5sIRwBrLUM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=LPMksGcZA5Zh4W3jD9jkau6THz6Rthkvzwv6yvM6NOUGY9LhUC/KZAnpdwlAFiB5x/rWMGndMXE5iNUCVQf8XxDEo1Zz0cYaFL3t8Gukk+VqFo70NHGB5ARuuzpiRF++zDR57w3WwLdXWYCQoZdSATuh+xw/VuYa4mcp4WkC2HE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=csRzKe6n; arc=none smtp.client-ip=74.125.82.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="csRzKe6n" Received: by mail-dl1-f43.google.com with SMTP id a92af1059eb24-1271195d2a7so2103123c88.0 for ; Fri, 27 Feb 2026 16:44:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772239449; x=1772844249; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=EBwblb3CHX9Jab/Y2KovLLCIWamrFhoMAgXNfbYKr/0=; b=csRzKe6nnlSSA8bnf+tew8d3cwv8/zS0T6zpzTpF8ApeJAauFz+Y7JIOjkXpsb2EW0 RglXUAayH0gFbGmVr3fVy+0vm39FI340lN+t2yyxLAruKHb7+21EI4oBQ/68fwE3H84q Ftknt3lrouDj5aYzpVTXX0wMIfOp0nMqI9woSEdgCo8DSK1TBsVmtKXGkn2ZRibPozeY Fw3GR4YrvCVnqPzKBuwNfgPds+BbwQI1JzQ02w1vcxeMPEfuiiVmsgYT6fE9ak305xla hmiPgBoX+stcPXMSKYkto6cRW0wKlmXwL+eiF3GBBW+v1YPEs1e8VHBL63YeeTKqIj7U i5qw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772239449; x=1772844249; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=EBwblb3CHX9Jab/Y2KovLLCIWamrFhoMAgXNfbYKr/0=; b=NEbf2S2GULHqkNL7W6JpjwrPgomdvdyjKysvd3wDzv+4N+Esu4lSEp9NVEE9rlW55p 7iO6ci6FbnEBi8epSLOxz9gvER0eb7HjArj9l5fdby5RYAQq7Z0qxiYF6yYZ5kAJ4TML YgkhY5vl2deNsRXxgxpWuUK4PgII06dGzkfibrGlWzHokPzdH/x3i7QqfOkthVix01aM N0r66Bm4PEycxU+Ybeyje+9j1uyjpsq9rzPWzMJAUrQiYL0X9cuNrpBb34tU0CFEsShM kg0KC29Jc3/I88rm7uJNfC8XpIDKmpJCW7qB/TakO4oeIHLLJ5QdtM7II8vxUJkxfbvH 4l/w== X-Gm-Message-State: AOJu0Yz/+bV6m0Dg+MERh3JjKorGV3OmVtskPVRW3XEPN4ZtoTyOE+wZ /z6vvYZ8ZDiMaYWj6NAzTSzEMDFc8KL4CMjdnLQ9k4uyRwiBUqg30wJU X-Gm-Gg: ATEYQzyzFppPPZZLmWX5U/B9v67Kdyce98J7v3IL9HdVWbQxhzDBTGG5XYq16uIuk4L 4EHBGzVGRNsyC/O0su8q9mu/wvsKf7bh6FmlacMnp4QlV2KMwI8kq5KPiQjQY3xsCUKC1VTsSEo MNZ5ERxrZDix2oMP/fjFCPmLlciR3t8jWYBD/mAYue9hPeR9KYbWgnaD2QAiO6r4rFpkMB3+oKW YmEtTVMl+L1ny5nmtVus08LjXOUMbaXwG+5U0zKSS9KmMN/ofaTMzEocQ9hj3JRd4qM5P1ksn8Y 0Ek6UJq+fOPEESGZl89uz3d3G1CjKVCLW/JurGyd8JPyTxHzNho5mpoSExW+g+ZvDYZL/GPaU8u 3XlzkFyl4Ch0KD0i9Qhdl5ZUWgCHP5p4IRUdYmrWeXBf84v9XOFNb9N6/jlABnKaFpUGm7/XIAF Cv8DEnWdmgHwQIdpvhkNkwm6FfpSWk1qMX0gXJuIxSKkORqVRaf9ix/Tblp8EbydgSybRYGbMiV +fKTT6AdXbRnIM= X-Received: by 2002:a05:7022:2485:b0:127:5cfd:785 with SMTP id a92af1059eb24-1278fc28856mr2211264c88.4.1772239449165; Fri, 27 Feb 2026 16:44:09 -0800 (PST) Received: from fedora (c-67-164-59-41.hsd1.ca.comcast.net. [67.164.59.41]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-12789a43885sm7533362c88.12.2026.02.27.16.44.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Feb 2026 16:44:08 -0800 (PST) Date: Fri, 27 Feb 2026 16:44:06 -0800 From: "Vishal Moola (Oracle)" To: Dave Hansen Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, "Mike Rapoport (Microsoft)" , Dave Hansen , "Matthew Wilcox (Oracle)" , akpm@linux-foundation.org, Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" Subject: Re: [PATCH v6 0/4] Convert x86/mm/pat to generic page table apis Message-ID: References: <20260219020354.321088-1-vishal.moola@gmail.com> <2fe139df-1764-40e5-983d-48d7f97c2e39@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <2fe139df-1764-40e5-983d-48d7f97c2e39@intel.com> On Fri, Feb 27, 2026 at 02:24:33PM -0800, Dave Hansen wrote: > On 2/27/26 12:07, Vishal Moola (Oracle) wrote: > > Do you have any more comments for this series? If not, could you please > > take this through the x86 tree. Thanks 🙂 > > From a 2-second glance, this doesn't have normal comment style and isn't > using imperative voice. Quite a few "we's". Looks like it needs some > more eyeballs. Ok, my mistake on the comment style. I'll fix that. Sorry I'm not the greatest at imperative voice, I'll pass all my comments through AI to convert them all to imperative voice. In regards to more eyeballs, I've realized I didn't cc ALL x86 maintainers. +CC the rest of the x86 maintainers and we'll hope someone else looks at it as well.