From: Geraldo Nascimento <geraldogabriel@gmail.com>
To: Charalampos Mitrodimas <charmitro@posteo.net>
Cc: "Shawn Lin" <shawn.lin@rock-chips.com>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kwilczynski@kernel.org>,
"Manivannan Sadhasivam" <mani@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Heiko Stuebner" <heiko@sntech.de>,
"Dragan Simic" <dsimic@manjaro.org>,
linux-rockchip@lists.infradead.org, linux-pci@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 4/4] PCI: rockchip-ep: do not attempt 5.0 GT/s retraining
Date: Fri, 27 Feb 2026 19:43:05 -0300 [thread overview]
Message-ID: <aaId-TU97Z8f5Mwy@geday> (raw)
In-Reply-To: <87zf4ujf5b.fsf@posteo.net>
On Fri, Feb 27, 2026 at 05:00:03PM +0000, Charalampos Mitrodimas wrote:
> Geraldo Nascimento <geraldogabriel@gmail.com> writes:
>
> > Drop the 5.0 GT/s Link Speed retraining code block from Rockchip PCIe
> > header definitions. The reason is that Shawn Lin from Rockchip has
> > reiterated that there may be danger of "catastrophic failure" in
> > using their PCIe with 5.0 GT/s speeds.
>
> Patch body says "header definitions" but the change is to the drivers'
> source. Maybe you need to reword in a way that is clear as to what
> happened?
>
> Cheers!
Indeed, I was the victim of reckless copy pasting here.
Will fix for v5.
Thanks,
Geraldo Nascimento
prev parent reply other threads:[~2026-02-27 22:43 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-27 5:35 [PATCH v4 0/4] PCI: rockchip: 5.0 GT/s speed discouraged by Rockchip Geraldo Nascimento
2026-02-27 5:35 ` [PATCH v4 1/4] PCI: rockchip: drop 2.5 GT/s defines Geraldo Nascimento
2026-02-27 16:53 ` Charalampos Mitrodimas
2026-02-27 22:42 ` Geraldo Nascimento
2026-02-27 5:36 ` [PATCH v4 2/4] PCI: rockchip: drive at 2.5 GT/s only and error out other speeds Geraldo Nascimento
2026-02-27 17:33 ` Dragan Simic
2026-02-27 22:47 ` Geraldo Nascimento
2026-02-27 23:04 ` Dragan Simic
2026-02-27 5:36 ` [PATCH v4 3/4] PCI: rockchip-host: do not attempt 5.0 GT/s retraining Geraldo Nascimento
2026-02-27 5:36 ` [PATCH v4 4/4] PCI: rockchip-ep: " Geraldo Nascimento
2026-02-27 17:00 ` Charalampos Mitrodimas
2026-02-27 22:43 ` Geraldo Nascimento [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aaId-TU97Z8f5Mwy@geday \
--to=geraldogabriel@gmail.com \
--cc=bhelgaas@google.com \
--cc=charmitro@posteo.net \
--cc=dsimic@manjaro.org \
--cc=heiko@sntech.de \
--cc=kwilczynski@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=lpieralisi@kernel.org \
--cc=mani@kernel.org \
--cc=robh@kernel.org \
--cc=shawn.lin@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox