public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: David Gow <david@davidgow.net>
Cc: Brendan Higgins <brendan.higgins@linux.dev>,
	Rae Moar <raemoar63@gmail.com>, Shuah Khan <shuah@kernel.org>,
	linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kunit: tool: Recommend --raw_output=all if no KTAP found
Date: Sat, 28 Feb 2026 12:44:09 +0200	[thread overview]
Message-ID: <aaLG-Rb63k2Tiyd_@ashevche-desk.local> (raw)
In-Reply-To: <49a87105-4503-4cf9-a967-e64ffe7fbad4@davidgow.net>

On Sat, Feb 28, 2026 at 06:11:04PM +0800, David Gow wrote:
> Le 27/02/2026 à 10:46 PM, Andy Shevchenko a écrit :
> > On Fri, Feb 27, 2026 at 06:56:49PM +0800, David Gow wrote:
> > > If no KTAP header is found in the kernel output (e.g., because the kernel
> > > crashed before the KUnit executor was run), it's very useful to re-run the
> > > test with --raw_output=all, as that will show any error output (such as a
> > > stacktrace, log message, BUG, etc). This is not particularly intuitive,
> > > however, as --raw_output=all is not well known.
> > > 
> > > Add an extra log line to advertise --raw_output=all in this case, as it's
> > > a terrible user experience to just get "Did any KUnit tests run?"
> > 
> > What's the difference to "full"?
> > 
> > Thanks for adding this, btw!
> 
> Normally, the --raw_output option will just pass through the actual test
> results (or, rather, any kernel output from when the tests are running), by
> skipping everything prior to the "KTAP version 1" line.
> 
> --raw_output=full is a synonym for --raw_output=all, which just passes
> through all of the kernel output, so is useful if we never get as far as
> printing that KTAP version line.
> 
> (I kept forgetting whether it was "full" or "all", which is why both are
> supported.)

Okay, thanks for elaboration:
Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>

-- 
With Best Regards,
Andy Shevchenko



      reply	other threads:[~2026-02-28 10:44 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-27 10:56 [PATCH] kunit: tool: Recommend --raw_output=all if no KTAP found David Gow
2026-02-27 14:46 ` Andy Shevchenko
2026-02-28 10:11   ` David Gow
2026-02-28 10:44     ` Andy Shevchenko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aaLG-Rb63k2Tiyd_@ashevche-desk.local \
    --to=andriy.shevchenko@intel.com \
    --cc=brendan.higgins@linux.dev \
    --cc=david@davidgow.net \
    --cc=kunit-dev@googlegroups.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=raemoar63@gmail.com \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox