From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f177.google.com (mail-dy1-f177.google.com [74.125.82.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 96DC5296BC1 for ; Sun, 1 Mar 2026 05:05:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772341516; cv=none; b=ThvOyhKt2eVdXq42Ai2Fp6+2bJ6IhY+LJTHnsX8YBL12FEXiotIUrsZI3p7SwgvVE3M5XYJKTjwX48yXuK8Ljtn2TztaafYIxnbVhqwjrDE8P/qou9eHpBB/C7h9rUbDjH/8s1KOXchPfIf1sOyZvQMWPOO+aDLTNyVn5ST/tZY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772341516; c=relaxed/simple; bh=yHi0dcVwFnZ3408WTHv6DayGAPwkBF8w98C0UNjcaRo=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=Y5U4DlzkqoME5pEX9yCSkUMG008hKrnxjojRPZZINWvlaOjjhL3ycLXk0oHjylvLFt8kILAKh92ZgC/jceBBLi0psVXEQ7Ms5TtflQCCi5tPZyUzFXdTWN9fEaDwAqeUWca9w92GOwWqtnoYMK4m/nDGXu9QTti1vhXU6B/FxWY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=j97ur1FW; arc=none smtp.client-ip=74.125.82.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="j97ur1FW" Received: by mail-dy1-f177.google.com with SMTP id 5a478bee46e88-2be06c02f66so550453eec.1 for ; Sat, 28 Feb 2026 21:05:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772341515; x=1772946315; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=FCOgTXBl3ExkHQ5G38a7ch0w/W/MqPAXecK622QLvnw=; b=j97ur1FWqya6Vt02AS1Kv6BtXvgMAVl03qVr/NtsK09fEyTFs64NCkw+UJXEG9P1aT Ca1394JTRsb8+lGAepNABSTjYd8FZWvH+W8pFUfHvXtTDS90AMRLarnNSjoUJNDWS6dm 6eUkAue8O+XilenZnqcMlVRsz9jiCNXZFpgz/PVDQsam4pSPSDO3T8JPheW9W481cZra Ga4NPSis8Y5cyS2ZAXXUeTuoQqORNrHkTGJoxq1jTRFYE6wAe0zqg8qEx92U/tYKAWNU HUz+50dtecp1OKBj63zgn6aowZgnpPz3VNerN+2Y0a/oMA3hACCmVihiCh4qE467FujW +OvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772341515; x=1772946315; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=FCOgTXBl3ExkHQ5G38a7ch0w/W/MqPAXecK622QLvnw=; b=UHt+t5RlrD8c6YLtcUzvpBRNSog3hIfJaFM09KuMd+GbcfCyE6a7/7eZwOa028GaE+ oa+eTTyhpAcNHNLAyO0wKBcCYYSVcPcST6U4wI1OVquWhKCzIPxv5KT5guvqWy9DczCo V+lahBpW5rhKFzjMJjAnhXmtXt0t+ARyeRSYcq5pZq9NCg4eMfvep+7eB4Yr3/yOvMKe iU7H9DE+Pr+7x1NkB/eeGX8Df/Biv5HbCcl+iaO8fIq7NT2cZbO4m/E7Xj7ScZ2Z1rdt BQ2L4QQpH9pX9n+C5BVl6YjdAIlspbGEyql7WtSZitWSTjBgpne78NpCIMYiIkhySMjs qfSQ== X-Forwarded-Encrypted: i=1; AJvYcCWL1C3MAL7ka2BY2RF4pMZEx56FQRD1j/ZHa1B5lMZh/Tt78jajqaJChejH2IQoffEjSVYgA1k78NNH6ns=@vger.kernel.org X-Gm-Message-State: AOJu0Yz1E8m+6Gc24T+y8WZhU7nFsjziyOa1xhll9b2D8Th8bjSR5DD6 V7TRgKHvJfdVvnTl9kJs2bHqKKAEg9Tjz2M4wptJWxMmIo/m3/Z2qVgY X-Gm-Gg: ATEYQzwTWaO2ZYe5ph6mrtwfaTp5rRxpIm1JZl3+NGeCSNgiUZL2YzF8Or/V58QHXJ1 04cyHedmxaPCHtsbw3VUMEH4JLukasPJ4Mtsv5vPcUut8SNe/fwbdz0Eu3fbjolRwRIstMUi0OP suGUz9ufVcVNUxrLe9MurlloozIWKPmd916QdZTil638bfGiY8PwylKgP0COxo0K0jU7bn0Z1WD BaspZ7mMlklEuj3YsHIflo6Yzl6u1kJ1qgwiZsHX6/ve/7Bp3YsI2mwefKuxJ4QNw0H2tiCrVSl W5G5+N3YjpHXdS0guOKwHe475f87zAZgslfyPeN0xED4il+hKk61WBlfWidPbeAeHnV7Bb828pd PhOM53B6Vn6k98p/fdQX6oeN+FjdVt6G+g9qfOdOAa+YpjOeuyWI57RJ+jhVVrRTp56WUW0gJMQ LbvzQgCgPu240YQhuwPUWrpOjqRnyreCG2+c3i6PEWCCATAkFst4BJhc6ELjM9JPs1 X-Received: by 2002:a05:7300:bc09:b0:2bd:de8e:d734 with SMTP id 5a478bee46e88-2bde1fdd6a9mr3219382eec.37.1772341514565; Sat, 28 Feb 2026 21:05:14 -0800 (PST) Received: from google.com ([2a00:79e0:2ebe:8:cf71:43a0:f3f6:e5be]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2bdfb3f898asm1813197eec.29.2026.02.28.21.05.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 28 Feb 2026 21:05:13 -0800 (PST) Date: Sat, 28 Feb 2026 21:05:11 -0800 From: Dmitry Torokhov To: Jiri Kosina , Benjamin Tissoires Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] HID: input: use __free(kfree) to clean up temporary buffers Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline The __free() cleanup automatically releases given resource when leaving the scope, so use it to make the code less cluttered with error handling. Signed-off-by: Dmitry Torokhov --- drivers/hid/hid-input.c | 15 ++++----------- 1 file changed, 4 insertions(+), 11 deletions(-) diff --git a/drivers/hid/hid-input.c b/drivers/hid/hid-input.c index 2633fcd8f910..9b2d7795c621 100644 --- a/drivers/hid/hid-input.c +++ b/drivers/hid/hid-input.c @@ -432,23 +432,18 @@ static int hidinput_scale_battery_capacity(struct hid_device *dev, static int hidinput_query_battery_capacity(struct hid_device *dev) { - u8 *buf; int ret; - buf = kmalloc(4, GFP_KERNEL); + u8 *buf __free(kfree) = kmalloc(4, GFP_KERNEL); if (!buf) return -ENOMEM; ret = hid_hw_raw_request(dev, dev->battery_report_id, buf, 4, dev->battery_report_type, HID_REQ_GET_REPORT); - if (ret < 2) { - kfree(buf); + if (ret < 2) return -ENODATA; - } - ret = hidinput_scale_battery_capacity(dev, buf[1]); - kfree(buf); - return ret; + return hidinput_scale_battery_capacity(dev, buf[1]); } static int hidinput_get_battery_property(struct power_supply *psy, @@ -1832,7 +1827,6 @@ static void hidinput_led_worker(struct work_struct *work) struct hid_report *report; int ret; u32 len; - __u8 *buf; field = hidinput_get_led_field(hid); if (!field) @@ -1859,7 +1853,7 @@ static void hidinput_led_worker(struct work_struct *work) /* fall back to generic raw-output-report */ len = hid_report_len(report); - buf = hid_alloc_report_buf(report, GFP_KERNEL); + u8 *buf __free(kfree) = hid_alloc_report_buf(report, GFP_KERNEL); if (!buf) return; @@ -1869,7 +1863,6 @@ static void hidinput_led_worker(struct work_struct *work) if (ret == -ENOSYS) hid_hw_raw_request(hid, report->id, buf, len, HID_OUTPUT_REPORT, HID_REQ_SET_REPORT); - kfree(buf); } static int hidinput_input_event(struct input_dev *dev, unsigned int type, -- 2.53.0.473.g4a7958ca14-goog -- Dmitry