From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f172.google.com (mail-dy1-f172.google.com [74.125.82.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 58E262E888C for ; Sun, 1 Mar 2026 22:10:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772403026; cv=none; b=FLJ1eDEcBg/AGsOeJjk4Csj6EaigTrsQQuf0PBIwDlTC6bdK47WLASTMXpu9sJVnlk08zTpiGRzYHVVorrzNNTWKrHU1a/lXnNtsDIgY5kzWRIAoFplf6hsY9aZTEgxtXp5RU0lViIaQQfylOlhhMWyAJlGOaAnQuWTXl4K7CWQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772403026; c=relaxed/simple; bh=thRh1q6Zg8tV6DzFJ3CJKUqKNXpLmy45vgdB9JTO12A=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=NdyITNTEvYBVe2slnYhIGP7OeutIDv+jV+1UDauXxInleOEVedYmjJSmauOAuTKgIiyz0nU6J3ucmTveosDATZGxAmAPshyQk3hOsuamaD8XxB2ZyRL2Ka73xnZiOPr/hk4VyvxgsVd4TsykF131xbZzY619sJHdhRBcesPj3B4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=H75ozLun; arc=none smtp.client-ip=74.125.82.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="H75ozLun" Received: by mail-dy1-f172.google.com with SMTP id 5a478bee46e88-2bdfc4b191fso584335eec.1 for ; Sun, 01 Mar 2026 14:10:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772403020; x=1773007820; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=nFjVWYC4aukpE9k+uYV7EwxrLAHwdFE4Qix6Wa9fAVI=; b=H75ozLun5rPOR/sPNmlzR5SB5n0Rg/I9CPCiO9f5Q7ojiZgAfrCRho2v3+QMP2ZMYS jjCb42kwexcd+o5PfG1JysClQecfik3Sdfv73FBoobBQEBk0vHXmUUWoMo5+k8PRdYuR fMDVykZ8W2obbynHb6aBHjoeGWzI9A+MJKPMgJfY1AgWZ8WdfhWGWMFBBF3rrS1jVSV+ y8ml3NeEllRqn2/TOpV9xw820fSkTz97ZbIDntnR1sWLvPvm7yAHqqdVkrjh7fa5Pn1p W+gLE/Ht4yTvDCBGG0zZtMdejxAEU1IPlIYoI3C6AVPO061SrfoSAcqvs0X6LmPjRllY Dhig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772403020; x=1773007820; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nFjVWYC4aukpE9k+uYV7EwxrLAHwdFE4Qix6Wa9fAVI=; b=RYJtj5BXgvrjINXr2jm1iYiUCSWV7RpgsNh4xQt3fmwTDbGQskONYW2raBI94Hq7Wn oSmHSk9DO4nwH01OLqcJK+9aEHfyIq/UXq/mPEazMEr1ppj9uEdER3H7p4fveunNKHlP I47vEz1qRAqbLp0rikn+IL0tR/RTmd6q0PWkhAX+WenicbC9FjY8ORsI2bL+Bupc6AQG wRRB3VDJahZDjyTpljU/riKIK3r5vcud7OJs59bzUJlEluSip6mU1LOFz/afXl1aGrfb yDP3xkL0VqagKE75o76AvaVGo2Xy7PXrikPISHIhclJfyzB0ixF9idEJIDjiwKJIXy0N RBPg== X-Forwarded-Encrypted: i=1; AJvYcCVnNi9QdNB8mw3DBKYc57+6Us8L9q1c3WNcZz7sh9KArtOucgTaD9bEeCl5uzOga2YeXYPC6k4asrv6w9E=@vger.kernel.org X-Gm-Message-State: AOJu0Yzf9oWjPhHJHiz39hW7IrjgRBGihiGf4RGLfDZxTmCXHTSt0F+E u5KSA14hQZzcgkl+QJpGNyyQrStACQAAHk3QtIq2bvTMthZYcGe/89J9 X-Gm-Gg: ATEYQzwKk4H49//XHPQAr5CngrCAbLtBxChOwMS9QBeCio77YEqvNxd/rKy9r3fAEmQ 4XsHHjgVbJbLaen1JpO7r44gpA4aoNJDV1K4jXN21GTECdjvFJ1HteePIqWAmJo8Fd83UsQ+8Fj EXOzILm5gFK/sOvE4kj390x5Xt4wjpeRUfizyJzy6KW6evozmwaM3uxT9VIHk2bIe7+M4aBatOw p8d2uGmvhooZSBAMWSmP+s/pJsattfJJOUBkYV/nf00zoqAqYYnrVJAeTmXNama6tzwhFFnhTtW VxBLrepVOwslEK28Fkky/4dd+MX3qJEOizcOt4M4QMAmfXFVsktQ50c8MkdubRV3wOFa7XBF0a8 DHJkBsdlFXx+mP7AlkU3LCPRtJT7pEAfAfbvnsBx+dykdASmRF8Al6mComaqGd/ITGD9fdvkovc qmM6NVH25JCyP7h2jI8D78zSMKDVDBjZHYmZkFadYdGLaPJGm99BYzrWOL4osekNuQ X-Received: by 2002:a05:7300:6c25:b0:2be:e52:a3e2 with SMTP id 5a478bee46e88-2be0e52a574mr617422eec.33.1772403020408; Sun, 01 Mar 2026 14:10:20 -0800 (PST) Received: from google.com ([2a00:79e0:2ebe:8:864f:8513:57d0:4064]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2be12805b93sm1051546eec.15.2026.03.01.14.10.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 01 Mar 2026 14:10:19 -0800 (PST) Date: Sun, 1 Mar 2026 14:10:16 -0800 From: Dmitry Torokhov To: David Heidelberg via B4 Relay Cc: Maxime Coquelin , Alexandre Torgue , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Henrik Rydberg , Bjorn Andersson , Konrad Dybcio , Petr Hodina , linux-input@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski , devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, phone-devel@vger.kernel.org, David Heidelberg Subject: Re: [PATCH 09/10] Input: stmfts - support FTS5 Message-ID: References: <20260301-stmfts5-v1-0-22c458b9ac68@ixit.cz> <20260301-stmfts5-v1-9-22c458b9ac68@ixit.cz> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260301-stmfts5-v1-9-22c458b9ac68@ixit.cz> Hi David, On Sun, Mar 01, 2026 at 06:51:23PM +0100, David Heidelberg via B4 Relay wrote: > From: Petr Hodina > > Introduce basic FTS5 support. > > FTS support SLPI and AP mode, introduce switch GPIO to switch between > those two. Currently we can handle only full power AP mode, so we just > switch to it. > > Useful for devices like Pixel 3 (blueline). I see "is_fts5" sprinkled throughout the code. I wonder: can we define chip-specific operations and call them instead of doing conditional logic which is hard to expand (if ever needed) to support additional variants. > > Nitpick: changed GPL v2 to GPL in module license. Please split in to a separate patch. Thanks. -- Dmitry