From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from hall.aurel32.net (hall.aurel32.net [195.154.119.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 958C636D51F; Sun, 1 Mar 2026 22:16:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.154.119.183 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772403416; cv=none; b=XlEAFJRtiMcjvGIWzgk+tcKVT1Uu9Jf12XOK36FQpDOpdQOGLIdynejWeHjtjTlAOpwgXja+Yr98Kr8Ht4Cu/oo68rnsRtFnba/ymfTf/0aerBWwJuS3RxFtgAEF0S4EVy980oKjX1kv2G1K1MP+dj9oqcpR9Hq90QbYNyAY9ZI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772403416; c=relaxed/simple; bh=5/P6z8fjjf1aurJ8woAsQpeTI2U1RPCcpceZwVaI32Y=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Imb+XCVfr6OpFtdZwr2i9wG5+Xygn/2VFF3RZ2JyObcDr/yX7WzlnqH27/fWhx6xrTNolHKvlhK/d2uk+lAO2pqAwPQO2deg+hBczDiT7mpOgepf+62memM1ps7sNOWlOhu7OUcN2DQZHg7+pFwOssrKqVsVngYqJiTHdCyu+u8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=aurel32.net; spf=pass smtp.mailfrom=aurel32.net; dkim=pass (2048-bit key) header.d=aurel32.net header.i=@aurel32.net header.b=KRMqaNT6; arc=none smtp.client-ip=195.154.119.183 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=aurel32.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=aurel32.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=aurel32.net header.i=@aurel32.net header.b="KRMqaNT6" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=aurel32.net ; s=202004.hall; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Content-Transfer-Encoding:From:Reply-To: Subject:Content-ID:Content-Description:X-Debbugs-Cc; bh=KjrmgbqDuQUoTE7tizH06MNcvn3FP+YVHKxG9kOs+BY=; b=KRMqaNT66WGHYIyuD4Y4Vbgexu jAStbPDQ2v9KhUbU5It83p1lT9e3nB/vQUzRXTX3O8aXvNGmivzBB5/IrFR/G+9bFZQMSEBjeiLQ2 +C+bwt54sqmeOvKaP/cGhmLJBBZw3qrb+sBeRqH0oUDjewPoYQJJO/yXyxUJQ9LH/KwCEV8gBw38l PXT/mkAIEP61vvUdgABIm1b2S9CTMoKlVcHbeO+6ytjZcZRC0W48iNNuYB6ct0pFqftHpJKz76VGA a/hFlahbk55aE20SSLwTqK226Wrag13mOEiFvosWFNvzvNIRjVGKglbSDtLUzfVaziNUft7AtanxT 4BaR/NIw==; Received: from authenticated user by hall.aurel32.net with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1vwp5a-0000000C8Gc-1plv; Sun, 01 Mar 2026 23:16:38 +0100 Date: Sun, 1 Mar 2026 23:16:37 +0100 From: Aurelien Jarno To: Yanko Kaneti Cc: linux-kernel@vger.kernel.org, Lee Jones , Sebastian Reichel , Troy Mitchell , Yixun Lan , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , "open list:RISC-V ARCHITECTURE:Keyword:riscv" , "open list:RISC-V SPACEMIT SoC Support:Keyword:spacemit" , "open list:SYSTEM RESET/SHUTDOWN DRIVERS" Subject: Re: [PATCH v5 2/2] mfd: simple-mfd-i2c: add a reboot cell for the SpacemiT P1 chip Message-ID: Mail-Followup-To: Yanko Kaneti , linux-kernel@vger.kernel.org, Lee Jones , Sebastian Reichel , Troy Mitchell , Yixun Lan , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , "open list:RISC-V ARCHITECTURE:Keyword:riscv" , "open list:RISC-V SPACEMIT SoC Support:Keyword:spacemit" , "open list:SYSTEM RESET/SHUTDOWN DRIVERS" References: <20251102230352.914421-1-aurelien@aurel32.net> <20251102230352.914421-3-aurelien@aurel32.net> <990bc03ed2baa05e619f0aa9cc6a23acadd66ea6.camel@declera.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <990bc03ed2baa05e619f0aa9cc6a23acadd66ea6.camel@declera.com> User-Agent: Mutt/2.2.13 (2024-03-09) On 2026-02-27 13:29, Yanko Kaneti wrote: > On Thu, 2026-02-26 at 22:32 +0100, Aurelien Jarno wrote: > > Hi, > > > > On 2026-02-26 16:32, Yanko Kaneti wrote: > > > Hello, > > > > > > On Mon, 2025-11-03 at 00:02 +0100, Aurelien Jarno wrote: > > > > Add a "spacemit-p1-reboot" cell for the SpacemiT P1 chip. > > > > > > > > Signed-off-by: Aurelien Jarno > > > > --- > > > > v5: no changes > > > > > > > > drivers/mfd/simple-mfd-i2c.c | 1 + > > > > 1 file changed, 1 insertion(+) > > > > > > > > diff --git a/drivers/mfd/simple-mfd-i2c.c b/drivers/mfd/simple-mfd-i2c.c > > > > index 0a607a1e3ca1d..542d378cdcd1f 100644 > > > > --- a/drivers/mfd/simple-mfd-i2c.c > > > > +++ b/drivers/mfd/simple-mfd-i2c.c > > > > @@ -99,6 +99,7 @@ static const struct regmap_config spacemit_p1_regmap_config = { > > > > }; > > > > > > > > static const struct mfd_cell spacemit_p1_cells[] = { > > > > + { .name = "spacemit-p1-reboot", }, > > > > { .name = "spacemit-p1-regulator", }, > > > > { .name = "spacemit-p1-rtc", }, > > > > }; > > > > > > Perhaps its safe to merge this one now that everything P1 and I2C is > > > already in linus tip ? > > > > Unfortunately, this patchset is still missing: > > https://lore.kernel.org/all/20260207-b4-k3-i2c-pio-v7-0-626942d94d91@linux.spacemit.com/ > > > > This means the reboots work most of the time, but are not 100% reliable, > > and that's the reason why this patch got blocked from merging. > > I see. Thanks. Sounds to me like sometimes working compared to never > working is better , but anyway.. I agree with that, but the decision was to hold on this patch until the I2C PIO part got merged. > FWIW with this patch and the pio patcheset I get this rcu splat on > reboot (which is still working). Similar splat is there without the pio > patcheset. I haven't been able to reproduce the issue here after 10+ reboots on a BPI-F3 board, but I tried the patch on top of 6.19. I'll try to build a 7.0.0-rc2 kernel and report back. At a first glance the problem seems to happen in the I2C PIO code. On which hardware is that happening? Regards Aurelien -- Aurelien Jarno GPG: 4096R/1DDD8C9B aurelien@aurel32.net http://aurel32.net