From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f180.google.com (mail-pg1-f180.google.com [209.85.215.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3BF1721D585 for ; Mon, 2 Mar 2026 02:56:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772420209; cv=none; b=VUvB+uKcVjPbSx2bWDE4lmNNy2u8u+Cb8lNIVD1YbuNAtYCVE2/LTKPqtFHJ0qKRk16mBbsMYgMFqT1tRghlHsgLwTzFQ8WLPwq0BLxPy13Kxb1kiacl8+KUsu1nBMhk66RBSrRdLlrTmwsbSa4ko3Ocu+ORLiQ/4G5g6yIsnJY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772420209; c=relaxed/simple; bh=gIE/44stX79ALnb7rChzVQZ2Dpduyy8XaMyDAIdPhnw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ZYLsr7KAf8dEezcdU2bOpZhNCpzekVOIj7WVO0cWcV/hjjRuyErmaPe4tTvCDYupri6NiVbt1oFNyi6y4k5Xh0NgwWcJl5gI1CTjztBmzg37L7q0V2eb8Xh6bM4evTtInsX+nDdmTrSj00Cx9i/mWKRlBma9IAwP0oMK8iakj6c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=HDxtHo6Y; arc=none smtp.client-ip=209.85.215.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HDxtHo6Y" Received: by mail-pg1-f180.google.com with SMTP id 41be03b00d2f7-c70e96737a5so1154398a12.2 for ; Sun, 01 Mar 2026 18:56:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772420207; x=1773025007; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=UaudPRYMaCzBkZFbuzZvYvAt9qJAiuhR+yH16j9G5tY=; b=HDxtHo6YU5HQ943+zuwoa1Vk7sJyRl0vCyXwInmYoJ7GuzZAhI74AFlztOnUubXKyv kvSkHDqdTsARgBbggtjzZH9OXeEg+upy6RypXP4IYgvfvr1kuKo0jx7sDFRpR+xynP3D XwL7gPzpv++dJsSqz915qP8PeuTq8yRmPRApHxisn1G7ukXtUrd6fhsL3dcHR1cGiEl7 NnbRITThWNt2oblCP5iiNSmwcZo6jM3c0Exjs/kcyem5beP1Cz1G67Iw35ByavIqYoHL FMAlky8hLl5ZOub+C/wo/XeQ8GrTTmuSAdr98jBpOgzFdzWe8+t43Jj6VUsVZTBmjQo/ jQCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772420207; x=1773025007; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=UaudPRYMaCzBkZFbuzZvYvAt9qJAiuhR+yH16j9G5tY=; b=xUxRjevYTXpwYr+ecItablbLphkVwlw3gvmzPmTcmIh/JwCh7ChxOP/qgOkTjbb2To WLS+prNuzgA+ZCpeTNW2m21/MFkBy5ebouwFjuAHFwwgPvHPgxAumCNhwVwcRKNDipKd mDY5N47VItrQGtu7M0pKb0M1ijauoIjWIuhwfchOIvbJP5YWo0nirWIaoC/6jx+TcVhS THyNxYA6OlNWx6BU3HWzhQOxV76Pp3zdtD94vu8UWiu3/sHk5r4gXmdGfflSjDfkewVJ rFcndkP7N1SmWakLN2A4nAUzYTLcdDVk5vQOZbqbs1x+q9T5SPHxQXRtNoZ5X+8xBlNT ke9w== X-Forwarded-Encrypted: i=1; AJvYcCVRMCIshS5+QR1l8uEnmDW9M3NIwbgLiQv2qTRrWu4vEKFQ/D/HD2CYJdu2GAscc1tcNEIaVglg71LDqbQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yy9DHkvIYYr3OZZnmrUocfG41QzLQaFFMnDVwHpvMLGMR17Hlx1 fDOvLatKOIWDs7vgF53J8IH+tCX9M6AVFIjAWS3T3RVT3OfMxHnXzYhz X-Gm-Gg: ATEYQzzozh9cFAmIx6u/dXv22REm9AJH2r9b2zHMDqQlTXgIKzSRZwnOOMxUA3mpLGf 0fRCJEcNhRN2CMtMzDDMcX51C/BGShiyF5fpE3YOrwYLWbGtdd4dKiLb8m/sV+svVMogR8OQqbU m7gaCBPXtouLyJqUqaei4AtWEFpzp7XEJBdV6o/W2wFcyn0f/17ADv/KKjgaEfpqxXHA6DNFMuR D7t7S6pospmL/uoJ4Jk8ooGXGIrX5nlj9Ma1krb2PqgKkOJ2ab8zqq6AU/aCpDLUhJzch8WcVZ7 Glc6CXtsZTW4t2Fy/rIsUvBUqMZ6IwikJbjyjzHGFas3MkFx3mXzMpEgDKvllbhJIW8LleyAu75 yhXEBIzYWOr+BqfY4et1H/mwJ/wc8U3v7CVzevDU0P7dYH2Z4yj06zD1g0TTx1zXl39HYjLtV36 0r+F+82pe4j01J5kqovw7uwAy6RiSR40Y= X-Received: by 2002:a17:90b:4a43:b0:359:dd9:3de5 with SMTP id 98e67ed59e1d1-35965c242femr9766592a91.4.1772420206740; Sun, 01 Mar 2026 18:56:46 -0800 (PST) Received: from google.com ([2401:fa00:95:201:bcbf:245b:e1cc:a121]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3593dcc777esm11630554a91.5.2026.03.01.18.56.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 01 Mar 2026 18:56:46 -0800 (PST) Date: Mon, 2 Mar 2026 10:56:43 +0800 From: Kuan-Wei Chiu To: Josh Law Cc: Andrew Morton , linux-kernel@vger.kernel.org, Josh Law Subject: Re: [PATCH 2/2] lib: glob: replace bitwise OR with logical operation on boolean Message-ID: References: <20260301152143.2572137-1-objecting@objecting.org> <20260301152143.2572137-2-objecting@objecting.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260301152143.2572137-2-objecting@objecting.org> Hi Josh, On Sun, Mar 01, 2026 at 03:21:42PM +0000, Josh Law wrote: > Using bitwise OR (|=) on a boolean variable is valid C, but replacing it with a direct logical assignment makes the intent clearer and appeases strict static analysis tools. > > Signed-off-by: Josh Law checkpath.pl reported the following warnings: WARNING: Prefer a maximum 75 chars per line (possible unwrapped commit description?) #81: Using bitwise OR (|=) on a boolean variable is valid C, but replacing it with a direct logical assignment makes the intent clearer and appeases strict static analysis tools. WARNING: From:/Signed-off-by: email address mismatch: 'From: Josh Law ' != 'Signed-off-by: Josh Law ' total: 0 errors, 2 warnings, 0 checks, 9 lines checked Regards, Kuan-Wei > --- > lib/glob.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/lib/glob.c b/lib/glob.c > index 902b5037a0a8..afff28285bd4 100644 > --- a/lib/glob.c > +++ b/lib/glob.c > @@ -96,7 +96,8 @@ bool __pure glob_match(char const *pat, char const *str) > class += 2; > /* Any special action if a > b? */ > } > - match |= (a <= c && c <= b); > + if (a <= c && c <= b) > + match = true; > } while ((a = *class++) != ']'); > > if (match == inverted) > -- > 2.43.0 > >