From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f175.google.com (mail-pf1-f175.google.com [209.85.210.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6B55229A2 for ; Mon, 2 Mar 2026 03:03:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772420582; cv=none; b=NoL/lXbyHU8cyq/j3GbCzdjPRATGlUlhzeH2CGoKdhvZ6XN7oC6GMi51LFRM6L4GOnrowRVfB9pWkJCaQXEtFEsRzAXLC9+BjtX4uKoL/YEJUj6RDYUsLCDdUqwBXALhgbzfgOk9OKO0sJCGf+Lc82iUMP7AHTFgMGOCsiqQyNY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772420582; c=relaxed/simple; bh=/5ti7eN1+gvWguyjdp3XpNqdkQ/9pHuT+s1gOWGECuk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=i7sEi1P47gtfev4re47rgf4VPOu8Pl/0jMHu0U5vs3uMaBfe0oHt9gaZxdvUfAq9Fs2BumBDrCDxx7G/ADiwf8lI4H4FOcNgCDOUE1R8FLVba0Rlp1Pdx0p1WvZM6aDAJkzQWU9lveDmSx1Cgwn1odPnLhnGIdQ7YUPVg38mO7I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=cL8bV6bI; arc=none smtp.client-ip=209.85.210.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="cL8bV6bI" Received: by mail-pf1-f175.google.com with SMTP id d2e1a72fcca58-82735a41985so2242815b3a.2 for ; Sun, 01 Mar 2026 19:03:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772420581; x=1773025381; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=0SmEr7oHLmBLVHwJ07UCuiplqEWV1IQTMxpFYWupXQY=; b=cL8bV6bInhr/KFZtHq8Tqdk1881aLqgLaWuHe2FQgaDLz946B5uOe+nkN/DFojxqEP lfbCM+05dsHnUIrnAO71qZTUFAoeyL/+cGEJhfzI3rzoUZtUn/66hcMFoL0aNGO4U/j8 HJz9Qkq8/YYSbE30ZhUB10y5WU7EfCp43B5iHYPizaPIJMaud4jUULo44JBo+Jp37H+r pFGyS4+woeVBjKNFQx/O0fol/QPHPrKwbCWkuKSxJ4YN7rACNCzzkK2LgZbOGpxISaXE q42wryYmENHMJfCLlAppyBE7oPzyMKz7JHTwt12v5535aHoLodX3pL47jWX2NziOkZY1 I01Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772420581; x=1773025381; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0SmEr7oHLmBLVHwJ07UCuiplqEWV1IQTMxpFYWupXQY=; b=amoPkXDuDDz8HuBlc4K37AEi3pLJNUUVVbfrJISO1Bi1nDW7lBvjm2sbE+ic7ldYMu VHrRU2+0FYozkumqtia/9Nw4FeLyPW5P2XSp3WyYLO/PnKHMTnGErY2cH82Dzd07TPkS i2d9pwri4muox3wqXF3we5OpLLgzMdkDLjBL4Lq0Kko8JUixsC7zV41oMqRJ5epVQ+I0 rTkCwQSmE8OL47IXz214Ejzip7lTxygxUTS3pBdoQTU/h/EmIoCRZqjIgT8+ktU8uG9/ ymtZTHBjgxQ5xUkYFpp8kWgqIlK1AyYdbSKKHJM30tDL4kxsyP72UBZHtSczD56Iaf6g nNKg== X-Forwarded-Encrypted: i=1; AJvYcCWTk+6Ew6dyTDTMSxNQaVZvBuAYDHYhdy4ORT07kEz3UlNVQr31lAO0qzY0enxB2Ym1EEwry5rJRAwjDlY=@vger.kernel.org X-Gm-Message-State: AOJu0YyU77dLEaTHaLJo0GVq3rrNZrCq6o1bvZbApPleU14/fCVjbRJq JyXvzvI3NTfVEhUGGycpPSyAGWNiBpuCfn+uBSUakEa5PFi3f0P3JxtJ X-Gm-Gg: ATEYQzyaicCH2UVdC64eTWR9lQsxGr8EBrYM7me+vQcePziezIm3j5klMp3AwWb31I6 zXp/sX0HU5VQOpIPZZIZOrwnlORqUlb7KJb3wxZs8kyVy4VFzefR2rpog//5BjEjiNjUcNqftmd o52R7lx9lg7dwShxuOFqDlPEbAg8JP9fvCdvXxVeNDrKUbE1Ur4uo9l7vq7GN4hXE71mLG7qNmn QVbEsGdQeVttr/jLe58pkR0JSl2eVRnbOmoywerkeY0/ccCnu7PygW3KARRUAqBLlRLCfChf4d0 HZViTzvaBEwPZEUADEgkC1ARjA3G9EYxlvtds0EeBPdS0ZELNoNB6PRT51brzpti738ziQVRR9t 5VRME9w5k6Q4q+7ny/WPz2nHQHGOLNjr0Bn199v945LnWAihxB5cLL4tEfu2dbsPz527kGUEMou MXaAXWsOoncKYQu+trFJGEaAY8bomyUHXq X-Received: by 2002:a05:6a20:6a04:b0:38d:e6f8:fd96 with SMTP id adf61e73a8af0-395c3b3a501mr10532543637.60.1772420580645; Sun, 01 Mar 2026 19:03:00 -0800 (PST) Received: from google.com ([2401:fa00:95:201:bcbf:245b:e1cc:a121]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c70fa806295sm10403353a12.16.2026.03.01.19.02.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 01 Mar 2026 19:03:00 -0800 (PST) Date: Mon, 2 Mar 2026 11:02:57 +0800 From: Kuan-Wei Chiu To: Josh Law Cc: Andrew Morton , linux-kernel@vger.kernel.org, Josh Law Subject: Re: [PATCH 2/2] lib: glob: replace bitwise OR with logical operation on boolean Message-ID: References: <20260301152143.2572137-1-objecting@objecting.org> <20260301152143.2572137-2-objecting@objecting.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Mon, Mar 02, 2026 at 10:56:47AM +0800, Kuan-Wei Chiu wrote: > Hi Josh, > > On Sun, Mar 01, 2026 at 03:21:42PM +0000, Josh Law wrote: > > Using bitwise OR (|=) on a boolean variable is valid C, but replacing it with a direct logical assignment makes the intent clearer and appeases strict static analysis tools. > > > > Signed-off-by: Josh Law > > checkpath.pl reported the following warnings: > > WARNING: Prefer a maximum 75 chars per line (possible unwrapped commit description?) > #81: > Using bitwise OR (|=) on a boolean variable is valid C, but replacing it with a direct logical assignment makes the intent clearer and appeases strict static analysis tools. > > WARNING: From:/Signed-off-by: email address mismatch: 'From: Josh Law ' != 'Signed-off-by: Josh Law ' > > total: 0 errors, 2 warnings, 0 checks, 9 lines checked > BTW, both of your patches does not apply cleanly. Regards, Kuan-Wei