* [PATCH v2 1/4] Input: elo - fix style issues
@ 2026-02-28 19:52 Josh Law
2026-03-02 0:25 ` Dmitry Torokhov
0 siblings, 1 reply; 3+ messages in thread
From: Josh Law @ 2026-02-28 19:52 UTC (permalink / raw)
To: Dmitry Torokhov; +Cc: linux-input, linux-kernel, Josh Law
Fix array constness and spacing issues reported by checkpatch.
Signed-off-by: Josh Law <objecting@objecting.org>
---
drivers/input/touchscreen/elo.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/input/touchscreen/elo.c b/drivers/input/touchscreen/elo.c
index 434b9b47e964..40ae132cde21 100644
--- a/drivers/input/touchscreen/elo.c
+++ b/drivers/input/touchscreen/elo.c
@@ -257,7 +257,7 @@ static int elo_command_10(struct elo *elo, unsigned char *packet)
static int elo_setup_10(struct elo *elo)
{
- static const char *elo_types[] = { "Accu", "Dura", "Intelli", "Carroll" };
+ static const char * const elo_types[] = { "Accu", "Dura", "Intelli", "Carroll" };
struct input_dev *dev = elo->dev;
unsigned char packet[ELO10_PACKET_LEN] = { ELO10_ID_CMD };
@@ -273,7 +273,7 @@ static int elo_setup_10(struct elo *elo)
dev_info(&elo->serio->dev,
"%sTouch touchscreen, fw: %02x.%02x, features: 0x%02x, controller: 0x%02x\n",
- elo_types[(packet[1] -'0') & 0x03],
+ elo_types[(packet[1] - '0') & 0x03],
packet[5], packet[4], packet[3], packet[7]);
return 0;
--
2.43.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2 1/4] Input: elo - fix style issues
2026-02-28 19:52 [PATCH v2 1/4] Input: elo - fix style issues Josh Law
@ 2026-03-02 0:25 ` Dmitry Torokhov
2026-03-02 7:13 ` Josh Law
0 siblings, 1 reply; 3+ messages in thread
From: Dmitry Torokhov @ 2026-03-02 0:25 UTC (permalink / raw)
To: Josh Law; +Cc: linux-input, linux-kernel, Josh Law
Hi Josh,
On Sat, Feb 28, 2026 at 07:52:58PM +0000, Josh Law wrote:
> Fix array constness and spacing issues reported by checkpatch.
>
> Signed-off-by: Josh Law <objecting@objecting.org>
Why the difference between From: and Signed-off-by?
> ---
> drivers/input/touchscreen/elo.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/input/touchscreen/elo.c b/drivers/input/touchscreen/elo.c
> index 434b9b47e964..40ae132cde21 100644
> --- a/drivers/input/touchscreen/elo.c
> +++ b/drivers/input/touchscreen/elo.c
> @@ -257,7 +257,7 @@ static int elo_command_10(struct elo *elo, unsigned char *packet)
>
> static int elo_setup_10(struct elo *elo)
> {
> - static const char *elo_types[] = { "Accu", "Dura", "Intelli", "Carroll" };
> + static const char * const elo_types[] = { "Accu", "Dura", "Intelli", "Carroll" };
> struct input_dev *dev = elo->dev;
> unsigned char packet[ELO10_PACKET_LEN] = { ELO10_ID_CMD };
>
> @@ -273,7 +273,7 @@ static int elo_setup_10(struct elo *elo)
>
> dev_info(&elo->serio->dev,
> "%sTouch touchscreen, fw: %02x.%02x, features: 0x%02x, controller: 0x%02x\n",
> - elo_types[(packet[1] -'0') & 0x03],
> + elo_types[(packet[1] - '0') & 0x03],
> packet[5], packet[4], packet[3], packet[7]);
>
> return 0;
Thanks.
--
Dmitry
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2 1/4] Input: elo - fix style issues
2026-03-02 0:25 ` Dmitry Torokhov
@ 2026-03-02 7:13 ` Josh Law
0 siblings, 0 replies; 3+ messages in thread
From: Josh Law @ 2026-03-02 7:13 UTC (permalink / raw)
To: Dmitry Torokhov; +Cc: linux-input, linux-kernel, Josh Law
2 Mar 2026 00:25:16 Dmitry Torokhov <dmitry.torokhov@gmail.com>:
> Hi Josh,
>
> On Sat, Feb 28, 2026 at 07:52:58PM +0000, Josh Law wrote:
>> Fix array constness and spacing issues reported by checkpatch.
>>
>> Signed-off-by: Josh Law <objecting@objecting.org>
>
> Why the difference between From: and Signed-off-by?
>
>> ---
>> drivers/input/touchscreen/elo.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/input/touchscreen/elo.c b/drivers/input/touchscreen/elo.c
>> index 434b9b47e964..40ae132cde21 100644
>> --- a/drivers/input/touchscreen/elo.c
>> +++ b/drivers/input/touchscreen/elo.c
>> @@ -257,7 +257,7 @@ static int elo_command_10(struct elo *elo, unsigned char *packet)
>>
>> static int elo_setup_10(struct elo *elo)
>> {
>> - static const char *elo_types[] = { "Accu", "Dura", "Intelli", "Carroll" };
>> + static const char * const elo_types[] = { "Accu", "Dura", "Intelli", "Carroll" };
>> struct input_dev *dev = elo->dev;
>> unsigned char packet[ELO10_PACKET_LEN] = { ELO10_ID_CMD };
>>
>> @@ -273,7 +273,7 @@ static int elo_setup_10(struct elo *elo)
>>
>> dev_info(&elo->serio->dev,
>> "%sTouch touchscreen, fw: %02x.%02x, features: 0x%02x, controller: 0x%02x\n",
>> - elo_types[(packet[1] -'0') & 0x03],
>> + elo_types[(packet[1] - '0') & 0x03],
>> packet[5], packet[4], packet[3], packet[7]);
>>
>> return 0;
>
> Thanks.
>
> --
> Dmitry
Sorry, because my main email can't send emails and I prefer to use my objecting.org email
V/R
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-03-02 7:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-02-28 19:52 [PATCH v2 1/4] Input: elo - fix style issues Josh Law
2026-03-02 0:25 ` Dmitry Torokhov
2026-03-02 7:13 ` Josh Law
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox