From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f172.google.com (mail-pf1-f172.google.com [209.85.210.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C92931AC44D for ; Mon, 2 Mar 2026 01:25:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772414731; cv=none; b=CYvnLtozOrRWIcB96iupE8+//54hLx4L+qq0XGl1YwQVmleiZHWPIO81GZrY+tBAZj7MT89hX5jSS924CwunPhMgLjfWmgUgWp14OwOsvDFOdeeDuwdSib7lfVny/hfy30YHeHQjoH7J4ci2U8iZJDpVC/qCoBKDsG9uFmfsyqc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772414731; c=relaxed/simple; bh=c11Ik9Wu6rWFx89nAQqqQ2uqdevqJ9lypkYRGm4U544=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=VGvNbu2udUo7y9CscVr6AHERXOV6f4jsJD4YDeXe/eZy0w0voBmjblOk4Jgnq4YLa2WbMcWhCSf9Xwb8eYm9jGxpdz+NEahoEzN9V7L3D3/E0dFKZzm4apzt2RdXD80Oh3aH6Ak7LU26E6UOGwFytC1i3CB5Od4ZBp8I0AzPqyU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=KXQlEh/b; arc=none smtp.client-ip=209.85.210.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="KXQlEh/b" Received: by mail-pf1-f172.google.com with SMTP id d2e1a72fcca58-82747396358so1721295b3a.0 for ; Sun, 01 Mar 2026 17:25:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772414730; x=1773019530; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=s+sFBMEk2xP6V4+icz7JQnrewXI0dluunX//sXy6N9A=; b=KXQlEh/bqncMUZ6FfhyPSJNoVdjCn8xshLuSlgei+EWeZ9dS4pChkP86mFWJVQ9Gw2 eflMZBUdMec+YYYJKxjNhGchSZy3fHnJPj4yNFS9NkewUrBesJ9CtCY23n2MO1gALQPM Ff+kG3H2EBO3irVsipqA5ViOwOrPbg94plqOSxcbIA4IwwUwnqCYTABu2zZQFOCbSKPA AoOwEn9yMIGThJNC1mMmlpqQ11juBakmfGBxR71jRWCB/Qps8Hr4cBWNhR4SPLBqY0O5 le1Q1vVOAzDc8OFnPFNpHs1hNnzAX+RQSTxgrbqMH3ablUcvOwWQS6vxA5zW2swJo+Ht pKhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772414730; x=1773019530; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=s+sFBMEk2xP6V4+icz7JQnrewXI0dluunX//sXy6N9A=; b=HaHCGlUuTWubrixDf8Xs/Yi86dU5C2Ff7WPGBaOMLqv+OL2+HtoaljItUsfLBaLHAY isFh5641VlKpEBdILu/zcFZXCldW5rNwACz7ZKoA9tPUdPp7o+8Z9zgbtLr2+Dh7rq6V jyDwZyyfaz0e8JOhjuSxaL+ra4N7X1sVXFy6Rv98uIY3akKiU7kRGhKr1U2RMObHAxal 6SCsTGladjpGsnm93jIY00TJQqsG37LCVvTYESJkEdNo+mcF5jjhM+6Qcn2l0PiAt4/F ZxinQeWyqDjQtTeoNM0M/F4p6+teQX0x+YJP66f+BZZZXgaS9+XJpQVJH+04CosF4bEO G+iA== X-Forwarded-Encrypted: i=1; AJvYcCXATMlpAgEABH72i3rUQSoNToKCPmmEdKrOdfgJj9F8W8DmUlV9AyEN9UtArla+cr1YvRgp+9CI22Z2jUU=@vger.kernel.org X-Gm-Message-State: AOJu0YzLVaFDx/TZbVSNkujeYRImiw9gpJdE+PlU5wyUKdpxb++PyM07 Z+sggoBXqDyX1uCcJIquozMB3wBBD3IOJerdTcVnz2qFxEG5Fk3zoNsx X-Gm-Gg: ATEYQzxXHiIWDpwTp5xQjP743CACr9s8dJa0qHe4EQZl7PBpsIqvzwwk0KFZIL+4+s3 vEZpi4M2gacgc8q0LjUTUdMqX4HkmMV+Lx29oDSgGwKMeqmPaLg1Fkhl8SSZxTMUOR2BqhP1B0l uW4OJcmS1ZpjstsqDSInzH26xEtyLT6kF/SZ/a3/gd02llPSz75Xg4fERNXZDAQlzrbLtvtX7xX dqY5CUTg35NTUspfzt4xcXDZRlEgfLLGjrjU4ABm0gl9iWnLwgnDDcKpBlFsOoguyb9EjM3x7ip XVhCW7QdFgrJJiYCV1wFwIUuHKwOT9kzBN6QzsV/Zhx8YQxePCzW8jAbq9Pb+Co0X3naf3KLol2 FooMykkSEzMoMV6r2SQIAZqWW0wbJlX+cfUlx7jeYtHfp4Lbc7SRQ6F/zeXSSMDnadte6oD/vEU h6B9NleMZ40OiLbnog9EEKaKyHc+O8aQSsa/aluA== X-Received: by 2002:a05:6a00:909e:b0:81f:4046:1490 with SMTP id d2e1a72fcca58-8274da06b33mr8806359b3a.44.1772414730092; Sun, 01 Mar 2026 17:25:30 -0800 (PST) Received: from fedora ([209.132.188.88]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82739d87e4csm11200214b3a.15.2026.03.01.17.25.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 01 Mar 2026 17:25:29 -0800 (PST) Date: Mon, 2 Mar 2026 01:25:07 +0000 From: Hangbin Liu To: Ricardo =?iso-8859-1?Q?B=2E_Marli=E8re?= Cc: Martin KaFai Lau , Daniel Borkmann , John Fastabend , Stanislav Fomichev , Alexei Starovoitov , Andrii Nakryiko , Eduard Zingerman , Song Liu , Yonghong Song , KP Singh , Hao Luo , Jiri Olsa , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Toke =?iso-8859-1?Q?H=F8iland-J=F8rgensen?= , David Ahern , Jay Vosburgh , Andrew Lunn , Fernando Fernandez Mancera , bpf@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net 3/3] net: bonding: Fix nd_tbl NULL dereference when IPv6 is disabled Message-ID: References: <20260228-net-nd_tbl_fixes-v1-0-2b2a274df9bb@suse.com> <20260228-net-nd_tbl_fixes-v1-3-2b2a274df9bb@suse.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260228-net-nd_tbl_fixes-v1-3-2b2a274df9bb@suse.com> On Sat, Feb 28, 2026 at 02:46:28PM -0300, Ricardo B. Marlière wrote: > When booting with the 'ipv6.disable=1' parameter, the nd_tbl is never If it's booting without ipv6 module, maybe we can use ipv6_mod_enabled() to stop ns validation early. e.g diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c index a1de08ee3815..be9e01ddd6ac 100644 --- a/drivers/net/bonding/bond_main.c +++ b/drivers/net/bonding/bond_main.c @@ -3372,7 +3372,7 @@ int bond_rcv_validate(const struct sk_buff *skb, struct bonding *bond, } else if (is_arp) { return bond_arp_rcv(skb, bond, slave); #if IS_ENABLED(CONFIG_IPV6) - } else if (is_ipv6) { + } else if (is_ipv6 && ipv6_mod_enabled()) { return bond_na_rcv(skb, bond, slave); #endif } else { Thanks Hangbin