From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1E665199FBA for ; Mon, 2 Mar 2026 03:23:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772421790; cv=none; b=L0nbZEyt81nCULQV0tJXmMKeJ8yekqGv2g+IntXleuDdBq52lzaxClQ0chiSiJV4kz4mqfdyn6xbEaevP9CXbgzLcfcWKXYR6czUsuOSIUfWzah6BQEwALXVySefBFVqOynGlp2YtIzvjdX38aRgW5GWQdW+FLaZvPll8rqenGs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772421790; c=relaxed/simple; bh=/qJP86EIPs2u+h2O2p7h4gPCySPa+O7p4y4xobeSFBE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=LSzcaP4ZcvHSz/OABrm1k3xIZx6Ns+HCREB9mGnTy3fSCkuSE1oKGsDt6xBxlTTd5i/+KR4MTX7M7wjqlixkEKU6UqY5IIs9Z1fd7WWc506zbdV0dDbQLTSg1AoDZcC1HScU6XpF+igXmOYUi2luMvo3Awq1HStNmdYTV2pbi4k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=atxp6BnX; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="atxp6BnX" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1772421788; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=805Lu3EMapzlzEnavOwixZrJ0Hw2CqNoGnLSexCdNJg=; b=atxp6BnXCmIu13v6XcAIKrnnikwtSgLB506rTyascRMiTELMZ/MkpNQ3CJZxNU6hhaQqSP 4etXD8AWeLuK7WDhVyoFl2BzPU8JZk330r/Ijas8H/MKMBIP3itgsTOgE7VymFK3tfhKbj XJbauzIvd39E5hOvqgeNqA/j9doQGUY= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-610-ZKMInV-7Ov60vBkvpA8OSQ-1; Sun, 01 Mar 2026 22:23:05 -0500 X-MC-Unique: ZKMInV-7Ov60vBkvpA8OSQ-1 X-Mimecast-MFC-AGG-ID: ZKMInV-7Ov60vBkvpA8OSQ_1772421784 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id E453D195608E; Mon, 2 Mar 2026 03:23:03 +0000 (UTC) Received: from localhost (unknown [10.72.112.98]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id AA6A130001BB; Mon, 2 Mar 2026 03:23:02 +0000 (UTC) Date: Mon, 2 Mar 2026 11:22:58 +0800 From: Baoquan He To: Thorsten Blum Cc: Andrew Morton , Vivek Goyal , Dave Young , kexec@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] crash_dump: use sysfs_emit in sysfs show functions Message-ID: References: <20260301125106.911980-2-thorsten.blum@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260301125106.911980-2-thorsten.blum@linux.dev> X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 On 03/01/26 at 01:51pm, Thorsten Blum wrote: > Replace sprintf() with sysfs_emit() in sysfs show functions. > sysfs_emit() is preferred for formatting sysfs output because it > provides safer bounds checking. No functional changes. > > Signed-off-by: Thorsten Blum > --- > kernel/crash_dump_dm_crypt.c | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) Acked-by: Baoquan He > > diff --git a/kernel/crash_dump_dm_crypt.c b/kernel/crash_dump_dm_crypt.c > index 1f4067fbdb94..827572aa800b 100644 > --- a/kernel/crash_dump_dm_crypt.c > +++ b/kernel/crash_dump_dm_crypt.c > @@ -6,6 +6,7 @@ > #include > #include > #include > +#include > > #define KEY_NUM_MAX 128 /* maximum dm crypt keys */ > #define KEY_SIZE_MAX 256 /* maximum dm crypt key size */ > @@ -189,7 +190,7 @@ static inline struct config_key *to_config_key(struct config_item *item) > > static ssize_t config_key_description_show(struct config_item *item, char *page) > { > - return sprintf(page, "%s\n", to_config_key(item)->description); > + return sysfs_emit(page, "%s\n", to_config_key(item)->description); > } > > static ssize_t config_key_description_store(struct config_item *item, > @@ -265,7 +266,7 @@ static struct config_item *config_keys_make_item(struct config_group *group, > > static ssize_t config_keys_count_show(struct config_item *item, char *page) > { > - return sprintf(page, "%d\n", key_count); > + return sysfs_emit(page, "%d\n", key_count); > } > > CONFIGFS_ATTR_RO(config_keys_, count); > @@ -274,7 +275,7 @@ static bool is_dm_key_reused; > > static ssize_t config_keys_reuse_show(struct config_item *item, char *page) > { > - return sprintf(page, "%d\n", is_dm_key_reused); > + return sysfs_emit(page, "%d\n", is_dm_key_reused); > } > > static ssize_t config_keys_reuse_store(struct config_item *item, > @@ -321,7 +322,7 @@ static bool restore; > > static ssize_t config_keys_restore_show(struct config_item *item, char *page) > { > - return sprintf(page, "%d\n", restore); > + return sysfs_emit(page, "%d\n", restore); > } > > static ssize_t config_keys_restore_store(struct config_item *item, > -- > Thorsten Blum > GPG: 1D60 735E 8AEF 3BE4 73B6 9D84 7336 78FD 8DFE EAD4 > >