From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 23C2B2E414 for ; Mon, 2 Mar 2026 03:28:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772422129; cv=none; b=ILFQXzaJ/VoItxxQ9+Q5Jyi0ciN3g3El33l+fsxx9OtUU9znvfgWFKhpL33dULQVD0e3mo3DPH1H1cw96FljhDpQv5g/6Vx0eY6gD/xqOX5+1+gBli/yuT4qwJmt3Z2KkH2RupRt8WsO1xSMgJP4YA2RKZacKwivYqc+U26Gbf0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772422129; c=relaxed/simple; bh=1Hg427PSHzI63xTYgHmo/lWiyjDtN6iFxklG6OF0cIQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=W1G8xXoD2aS+CE8cRghd4L9Y1nZqARlqGbZH3BEgWhAEN6PxiCJ0QY1JFYdrCzxOP43a3VkDS8RHOk+pUv6BpbwT6NQx4BmVgIyu18mh2zVAazUlMlo9jLSOcLH7itOPqiSmEwSIKVfO1LwioKpdZKavqnNzkeJX5WVRTlzmhrY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=deLlf06o; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="deLlf06o" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1772422127; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=cOdlrpYYSsiTQRBIydiE+e+REtytgUKUjuH+ZhB/IzM=; b=deLlf06on8/6yEaAslLPEVjUZIIFSZNjsnIOvxKIN7zxFgavG4tXoEEOP9E+jdnx4HeSqO IEh+GxScJ8NqGg5p9fKiPuPLD0FYaRSkRMD/LFpBJlOPwRAEHX76hLaA1oRPHU+WlJgARK c03kuub0baL9eA9SwtY4ZFMi/HzqW4k= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-665--51nVgoKMiCulfVoYC9wWw-1; Sun, 01 Mar 2026 22:28:44 -0500 X-MC-Unique: -51nVgoKMiCulfVoYC9wWw-1 X-Mimecast-MFC-AGG-ID: -51nVgoKMiCulfVoYC9wWw_1772422123 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id C15371956048; Mon, 2 Mar 2026 03:28:42 +0000 (UTC) Received: from localhost (unknown [10.72.112.98]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 5481B1800370; Mon, 2 Mar 2026 03:28:40 +0000 (UTC) Date: Mon, 2 Mar 2026 11:28:35 +0800 From: Baoquan He To: Thorsten Blum Cc: Andrew Morton , Vivek Goyal , Dave Young , kexec@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] crash_dump: Fix typo in function name read_key_from_user_keying Message-ID: References: <20260227230422.859423-1-thorsten.blum@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260227230422.859423-1-thorsten.blum@linux.dev> X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 On 02/28/26 at 12:04am, Thorsten Blum wrote: > The function read_key_from_user_keying() is missing an 'r' in its name. > Fix the typo by renaming it to read_key_from_user_keyring(). > > Signed-off-by: Thorsten Blum > --- > kernel/crash_dump_dm_crypt.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/kernel/crash_dump_dm_crypt.c b/kernel/crash_dump_dm_crypt.c > index 27a144920562..dcb69e96c6ff 100644 > --- a/kernel/crash_dump_dm_crypt.c > +++ b/kernel/crash_dump_dm_crypt.c > @@ -139,7 +139,7 @@ static int restore_dm_crypt_keys_to_thread_keyring(void) > return 0; > } > > -static int read_key_from_user_keying(struct dm_crypt_key *dm_key) > +static int read_key_from_user_keyring(struct dm_crypt_key *dm_key) Good catch. Acked-by: Baoquan He By the way, it's better to wrap these cleanup/fix patches into a patchset for easier reviewing and merging when you are exploring code flow of one feature/component. Anyway, thanks. > { > const struct user_key_payload *ukp; > struct key *key; > @@ -387,7 +387,7 @@ static int build_keys_header(void) > > strscpy(keys_header->keys[i].key_desc, key->description, > KEY_DESC_MAX_LEN); > - r = read_key_from_user_keying(&keys_header->keys[i]); > + r = read_key_from_user_keyring(&keys_header->keys[i]); > if (r != 0) { > kexec_dprintk("Failed to read key %s\n", > keys_header->keys[i].key_desc); > -- > Thorsten Blum > GPG: 1D60 735E 8AEF 3BE4 73B6 9D84 7336 78FD 8DFE EAD4 > >