From: Yao Zi <me@ziyao.cc>
To: Chukun Pan <amadeus@jmu.edu.cn>, dlan@kernel.org
Cc: alex@ghiti.fr, aou@eecs.berkeley.edu, conor+dt@kernel.org,
conor@kernel.org, devicetree@vger.kernel.org, elder@riscstar.com,
krzk+dt@kernel.org, linux-kernel@vger.kernel.org,
linux-riscv@lists.infradead.org, palmer@dabbelt.com,
pjw@kernel.org, robh@kernel.org, spacemit@lists.linux.dev
Subject: Re: [PATCH] riscv: dts: spacemit: pcie: fix missing power regulator
Date: Mon, 2 Mar 2026 05:44:50 +0000 [thread overview]
Message-ID: <aaUj0tmD74VmQoG5@pie> (raw)
In-Reply-To: <20260302030511.30566-1-amadeus@jmu.edu.cn>
On Mon, Mar 02, 2026 at 11:05:11AM +0800, Chukun Pan wrote:
> Hi,
>
> > &pcie1_port {
> > phys = <&pcie1_phy>;
> > + vpcie3v3-supply = <&pcie_vcc_3v3>;
> > };
> >
> > &pcie1 {
> > @@ -320,6 +321,7 @@ &pcie2_phy {
> >
> > &pcie2_port {
> > phys = <&pcie2_phy>;
> > + vpcie3v3-supply = <&pcie_vcc_3v3>;
> > };
>
> ```
> &pcie1 {
> vpcie3v3-supply = <&pcie_vcc_3v3>;
> status = "okay";
> };
> ```
>
> According to DT binding, the vpcie3v3-supply of the &pciex node should
> be moved to the &pciex_port node. This is simply a duplication of the
> property.
>
> But do we really need this pcie_port (PCIe bridge)?
This schema is required to be taken during review of the PCIe driver[1],
and it should be the future way to handle Root Port specific properties
through pwctrl-slot driver instead of the host driver.
> The PCIe bridge node (pcie@0) was treated as a platform device, but it
> did not define the interrupts property, which resulted in the following
> warning: `[ 2.897980] irq: no irq domain found for pcie@0 !`
>
> Would it be better to submit a patch to remove this pcie_port?
Thus I don't think it's a good idea. We should go back and investigate
a proper fix for the irq domain problem.
> ```
> - ret = k1_pcie_parse_port(k1);
> - if (ret)
> - return dev_err_probe(dev, ret, "failed to parse root port\n");
> + k1->phy = devm_phy_get(dev, "pcie-phy");
> + if (IS_ERR(k1->phy))
> + return dev_err_probe(dev, PTR_ERR(k1->phy), "missing PHY\n");
> ```
>
> I have tested this change and it works.
>
> Thanks,
> Chukun
Best regards,
Yao Zi
[1]: https://lore.kernel.org/linux-pci/u53qfrubgrcamiz35ox6lcdpp5bbzfwcsic466z5r6yyx6xz3n@c64nw2pegtfe/
next prev parent reply other threads:[~2026-03-02 5:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-26 8:17 [PATCH] riscv: dts: spacemit: pcie: fix missing power regulator Yixun Lan
2026-03-02 3:05 ` Chukun Pan
2026-03-02 3:36 ` Yixun Lan
2026-03-02 18:11 ` Conor Dooley
2026-03-02 5:44 ` Yao Zi [this message]
2026-03-02 3:10 ` Yixun Lan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aaUj0tmD74VmQoG5@pie \
--to=me@ziyao.cc \
--cc=alex@ghiti.fr \
--cc=amadeus@jmu.edu.cn \
--cc=aou@eecs.berkeley.edu \
--cc=conor+dt@kernel.org \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlan@kernel.org \
--cc=elder@riscstar.com \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=pjw@kernel.org \
--cc=robh@kernel.org \
--cc=spacemit@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox