From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D45EE38D006 for ; Mon, 2 Mar 2026 09:09:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772442590; cv=none; b=ZqP7ow4ffULXx7EQ5s1KIW0QvCLGsALYN2y/hb96m1Yk4ORviMbxAqeVYGTt4iOvymKkl+rnYQGVwCSWAbJX8/6VINP7Sc8+6TygKPOYu61+0Ad24XaAINgH+SwsVxZ7z9H2fXtJb8zvxqrqPjIBqj6rqK+bvESmGJTnKWkkvCc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772442590; c=relaxed/simple; bh=qjkP/1+k5cq3RnMIRwB1RFWNDwXgn5pOPZDVEw8Wa/Q=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=HJ6kxQfAManZyiUxKdPx4fApzkcRPSZjYC6eME9lgMdtC9IPBmcTEUcD8H1s2qmHMTjTrAUT6ZBpbEWrMTZ0mVhyer4hbZ6tqucKX0pnB9dYnNZVilfDSAvtYkXH3+bVfJMecpJg/uCHsdjTdS6+GSeRl6WNCxXp1YTW9l1kQac= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Vi5Yxi4E; arc=none smtp.client-ip=209.85.221.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Vi5Yxi4E" Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-439b97a8a8cso497025f8f.1 for ; Mon, 02 Mar 2026 01:09:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1772442587; x=1773047387; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=H7hSkAEy5QMDiomw3PMMxDywDx0o6+q0SZ4BtDXuEqI=; b=Vi5Yxi4EZTypeu3vPjym2SbWqIf3NmzTxPUvnuyaXmODMDPVP9jm3nUraKNw7cSTUM nkhnKBdf/CJWwAC8gMX9/ZdHgLiJHmG3lHIrthsqA1uJgoLFVUi7UfHtWzyJHPMwF+qZ 9DKpycYJgv75XSg+NbxS3Du33TipmnK/5MmUXPKeUgOZedy4zAlVsaOtPAEnkVay2kIm ygBdfP/GTJeo0vKZSUbcusl7Aox+fvyTr6/yfNxlN/CH3Y3oO0QANm5ZHGcQE6V99VF9 Mqv9Ajvstlk1qhh7GEBM+zu3McZ6kScYtjTNg4HJciigRf9vFUhB6a/iIImasRmDRIyi i9NQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772442587; x=1773047387; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=H7hSkAEy5QMDiomw3PMMxDywDx0o6+q0SZ4BtDXuEqI=; b=g2NLI3AQxt54EvSZL+paeF4smezwVQrSZ7x6XborxnKUloflwiKjPzjUak4WWbEZ9k 9vsEQNOpvsCFhv1kV6pIyuO1dD8XJHU14opjctS74+lK8XddsKl5OuF3uOT3tG0nCVMv W1omS4Qr3crPyhdM7O5lKx368OrNhlv7U4/9R4r5/mhLwRnYqv/gN1s96/PkoY0vfz7a 4XXgYEvfqEQLwzpPmS0eXP/8A8iyNaWhehPkem2ojzwUbjV/u/QT+d3gwdgTxJXQdObI jphvov6tKqt9onsikQKYRzsWaFdjr6f57roMPBsIIa6veqLLYgH4oZ0XHr567YhqMZz6 TS5Q== X-Forwarded-Encrypted: i=1; AJvYcCVzRpC7YcQuB+1uq99BL5vQneXOtHasaig32aYf1aHuANENBAZefCovoSE9fuy+h15nZILu8X5AfGwhrF8=@vger.kernel.org X-Gm-Message-State: AOJu0YyQapqRvOPUuct5h+ZywhUO9yOm72P/o9Vh1jw1YEO4FOKYOE2i MVWYikLlPoa4sO5N+WasoIukYNpTV9a8lAKDgwSCAgcWpIOkFhPfeldq+QWQTT+jMAU= X-Gm-Gg: ATEYQzyQZF+wq3upA0kU+Nc+I5xEV7DBKLkqHB1d38oDzJKcAuK4sTnGqrVRvUL+oSP bDixTuep+j/slqHuZpsTr3BMEA+VWCXLYicCiHFVs7BnWjeFS3JDFsUuWpp1T9px4yFSeNgVO9f 6QUpoOlDLjbvvw7KAzGuPyEfAqeHMaKLUxaR/Pc9PwO20wx/pcxnrd9xX1w3U2F5P1QbKxEOKiy IjnsW7ch8p75O3fZ7Y01XGdXdr1zxRqhPZ9BosJ5GBF/qlOq4OoXiORm6MrdluvBLbYNFeLjZnZ nB0nGkNJ4kKEGeGPE9PaNegfpHQ2r5qgVjHD29cnQv1rtiKH0k3dreTo3/aEpBec3Q2z+EPtAO8 NLIqA8Bokl8dOaOnQ/b2kHJlJr9tHDDvnf2szb6n1ayGEttKDgetaLjmTGgmXGjBggfDxEsRPjR 4YGC8xskLHoIqsOESgetSRM08F6HFegb04zO7az5A= X-Received: by 2002:a05:600c:8106:b0:47a:975b:e3e6 with SMTP id 5b1f17b1804b1-483c9bbbdfamr201030975e9.18.1772442587203; Mon, 02 Mar 2026 01:09:47 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-483bfeca99asm123479625e9.31.2026.03.02.01.09.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Mar 2026 01:09:46 -0800 (PST) Date: Mon, 2 Mar 2026 12:09:42 +0300 From: Dan Carpenter To: Soham Kute Cc: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com, gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: sm750fb: use proper error codes instead of -1 Message-ID: References: <20260301051434.28187-1-officialsohamkute@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260301051434.28187-1-officialsohamkute@gmail.com> On Sun, Mar 01, 2026 at 10:44:34AM +0530, Soham Kute wrote: > diff --git a/drivers/staging/sm750fb/ddk750_swi2c.c b/drivers/staging/sm750fb/ddk750_swi2c.c > index 0ef8d4ff2ef9..d90a93ab8fdc 100644 > --- a/drivers/staging/sm750fb/ddk750_swi2c.c > +++ b/drivers/staging/sm750fb/ddk750_swi2c.c > @@ -294,7 +294,7 @@ static long sw_i2c_write_byte(unsigned char data) > if (i < 0xff) > return 0; > else > - return -1; > + return -ETIMEDOUT; The comment still says this returns -1. Actually could you do this one function at a time, and in each commit message please say "The callers propogate the error code back" or " None of the callers check the error code" or "The callers treat all non-zero error codes as failure and return -EINVAL" or whatever. > @@ -264,7 +264,7 @@ int sm750_hw_copyarea(struct lynx_accel *accel, > (sPitch / Bpp & DE_WINDOW_WIDTH_SRC_MASK)); /* dpr3c */ > > if (accel->de_wait() != 0) Did you consider propagating the error code from accel->de_wait() instead? That feels like a better solution but I haven't looked at it at all. regards, dan carpenter