From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B6ADF1F2B88 for ; Mon, 2 Mar 2026 09:17:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772443043; cv=none; b=lVCGtqC536AOhT7JTxO9v+qk25ldK/Tf/yPiEXLkeiddJLlJujQtf0pVg1/7DgfSaMcQm35iTAUiH1whw4anmQrRNrdbqYVJo/9cXVSSszcAyrHjs4Fp10OMKuimn+1BL70ZpojJqTwMidZzEpzjsXAcrsKNyGbqk33ZidUzvFg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772443043; c=relaxed/simple; bh=LVsxGHeBLqDZ5yfFpjMyLx6NQez1ggO7qAfrAEFa3Ss=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=C97AW7HIFQBocTk3eN3ekbJFviDwsQKCKi7XIVWYIJjGIJXuCv2DK/OCWkfGmWXD7X0ptyCuBFAPEK5o+4vsLYBhve8KNXxicy5moRgnXredBszKc/o362dz1j7TXT8q04g45G8uF3roLQIdUrptJWKnfAeaN9AQbkmQg3kh6X0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=dE7d21AS; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="dE7d21AS" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-48372efa020so34702075e9.2 for ; Mon, 02 Mar 2026 01:17:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1772443040; x=1773047840; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=7k1/JqAQLfuKcHJQtEmCDAzH8XPsDa64NhYKDA0/NyE=; b=dE7d21AStY+i+Nptq5uwnx3jUZbGb3m9FB4SBY+XLUfFtG+djeCB7FXyF0HmA+gxEp TXZEvgPdV2SkHCl14moe2KOKrrGBwQRHq9Mql/TKjRoJCeIfWVOi7o2ddE41FadYevv4 VEew9gkIQZaHJpgaQcXJ2bggUSyvUhfdtZ471WuBz0LxThuSHmE+WesZ3X1jhS12V0Y7 Ueb876g2tr2eRVSu5HYBfb5HH4s5HVqlOpVyLd8I85rUboORTB7Iz4Vvr6/LH19bHctp SksOv5c6MaBk5NIdJFh0CefmArbF8sWHvShCurNDMbsGF/TPpm4HenY57VRQBdLj9wCP vGhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772443040; x=1773047840; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7k1/JqAQLfuKcHJQtEmCDAzH8XPsDa64NhYKDA0/NyE=; b=MQPeNvmTXGUUHxjTpzkFaLPOQHMwd3PFPsT9m7swZ8wGrxAdBn07McfOEPdicb+pGc KAc41smEuLItLZ51r0/CRt3VoxeZ0YFXHaFMGWIpBC/iFLywpbAaJarxMlZ7wX4s46ES 8kKoWl03rHyhRsqBjkNlZQN1xOSvdDDi28Q2LLn6gRfmdRhSLfYP7ZZUFXY5wDPWcc0o BPUp2RybaYTWkqY4E3kW6+SVjts4QaGCnmmiMS/8Kg7HheQHtPsUlPEjUmxxpqrECTdp 60ieTkAMozg9glHhPCg0vutDVlic5rjcjw/sTf12UfUTfMQU+FHQKRqKc5hL8m0qW7va AmQg== X-Forwarded-Encrypted: i=1; AJvYcCXVeETUAC0qrulHOiA3zORs95Wsx54d+5DM38cyTfmrJczFKKch9t1La9Ho1tT3NeVDzbM1Q7psfJ/HJEY=@vger.kernel.org X-Gm-Message-State: AOJu0YyaR45IutYz+NxDuJ6+XHZvJgIluzN6SXfUB4Se5s3/AqdBiKt/ PODm5ZGXTzvdjUBo/sH/ej19mgo4a9Ri8JRjfjewtqAOLbL7QNqoiZ5TEKMR6rvDnBU= X-Gm-Gg: ATEYQzxuTfF02luJhQk7aapFne33Wtp9dHKyuW1Rjb1epEr4YaCR2Xj+dVkTSZBZhdP 3PANjAHckcgsRFcaEaTB3Ebx1Y2X6xbLZZajTYmuhg9lABpkWJE+P6ZbFSph8FGmHzU4F5J+EQn PhS6T7HYSZcxGyrwOnctgGzDM3GZXN5R3s59Mvr6r1fyciy0a7PHwUmfOSfEVn80UhgR4DAQKef d6o3zvwOfyry9k0e6R1MCBngYgjxjhBj1ZJlDCY3ar6n9UqVZE4kruRyunre/gHwSwjo9LrQTEU oHS7kFzOeuA1ms1x2+TFPT9f3OZgXrXIifgHKPFRJWHNeoNO+/QlzEDNVMxmJkdxCqPd64Zbdzm clVDS2dWBZJRlhkSeFryLtettRZRe9QTGrR+V0p2mkP04ZoJ7jTtYBp5ap4ve9/jGphVSEKQFt3 mgNbqXaoEqD5Dknnq9HyADWWVcu7cf X-Received: by 2002:a05:600c:3e86:b0:480:6941:d38b with SMTP id 5b1f17b1804b1-483c9c1bc0bmr190909605e9.30.1772443040055; Mon, 02 Mar 2026 01:17:20 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-483c3b770c2sm264346215e9.10.2026.03.02.01.17.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Mar 2026 01:17:17 -0800 (PST) Date: Mon, 2 Mar 2026 12:17:14 +0300 From: Dan Carpenter To: Josh Law Cc: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Josh Law Subject: Re: [PATCH] staging: axis-fifo: remove redundant goto end Message-ID: References: <20260301005019.2510157-1-objecting@objecting.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260301005019.2510157-1-objecting@objecting.org> On Sun, Mar 01, 2026 at 12:50:19AM +0000, Josh Law wrote: > Signed-off-by: Josh Law > --- > drivers/staging/axis-fifo/axis-fifo.c | 17 ++++++++--------- > 1 file changed, 8 insertions(+), 9 deletions(-) > > diff --git a/drivers/staging/axis-fifo/axis-fifo.c b/drivers/staging/axis-fifo/axis-fifo.c > index aac2c58ef9b3..d83a0fd5b231 100644 > --- a/drivers/staging/axis-fifo/axis-fifo.c > +++ b/drivers/staging/axis-fifo/axis-fifo.c > @@ -395,22 +395,22 @@ static int axis_fifo_parse_dt(struct axis_fifo *fifo) > &value); > if (ret) { > dev_err(fifo->dt_device, "missing xlnx,axi-str-rxd-tdata-width property\n"); > - goto end; > + return ret; > } else if (value != 32) { > dev_err(fifo->dt_device, "xlnx,axi-str-rxd-tdata-width only supports 32 bits\n"); > ret = -EIO; > - goto end; > + return ret; Just return -EIO. regards, dan carpenter