From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4BC5938E5E1 for ; Mon, 2 Mar 2026 09:50:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772445012; cv=none; b=V8Y+QwEOouWZEbr73jmI9HqDYmVStLjHvfPFt4XKQzl6iGBFaEjHJKPofZZgQ49Wf/67+NVHWTThBU1Np5pLDWKtxcf0/UE88ZXJRN3Gx70W8rNXK3oQYcomzYbXMmuVmBLFHftv+kxI8fl8bcHamCJ8fhoFHt6GqRLCocDdKiw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772445012; c=relaxed/simple; bh=40qwCnqz+wEjM/IhhB5z6vQ43MV8x6Zl2HZJnHwNqcQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=bcx+iyjnVhXugHrJdxc0Z2ACHXdpue6OO1Xgo37D0C7h2TcSO42GRz9ZUVxa/MA7JuotmjTv1ThJRpKhKxegAKZJV5AQbxvWhxRmprAPlluRlWBUEVlV7QOAqqs7LjvmSG4GqC1E9W4iN919cRBFacJYQyDCnqEWWJUC5a8yCFY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=OIzRQTqF; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=hQN/QwEc; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="OIzRQTqF"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="hQN/QwEc" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6228JDH33224157 for ; Mon, 2 Mar 2026 09:50:09 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=QRKxM/P9l/2Z1hR6WxyeRaZQ 55JcQ9u9VYXCLMJIR1U=; b=OIzRQTqFJipxKuT+C6DHeqrfvDJYYRPlB/CM+r1w 6T6L55qjSbNMz9tX0sQdtFbked9kH0Q1OSGmoeskImmKnZvdLAhehs50qRTihjwP jsUcf9dniYuepWQIeWEc/pdLT94X2mrrOP6TRIg1T6CIzzm3w7EwgW1NELDImI2U wlNUc1krHXfqFLMkIZ1hSGwNc+FIHN/2kvvwi/fQ3b7HHN0j8TIr8VIgwWPjr/uN BXuT5dnhDVwtD9/5mGcm8E9TbpgfdkQLiTD7nIZlMF5JKxj3qRZw7Xicpz2y1t6l vowH+8dS/EKVvpvJ75MdqGY1zJDQCKLfUOZqaiZn38Bi8Q== Received: from mail-oi1-f197.google.com (mail-oi1-f197.google.com [209.85.167.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cn0b1hmnk-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 02 Mar 2026 09:50:09 +0000 (GMT) Received: by mail-oi1-f197.google.com with SMTP id 5614622812f47-463a075e177so22010647b6e.2 for ; Mon, 02 Mar 2026 01:50:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1772445009; x=1773049809; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=QRKxM/P9l/2Z1hR6WxyeRaZQ55JcQ9u9VYXCLMJIR1U=; b=hQN/QwEcgHXhK1TP1ldOTFUDCEqiK/JS4FN0Nvl2eVVtHLkyjOlK4UAX3LB9s6cNAl 8jh2phtxRjAbLcapKCtQPTBu5xiNDKTHlGahnKuZ/Hag8ZODhRdw/b6ixSzAf4bnZTce EqOCaZ9FeRbiszGOZDAAYqnyuQSB0l7xPd/T6LLSPOqnjxrU6MZYUBhzEVZzVePCKVbR B6n31C/nHAFtUaTvBpmsCAlJgRmFioKJQk3EWVmb7J3xXJ++BrFsGxOJFYHnb1qtFrrj IKr2yJE+GvnWJLvqzJDb6/42V84bU0cAZ27uShxXgsh6mBzbmiFo2BqZHE/KrzzJCXFn AttQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772445009; x=1773049809; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=QRKxM/P9l/2Z1hR6WxyeRaZQ55JcQ9u9VYXCLMJIR1U=; b=t94FOxu9UvAuEChV2JlZgmoVWlmnSLiZJJBBHYJywBzGFFSIXwzc1CgfwK22ViuAk5 Fw2WOhmlSwwYr8kY+oDXQSfgKiUKEGvVPBhHiGGuigbJ8uL/bI1sI3LEi6S9upYrMeOz pOBoJtl3hSN5yuZhsXkvvI8Xkm1AUPen3udM7xXqAqMifsUBgz0qH6MEYdFBj82blMJB rSwXvdSUxBzsxN677Y6/vO2wwGNxkGzA8TVdCsFON122XO9dri9CVvWfP+L1qbMIQCEA wEbKzuqbMdgJJ5OjWCxLgX1Wslfw+rE1ZZShLZg9bkqq4bSKDr1BxVqFLAVmk3wn/sIG NP+Q== X-Forwarded-Encrypted: i=1; AJvYcCU3KaT0AmVyW7EHrfiZrSGuqPJf4NqR/clD2t6NUQnAXXOQCPR6YUSYAIsXtS/NXYaBHy9kPSL+5AYZpx0=@vger.kernel.org X-Gm-Message-State: AOJu0Yy3mhTkiSTjLnznFTLn82BSgVa7TUvgGnJWEqQn9hhPExW1ZwNC nOaSqcJJYR/1dccEiw07eqK9E6zv2+F0rlmKaNpCR0pYsczb9UbcCwIgrcE/Je94e0hNEel6Xi6 Ahkq9cprs0qPIGnn9cDYpbGVUkkhsc8ZpnimOkm3Ld8uw4j6wPvdkhNivHGaocrdoqbU= X-Gm-Gg: ATEYQzwGV9nYldIFJJ03U1Ec2VAeVl1va1cx1hbBGl5W+kAxyzuZlgXzuIh6EwiK0f6 Zg/60AQEZz4nN4lOSmtIaNJ/rx4+g3iNtvKhQMvoZXK9G+dSIeG/RIOm8Y5sWwikkMUFsCwQbSo Ib0lcFD8FWTQDNZvo5wK8DBFEllq9XJAZM3u4QzCcErYJFtqEQWNpAuKChCZ8HT/e7n8Eo9ikmc t0CbDzVg5ILjWHU/3Wn9sFBpdaLG5MjhdMNtekaB5zsxZaPUsKAnn71TJ+5ycbZJ3DTTbAVkuDy 5ftCeJI6YGqDSviuK1cNUNrkIKKcghQBoLGVVxN2r54PAd1QxcjvTsr3Lqce7JZnA8Bbay9YY9u /J/I8t6QPadbtyB40F/RRoeZax8eTHcEoYzgE/Y4vXc0xHeYlJ6Fc9DH0C57HmnZp3ekGV2Gwge kPGvzm X-Received: by 2002:a05:6808:1705:b0:450:b7a0:41ca with SMTP id 5614622812f47-464beceb57cmr5117091b6e.22.1772445008440; Mon, 02 Mar 2026 01:50:08 -0800 (PST) X-Received: by 2002:a05:6808:1705:b0:450:b7a0:41ca with SMTP id 5614622812f47-464beceb57cmr5117069b6e.22.1772445007942; Mon, 02 Mar 2026 01:50:07 -0800 (PST) Received: from hu-ysakshit-lv.qualcomm.com (Global_NAT1.qualcomm.com. [129.46.96.20]) by smtp.gmail.com with ESMTPSA id 5614622812f47-464bb59be78sm7391540b6e.13.2026.03.02.01.50.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Mar 2026 01:50:07 -0800 (PST) Date: Mon, 2 Mar 2026 01:50:04 -0800 From: Yuvraj Sakshith To: "David Hildenbrand (Arm)" Cc: Michael Kelley , "akpm@linux-foundation.org" , "mst@redhat.com" , "kys@microsoft.com" , "haiyangz@microsoft.com" , "wei.liu@kernel.org" , "decui@microsoft.com" , "longli@microsoft.com" , "jasowang@redhat.com" , "xuanzhuo@linux.alibaba.com" , "eperezma@redhat.com" , "lorenzo.stoakes@oracle.com" , "Liam.Howlett@oracle.com" , "vbabka@suse.cz" , "rppt@kernel.org" , "surenb@google.com" , "mhocko@suse.com" , "jackmanb@google.com" , "hannes@cmpxchg.org" , "ziy@nvidia.com" , "linux-hyperv@vger.kernel.org" , "virtualization@lists.linux.dev" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v1 4/4] page_reporting: change PAGE_REPORTING_DEFAULT_ORDER to -1 Message-ID: References: <20260227140655.360696-1-yuvraj.sakshith@oss.qualcomm.com> <20260227140655.360696-5-yuvraj.sakshith@oss.qualcomm.com> <571547b0-007a-4cf9-be1d-95a0ef871cf8@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <571547b0-007a-4cf9-be1d-95a0ef871cf8@kernel.org> X-Proofpoint-GUID: WTMoZgnO0JHBdDTogBtGl65v7uKy-5J9 X-Authority-Analysis: v=2.4 cv=Hol72kTS c=1 sm=1 tr=0 ts=69a55d51 cx=c_pps a=WJcna6AvsNCxL/DJwPP1KA==:117 a=ouPCqIW2jiPt+lZRy3xVPw==:17 a=kj9zAlcOel0A:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=0mXQa5sO9039VI3KVg8A:9 a=CjuIK1q_8ugA:10 a=_Y9Zt4tPzoBS9L09Snn2:22 X-Proofpoint-ORIG-GUID: WTMoZgnO0JHBdDTogBtGl65v7uKy-5J9 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzAyMDA4MSBTYWx0ZWRfX0o7pUrDTvkQi ESZ0Ti8Ic5Lz+xxCNz2uLSQ7EJQOuDisFTgnc82xzblnV9AgfESqOG8T13J6aO63dY1qNs9ws+h N+ggdpTufeEx9TjHlwUzuwsGBLAJbDBU4/iqfaLfmKpHAgP2V5X2RD3IU1nWOSQooVd9t9nzNO2 13SBlT6CyJpKIiosSi7iwUweHEf7mjXdyMsxiuIEY3RvdDLncO3HupcWU9TRLdUN9ZYj1+T+lbh Dr4li8bfWPPAjeei9LfmR+lkLiV10IUCjUsCn5N3xo9sXsi4D6kyB+tXFDRYZ+0Vg1wr4RK/h6r DQBTGPiY8dX0PpNirARFwg8KRjDQiglupKkBG3ZgIdi6zTXcmkNqf62qcPeW1TcN97EYajfqqlK hHPcskmzYvvnJr85PVXTxs4v+HU7fAHd+zpcqKLpdA1OwU68aJh4u7OH9CHut+2ZZtWxwiREAVF lYFjI8UAm12SYYvlvXA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-02_02,2026-02-27_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 impostorscore=0 malwarescore=0 adultscore=0 suspectscore=0 lowpriorityscore=0 phishscore=0 priorityscore=1501 bulkscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603020081 On Mon, Mar 02, 2026 at 10:18:23AM +0100, David Hildenbrand (Arm) wrote: > > Great. Much more clearer on page_reporting.c 's end. > > > > Don't you think on the driver's end: > > > > prdev->order = PAGE_REPORTING_USE_DEFAULT; looks clearer? As compared to: > > prdev->order = PAGE_REPORTING_ORDER_UNSET; ? > > > > I'm thinking, why would a driver worry about page_reporting_order being set/unset? > > Maybe PAGE_REPORTING_ORDER_UNSPECIFIED ? > > In any case, we should use a single flag for this. Everything else will > be confusing once drivers could use only one of them. > > -- > Cheers, > > David Sounds good. Thanks for the suggestion. Thanks, Yuvraj