From: Peter Chen <peter.chen@cixtech.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
gregkh@linuxfoundation.org, pawell@cadence.com,
rogerq@kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
cix-kernel-upstream@cixtech.com
Subject: Re: [PATCH 1/2] usb: cdns3: Add USBSSP platform driver support
Date: Mon, 2 Mar 2026 19:05:25 +0800 [thread overview]
Message-ID: <aaVu9VGSZmCcaCAB@nchen-desktop> (raw)
In-Reply-To: <20260302-brave-cockle-of-bliss-a8dde5@quoll>
On 26-03-02 08:31:57, Krzysztof Kozlowski wrote:
> On Mon, Mar 02, 2026 at 11:03:33AM +0800, Peter Chen wrote:
> > - cdns->gadget_init = cdns3_gadget_init;
> > + if (device_get_match_data(dev) == &cdnsp_plat)
> > + cdns->gadget_init = cdnsp_gadget_init;
> > + else
> > + cdns->gadget_init = cdns3_gadget_init;
> >
> > ret = cdns_init(cdns);
> > if (ret)
> > @@ -317,7 +325,8 @@ static const struct dev_pm_ops cdns3_pm_ops = {
> >
> > #ifdef CONFIG_OF
> > static const struct of_device_id of_cdns3_match[] = {
> > - { .compatible = "cdns,usb3" },
> > + { .compatible = "cdns,usb3", .data = &cdns3_plat },
> > + { .compatible = "cdns,usbssp", .data = &cdnsp_plat },
> > { },
> > };
> > MODULE_DEVICE_TABLE(of, of_cdns3_match);
> > @@ -336,6 +345,7 @@ static struct platform_driver cdns3_driver = {
> > module_platform_driver(cdns3_driver);
> >
> > MODULE_ALIAS("platform:cdns3");
> > +MODULE_ALIAS("platform:cdnsp");
>
> You do not need this at all. Fix your DTS or platforms or this
> driver.
Yes, will fix it at v2.
--
Best regards,
Peter
next prev parent reply other threads:[~2026-03-02 11:05 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-02 3:03 [PATCH 0/2] usb: cdns3: USBSSP platform driver support Peter Chen
2026-03-02 3:03 ` [PATCH 1/2] usb: cdns3: Add " Peter Chen
2026-03-02 7:31 ` Krzysztof Kozlowski
2026-03-02 11:05 ` Peter Chen [this message]
2026-03-04 23:07 ` kernel test robot
2026-03-04 23:29 ` kernel test robot
2026-03-08 11:38 ` kernel test robot
2026-03-11 6:52 ` Pawel Laszczak
2026-03-02 3:03 ` [PATCH 2/2] dt-bindings: usb: cdns,usb3: Add support for USBSSP Peter Chen
2026-03-02 7:28 ` Krzysztof Kozlowski
2026-03-02 9:21 ` Peter Chen
2026-03-02 9:27 ` Krzysztof Kozlowski
2026-03-02 10:59 ` Peter Chen
2026-03-04 10:02 ` Pawel Laszczak
2026-03-11 12:02 ` Peter Chen
2026-03-12 8:07 ` Pawel Laszczak
2026-03-02 7:29 ` Krzysztof Kozlowski
2026-03-02 9:33 ` Peter Chen
2026-03-02 9:03 ` Pawel Laszczak
2026-03-02 11:04 ` Peter Chen
2026-03-03 7:34 ` [PATCH 0/2] usb: cdns3: USBSSP platform driver support Pawel Laszczak
2026-03-03 10:54 ` Peter Chen
2026-03-04 8:22 ` Pawel Laszczak
2026-03-04 8:31 ` Peter Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aaVu9VGSZmCcaCAB@nchen-desktop \
--to=peter.chen@cixtech.com \
--cc=cix-kernel-upstream@cixtech.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=pawell@cadence.com \
--cc=robh@kernel.org \
--cc=rogerq@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox