From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3BBEA2E265A for ; Mon, 2 Mar 2026 16:27:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772468823; cv=none; b=XHzCaNEsDBTF7ithFQRgNEepO0VKKOiBgQmqdrDzJ8uX7noyybqxbh3CzasXcEdsZ/M8L/+uBOJHjq+A0Rl05AKF6QaKWHiF8exkoeZnaeVEnEajbfnjM1J2TgSDNiuD3LyQLDGIO9Jw2vGPAFss4tAQenYls2c6knpeFzg9/X4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772468823; c=relaxed/simple; bh=OIdM+hAmjwuyD2yXHwE7YPVuQZY1XrqWsaUGDBqqx2Y=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=LQi2xUy24RxzYxS02WdV/9nMhS2lri9aeHuQf1QpjK5e4j7rLAKcQ9HpvbKyPab7i+RXqRXG1/SZe5oo6dY4OtHtbJb87aBPDcK88sssfzTAA/t+Sau9793+f/64p0QtvlcMy4rJAxBZte/g9zFCCdAUyvXS+Owqb+oi/xGr/kA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=KmfGYhM9; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="KmfGYhM9" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-4807068eacbso38706605e9.2 for ; Mon, 02 Mar 2026 08:27:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1772468820; x=1773073620; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=7UE1GGVwWJfObl7uKLI6Yeo5E4IPeQzQFVK8w6lFswI=; b=KmfGYhM9pB75khHuA9ae7VZKF5DPw1ff51ZP7J/4ADrxWDauVFkreAU34Xb5HJVcgQ KJbOfqCO33XiyP64dEydE/c1DnViql52muoMXu5rrwXQ0bm8y44VwEz0WgggkQgGw+St h1mvNW9F+KInjbZWESiZF0R95pMWZ5BVXkoBINRWqnpG6M2CP+DPn6lrPMwMCUA1SYZV ETRnO6fYdLWiEKwErlCGfvwDYXj1dTzpJ61b5jVjiTCCRIiYmUAVAH50W//IHOova4mf qXtuI5JejfhVG/Z+9UTVPQBRW+X7HwLqJyrFST+dadWKjMJQFFHIEhZAEdL7xGYoTMTG 8S2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772468820; x=1773073620; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=7UE1GGVwWJfObl7uKLI6Yeo5E4IPeQzQFVK8w6lFswI=; b=O9pSmiw5jVt7cKD5ZZnlVRoc9NociOA+v5Doc8M95N3sChQWDZD8j6IeLg+arxTd8m I1G9tkfqvMidJc5CZTa/POTd3KKjuBa/5J5sD9dqbUkGw84UJ16jfvXiNhBL1AjSnjxO mlgYVe0Q8oi81FqBY09q1xP1vybdo/4Y3KM4Tj7RJyhaWLw5dKq1tyUhCfbIDwGXac7/ VLB+n2VBPxfg1XZ5+fAF/YipbhPFo9anp1+66ZOMHX8v0uesl9CtxZxCiUUIwn8iGRSd HZZvTjd+KhGz3hM28J8p/SiVxGNKnlD9obngRa5Py7R3dK5Y37CSrHUAjuSHhjxZjPv9 F/Eg== X-Forwarded-Encrypted: i=1; AJvYcCUcRbvmxVG986udrAKrRAX9JEB67sYYrEYbvkiu8tU7qUFpAGEKV/nAOKUTpzNg7QSaee7taR5H3KQgm8s=@vger.kernel.org X-Gm-Message-State: AOJu0YxahEZ/gI+UjXvyifGeY4nF3Clu0jnjol0h55CHHYfYavuYQime a9p8+7jVwFLc4poLhFs8O2d4jhGcCC1/Jrs24KiKhVMtvhkBcAtVmcOXtF3CtEFYPW8= X-Gm-Gg: ATEYQzwdb2LO++Z5yLhZ2kHXfYpFE6o4BzlaGZXCBKFvQOuEHP1it8dClxr4MeW2OLr W33s0SaELPYOi+TQjCaZvNe1YPrM7NOLVoMmSJLK+5UTpKgO0N/Gi49rnjvp524te0TXlq+utq+ 5dwBs75jzUD1s4633mJs18j1fwkiZsZkAziuOlH1B7eqMvjdESlDjZvvcFRNkgVQ0UrOnmyN7a2 8ooBixqD3S6LOkuqNPoDMvQvI/rfpneuI5NCtjvO7SN92y0yIZuq2T4xu0ltRnSIDhmvakZU8e3 FA+zpM+V/KgnW1vSulnKX3f3iAb13geTwQ0seS7wy8AXHFrQvZL55Dsro0JcmEHN8pgEzLG79NL ElA9NrkG4HZYdULqUfZFE+h/0WlUYYZOtVuYBM7+Pb3cTDsGeUt9RHSvwXtnnANW9B3vXSLs4rY n6I10axKLbodvKbeiqgPf13zFG3/bkxJhc/ZCK X-Received: by 2002:a05:600c:4f11:b0:477:7925:f7fb with SMTP id 5b1f17b1804b1-483c9babeaamr244554505e9.10.1772468820507; Mon, 02 Mar 2026 08:27:00 -0800 (PST) Received: from localhost (109-81-20-148.rct.o2.cz. [109.81.20.148]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-483bfb8724bsm170155795e9.11.2026.03.02.08.26.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Mar 2026 08:27:00 -0800 (PST) Date: Mon, 2 Mar 2026 17:26:59 +0100 From: Michal Hocko To: Kairui Song Cc: Yafang Shao , Barry Song <21cnbao@gmail.com>, lenohou@gmail.com, akpm@linux-foundation.org, axelrasmussen@google.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, weixugc@google.com, wjl.linux@gmail.com, yuanchu@google.com, yuzhao@google.com Subject: Re: [PATCH] mm/mglru: fix cgroup OOM during MGLRU state switching Message-ID: References: <20260228161008.707-1-lenohou@gmail.com> <20260228212837.59661-1-21cnbao@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Mon 02-03-26 16:00:03, Kairui Song wrote: > On Mon, Mar 2, 2026 at 3:43 PM Yafang Shao wrote: [...] > > > To be honest, the on/off toggle is quite odd. If possible, > > > I’d prefer not to switch MGLRU or active/inactive > > > dynamically. Once it’s set up during system boot, it > > > should remain unchanged. > > > > While it is well-suited for Android environments, it is not viable for > > Kubernetes production servers, where rebooting is highly disruptive. > > This limitation is precisely why we need to introduce dynamic toggles. > > I agree with Barry, the switch isn't supposed to be a knob to be > turned on/off frequently. Is there any actual usecase other than debugging to switch the reclaim plementation back and forth? In other words do we really need to care about this issue at all? Is the additional code worth it? -- Michal Hocko SUSE Labs