From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.ilvokhin.com (mail.ilvokhin.com [178.62.254.231]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E2F302DC77F; Mon, 2 Mar 2026 15:23:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=178.62.254.231 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772464982; cv=none; b=mgn4ZOnh0/kJZnLWOuf0mIIHaU33hXBQIC+zdLCTOt9JDdwytwj4eoAogjpJFylO7uizf6Ex8jhRQeSSTRa4WSGgFJxguVzffZ4lIAPco3P6XA7TpliiSL0zpZBjJCTKdBkh3zT/ksoavZucPdmPFfB1GWvYZf9oZpOd1Y5P4b4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772464982; c=relaxed/simple; bh=tnGNrd08ygRLNg29w5uOg5fCwaj3xRbm+K6TxvyXixM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=TcsTq+bPQT86LRRea+R/Q8ra+/N5rsyyRZm4ORhOLe2j477OmDutr+jr2cKJP+n6xyAPgtlvZVazUkvNsa/c2vjtHK2YX27ZsLXhWLmtIO4LqieEDsNGBA4UQQ+A+864iwXvK8tc1qLMcaMkqeRXaMgPHVvzp/istOuaN7BKjo8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=ilvokhin.com; spf=pass smtp.mailfrom=ilvokhin.com; dkim=pass (1024-bit key) header.d=ilvokhin.com header.i=@ilvokhin.com header.b=0XQtejgo; arc=none smtp.client-ip=178.62.254.231 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=ilvokhin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ilvokhin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ilvokhin.com header.i=@ilvokhin.com header.b="0XQtejgo" Received: from shell.ilvokhin.com (shell.ilvokhin.com [138.68.190.75]) (Authenticated sender: d@ilvokhin.com) by mail.ilvokhin.com (Postfix) with ESMTPSA id BD9F5B308A; Mon, 02 Mar 2026 15:22:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ilvokhin.com; s=mail; t=1772464979; bh=cZrWALVvP/5PCNYa5kN8hhPqzqgPdcu+PQQdFr2xuMA=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=0XQtejgoF4lHXmQZfH+M5Yr/k2dulaPURnPgHTjB3MWoBc4ABdeo9tX28PvlJ0wfS MhnKUH1BcERlzCflotEoBh7ucIj9rGuOw5aZlwAZ3tTbpooMJtXtq+bpD3TPnVM5C9 IoQNyU/1h833NedDbDGWDcatze9MhSFM3hlGuVIY= Date: Mon, 2 Mar 2026 15:22:57 +0000 From: Dmitry Ilvokhin To: "David Hildenbrand (Arm)" Cc: Andrew Morton , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Axel Rasmussen , Yuanchu Xie , Wei Xu , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , "Rafael J. Wysocki" , Pavel Machek , Len Brown , Brendan Jackman , Johannes Weiner , Zi Yan , Oscar Salvador , Qi Zheng , Shakeel Butt , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org, linux-pm@vger.kernel.org, SeongJae Park Subject: Re: [PATCH v4 2/5] mm: convert zone lock users to wrappers Message-ID: References: <7e93021d-53dd-4162-97e6-3bca1f46a0c6@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7e93021d-53dd-4162-97e6-3bca1f46a0c6@kernel.org> On Fri, Feb 27, 2026 at 09:39:11PM +0100, David Hildenbrand (Arm) wrote: > On 2/27/26 17:00, Dmitry Ilvokhin wrote: > > Replace direct zone lock acquire/release operations with the > > newly introduced wrappers. > > > > The changes are purely mechanical substitutions. No functional change > > intended. Locking semantics and ordering remain unchanged. > > > > The compaction path is left unchanged for now and will be > > handled separately in the following patch due to additional > > non-trivial modifications. > > > > Signed-off-by: Dmitry Ilvokhin > > Acked-by: Shakeel Butt > > Reviewed-by: SeongJae Park > > --- > > [...] > > > #ifdef CONFIG_COMPACTION > > @@ -530,11 +531,14 @@ static bool compact_lock_irqsave(spinlock_t *lock, unsigned long *flags, > > * Returns true if compaction should abort due to fatal signal pending. > > * Returns false when compaction can continue. > > */ > > -static bool compact_unlock_should_abort(spinlock_t *lock, > > - unsigned long flags, bool *locked, struct compact_control *cc) > > + > > +static bool compact_unlock_should_abort(struct zone *zone, > > + unsigned long flags, > > + bool *locked, > > + struct compact_control *cc) > > We tend to use two-tabs on second parameter line; like the existing code > did. > > > Besides that > > Acked-by: David Hildenbrand (Arm) > Thanks, David. Noted. Appreciate the review and ack. > -- > Cheers, > > David