From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 28BAB13B284 for ; Mon, 2 Mar 2026 17:07:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772471276; cv=none; b=ELvRiHs3rtPUv2nv6cUkwmYzA0Cqzl+Wf4cPGViCLLTm1eIJv76gn9Q8/OTSc4BMiU89Uc9ORX7x+DrXAtqPruO8vVE86Pe3kkEHnLnaMLUlOREOnbchlIx7qoFV4ZU8nQIqK7gkHXIZM0tWle8g/4Xwc28yh28npjZRNUnxaMg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772471276; c=relaxed/simple; bh=jIGPOc+FfJQxokBbUZuUkvPWYl6Uf9OBDLQ/zpqAsZ4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=sp9WxKngPJWtp9rMU3I2qmW+MgcZtYcQXVW+Z4jcJ/KeBeM8DVKe2E4RGERUDmhgF2T1SY1fwApRWTz0lK9K6Gh49iSuYrKpxKzF0KEHATa9dVR1gHlGYVQjglVoy49ucU/sQhcpfXUh7+PbX+nB+ck0AUIHuIMMwPoBLJIciY0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=VXfqtRbq; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=QFYSZKES; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="VXfqtRbq"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="QFYSZKES" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1772471271; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=43O843P9nsrXz3Z3fOd7BhVl+4E27iRL9ozt9KlrMRI=; b=VXfqtRbqOm8hWXHAFrTuof6e0+6XnQ9k6qpxj2zSpxtjAjW9SmnFIxCP1im+lArpGvYULH RykjDLbLXoRq/x81MwifuOOs5pAbtCadykCL8Djp80o/F8zJ4lQL5cKQmvrEiYP37XZzEz Zk9888kXjP7Ny2AYWxdUYpekHvWjSK4= Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-68-uwtkANDLMDyaxrXkcQn3QQ-1; Mon, 02 Mar 2026 12:07:49 -0500 X-MC-Unique: uwtkANDLMDyaxrXkcQn3QQ-1 X-Mimecast-MFC-AGG-ID: uwtkANDLMDyaxrXkcQn3QQ_1772471269 Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-50333a8184aso569624741cf.1 for ; Mon, 02 Mar 2026 09:07:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1772471269; x=1773076069; darn=vger.kernel.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=43O843P9nsrXz3Z3fOd7BhVl+4E27iRL9ozt9KlrMRI=; b=QFYSZKESjuCGaPhZMGFd9ygJhuL4JJeScdUf7nFtPj7Z5vgFbNYrprqBUTsO1NbjZi jbh9eUxsY57p2LRDSZXXaa9J8rmGHYgskf8rBFWTMKDVn8cogLmswyol86cmhKSojMC8 1DCpjorD/RK3CTXmtv3zmfO2tLitJ6v3ENnbPePt8rEWfhNuiUbbeeBNKHw9KGrXgTX1 Pzk/2J6uXaXDspWRqxMMMqNP1KVg0kyXS00DvA7WHJ3wJe0c/957aSwc6Al5WdTPN8cQ FsnYa6IDilfAs0dbQqBWkv4br/oSBHfrfpCwksyqw+wpnQN0GiDPzeeJJ8y+w6yBb1aS DnUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772471269; x=1773076069; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=43O843P9nsrXz3Z3fOd7BhVl+4E27iRL9ozt9KlrMRI=; b=jFI89G0579nWig1UnjG5/ht8LKmbiWqXW8+xQLIKtliwXw+eJYVp1A06Z54tqKWDya y5Ly7eaHfoPIiuEIfCPjzlSB2Ked+gUwedL60fxelsaFwcVopmxf7fYyfj6Pi91NaBYO pM1r0OKfxhqJbXLNy7yvMvhT6O3Dn8nIWZTY+LNHlcqBVwix6IrE7XboG3HQ9rIg++MD THsrXm8kPF9u6yBymHoGv6crLfNpXpjnooL8zn+9K4IGO6JpDAxnM7pr1tr4YkCLY8HI wQelNiYRaIJgKclR66oYioFq5ZmONHVklki4gYgQGb3An8xSe96lt9lyCAVNXqDCP/Be 5IhQ== X-Forwarded-Encrypted: i=1; AJvYcCWA37xBU4i/FMTMbGWea0nWjhxF874U65tXwSV+TEjLQLlTNh5xJq/Bl16NF+boTAkWjkH1423n0GIfIb8=@vger.kernel.org X-Gm-Message-State: AOJu0YxuJ+ZEIwQRHw/jeqB480LZ8kZaWWM2Kvo1QyxGVrxF3Oj8BfZS DX5QNU3z6ZvLb2MbXRr88veSNTYY0ocNtxgbbmIujUTQXmtBEHczJBDAy6oXyB1hWsZ7BT2QhJD fcS7+H0KN+mds/bruasKj+ZPUMyMWC1IFHl+mn1G7AKUWa7DoXvyWaSjFxepJmTKg7A== X-Gm-Gg: ATEYQzwVk1jHsQOE961EMqKrO5QyGQvWJSwkHOksquvxqRUQJR8BI3+qt+UT46nDP51 brPErMud5/jh3fU2ryUMVoEdvqnGxRVzQqURq5NdNvbLDShPe5MSiDLxKcC8UNEtyXh+H1atw1P G9dA4x+x/uMbX8E2WQcDtk/PuBflHLkUS8po25YZDJViomRyWPCOd3OdGuSNcZzGt1uuZPPJOsp feTaGWyw6z38SS+BnaNYcjsvy3fzSO34GYV+RoKyCduNihqgHkFv+Y/1HTXzrDXznxleSAUQ6Zd nQe0csEmQFSXcfEBywR8Q7VE1YEHIThoD8NX/fYlvi6S10ZDmml9UzTGK3j+wXojwdNKZ6BiiiK 4Sp/b5/2s9gRBBYoOGUfUPjx5p0uXoYMVTlZTJl/CWhQJGGmqRM+4StWD X-Received: by 2002:ac8:5a91:0:b0:501:13f2:e706 with SMTP id d75a77b69052e-50752a280c5mr143149221cf.73.1772471269434; Mon, 02 Mar 2026 09:07:49 -0800 (PST) X-Received: by 2002:ac8:5a91:0:b0:501:13f2:e706 with SMTP id d75a77b69052e-50752a280c5mr143148821cf.73.1772471268983; Mon, 02 Mar 2026 09:07:48 -0800 (PST) Received: from redhat.com (c-73-183-52-120.hsd1.pa.comcast.net. [73.183.52.120]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-50744ab3d88sm117087601cf.21.2026.03.02.09.07.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Mar 2026 09:07:48 -0800 (PST) Date: Mon, 2 Mar 2026 12:07:46 -0500 From: Brian Masney To: Krzysztof Kozlowski Cc: Krzysztof Kozlowski , Sylwester Nawrocki , Chanwoo Choi , Alim Akhtar , Michael Turquette , Stephen Boyd , GyoungBo Min , Kyunghwan Kim , Ravi Patel , linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, kernel test robot Subject: Re: [PATCH 1/2] clk: samsung: pll: Fix possible truncation in a9fraco recalc rate Message-ID: References: <20260226205445.336839-3-krzysztof.kozlowski@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260226205445.336839-3-krzysztof.kozlowski@oss.qualcomm.com> User-Agent: Mutt/2.2.14 (2025-02-20) On Thu, Feb 26, 2026 at 09:54:46PM +0100, Krzysztof Kozlowski wrote: > samsung_a9fraco_recalc_rate(), unlike other functions in the unit, is > the first case dividing u64 by u64, thus it should rather use div64_u64 > to avoid possible truncation. Note that the original code did not > use remainder. > > This fixes Coccinelle warning: > > clk-pll.c:1489:1-7: WARNING: do_div() does a 64-by-32 division, please consider using div64_u64 instead. > > Reported-by: kernel test robot > Closes: https://lore.kernel.org/oe-kbuild-all/202602250053.wEU1hlpY-lkp@intel.com/ > Fixes: f051dc5bc8e7 ("clk: samsung: Add clock PLL support for ARTPEC-9 SoC") > Signed-off-by: Krzysztof Kozlowski Reviewed-by: Brian Masney