From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BD5B9428834 for ; Mon, 2 Mar 2026 17:11:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772471488; cv=none; b=oruCaKT9+MW2FN4DK6JTydNFK8FLq+sK12Y061vfCWTLKj7pxiTQVBgh2dcnyGdPoz+yBjELJJGGHpZsFaxSrC61/LcU0qWErk3fYnJgHq3x4PAzoBVxegl2CcKavUdD4JEW3wao8ytt6EN6h1LLj/tEWskx4KFiaBZByEAMoxo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772471488; c=relaxed/simple; bh=Lds6rOZ7X/3g6xC/UqVG/xiT2+rkqLBII+J5UpiKeEk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=R2am9sQWbZ+vVTcXc/DsgJos99s4cLwIabLUKQU5uFMQQX5GdFAKPMbhVwC2Yk1BbLNtcM6jgQvn5px2worOzf424sM9XL3YVcEis9yI+nZEggKPbTU5+/SN/8Tz0g4GKNp9TPh8/CN2spiXmVKrOOfiVdFnHhc3exAebOCiz6Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=A3ZOVilY; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=efAO2olH; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="A3ZOVilY"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="efAO2olH" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1772471480; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=dTT0P65qbG5CTQSoBKTT9PgPPtpnw8OX1DWXnZ+KTiU=; b=A3ZOVilY2d98ppWsTwrVLfdOqYhWl9KF8Ob1FvP3OK5Xx6l6XNSrwbdK4qFpggrGLeONwf w3dTZLE7wuXyDYpFeM7KfPXYWoTRZKiTvVIsPILFjBEwQ9RV0T9chOUdy3UodMereadq9G g/VseJjy02GGvOJypLe41tUKM/BgJxM= Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-561-2Do5r9OkOAeTa7Bm9cQbqA-1; Mon, 02 Mar 2026 12:11:19 -0500 X-MC-Unique: 2Do5r9OkOAeTa7Bm9cQbqA-1 X-Mimecast-MFC-AGG-ID: 2Do5r9OkOAeTa7Bm9cQbqA_1772471479 Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-8cb5359e9d3so3785287185a.2 for ; Mon, 02 Mar 2026 09:11:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1772471479; x=1773076279; darn=vger.kernel.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=dTT0P65qbG5CTQSoBKTT9PgPPtpnw8OX1DWXnZ+KTiU=; b=efAO2olHnXWjbEwSzNJ9zmXzNimkl4eB8P5Cys0iWbvE4onmeeMgZiVV36RhKxbKJi DlkgH65lX9apaQM7M3U0sX7FiqyySd3TuAMea2lFBrhyaYVIDMNhW5gZj2DshozYIrGV prTjzmFNSTKr9p0jdTpc1fXT5db3tpdqvRAeyNY4Mem8Wa/YY1oELZrpAE6vUZwppUIy BdEjyvz9mjAg+WLpIUQoIWb5EADn3iy76Mi22BnMEFNpMk58DOrokfqTuvC/KVfxXQoe R1nKb6eOkDLFXLPfNB5my7IK69cfMQAW85hg6YslsG53VLYUeObz3ix3jahtl+sfOwgG v6fw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772471479; x=1773076279; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=dTT0P65qbG5CTQSoBKTT9PgPPtpnw8OX1DWXnZ+KTiU=; b=qSONoNdCKkDejNQLI3rLP2WzwLhvdUASX8EhCFVNERPM8azN9AM67V5r0Gzzc3Fdvc 9OSWL+xmqvUuVPOlXWpMJITFfBTsH49P/OLoDiYQocyTez1tp+w3I3UTu9rpMi6sz/9Q Zg0qE7DvCDA+LVrfQilExrIdXgq2Cd1sO0iwx7P7egblZukBJdxILRAXKuMDYdTmDFI7 cENkj0SNivxb/sDK90PXG1XuaZjlPw7y2dNTXPCJXNH4okYZFTbVPLUv1FAoimYvmwxi GYifSdaavGOgAB65s4bdoKPimeuriHqbw0f3lVS+Bg42twSHa2fu/S4LsTKocTCnozmW +mQQ== X-Forwarded-Encrypted: i=1; AJvYcCUlqz4LE2/NWgBpGoT4N2kXO+ib2ORBS4zuC8S9M0hV97e50nJcN4ZYF2iQvSVoUGz4VffcpXE9Ifupg+A=@vger.kernel.org X-Gm-Message-State: AOJu0YxErlX6tJdR8FCCGRZVUHU/oOlhz5nzhvEEmm/2O13Dt6VpkNa3 jCnKs4ixCDwK1tNskCid7qHm86CEHpaLvjeLI0mmhwiF8tLtGYKU49QmoyFxktIiGTQ9N1Ggu48 1qLWvfmh+RhS3sYEQ4ZGRxufLr0RAQJutTWFev95v67oII7/vkbKxP6Kq3qkNBdiEDg== X-Gm-Gg: ATEYQzyogRz+V4uYHiARH/mveiW0JvsAD1kE+gY3i6kqxO3GpC23DIkce8NtgVrPWqK jM7I92VI1oW53OAc94dLNuWTMZ0LQm9YV1NTPobehvlMLvf8IoSzFoH56eVzOBg3+HecyFbI62G zIfTD1NtBvEhc1jERBkuvkA9D4yJoWKtYvK2xqz9fEc3rJmObENXGp6sh9xz/IXaYjSySW+gUQ8 ec4G6t4P/Sq0MVQ0pXsnOtJsktMOREVSt323Tfq3oRod6hqQVyHqqTvwKQFOquuwVd39UfX2KLO 3pnM54HLbWZVswSOnKnX1ynBYygjgoxFdxqkotF6iHnD3HycRWZDnX1aKycEG8KLyvzwibZrMhG J1W4xqbL3RcDv9w0IFrDhels6qoo4vU5X1aSF1eyxYqPWBcBrmvW9RRKw X-Received: by 2002:a05:620a:28d6:b0:8c9:fb0e:ca43 with SMTP id af79cd13be357-8cbc8deb20fmr1599860985a.24.1772471478985; Mon, 02 Mar 2026 09:11:18 -0800 (PST) X-Received: by 2002:a05:620a:28d6:b0:8c9:fb0e:ca43 with SMTP id af79cd13be357-8cbc8deb20fmr1599855585a.24.1772471478512; Mon, 02 Mar 2026 09:11:18 -0800 (PST) Received: from redhat.com (c-73-183-52-120.hsd1.pa.comcast.net. [73.183.52.120]) by smtp.gmail.com with ESMTPSA id af79cd13be357-8cbbf6534f3sm1172998185a.5.2026.03.02.09.11.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Mar 2026 09:11:17 -0800 (PST) Date: Mon, 2 Mar 2026 12:11:16 -0500 From: Brian Masney To: Peng Fan Cc: Cristian Marussi , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, arm-scmi@vger.kernel.org, linux-clk@vger.kernel.org, linux-renesas-soc@vger.kernel.org, sudeep.holla@arm.com, philip.radford@arm.com, james.quinlan@broadcom.com, f.fainelli@gmail.com, vincent.guittot@linaro.org, etienne.carriere@foss.st.com, michal.simek@amd.com, dan.carpenter@linaro.org, geert+renesas@glider.be, kuninori.morimoto.gx@renesas.com, marek.vasut+renesas@gmail.com, Michael Turquette , Stephen Boyd Subject: Re: [PATCH 02/11] clk: scmi: Use new determine_rate clock operation Message-ID: References: <20260227153225.2778358-1-cristian.marussi@arm.com> <20260227153225.2778358-3-cristian.marussi@arm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/2.2.14 (2025-02-20) On Sat, Feb 28, 2026 at 08:56:04AM +0800, Peng Fan wrote: > On Fri, Feb 27, 2026 at 03:32:16PM +0000, Cristian Marussi wrote: > >Use the Clock protocol layer determine_rate logic to calculate the closest > >rate that can be supported by a specific clock. > > > >No functional change. > > > >Cc: Brian Masney > >Cc: Michael Turquette > >Cc: Stephen Boyd > >Cc: linux-clk@vger.kernel.org > >Signed-off-by: Cristian Marussi > >--- > >Note that the calculation logic in the protocol layer is exactly the same > >as it wes here. > > > >@Brian I suppose once your CLK_ROUNDING_FW_MANAGED sereis is merged I can flag > >such SCMI clocks. > > Per my reading of Brain's thread, if ->determine_rate exists, > ->determine_rate() will be used. > > } else if (core->ops->determine_rate) { > return core->ops->determine_rate(core->hw, req); > + } else if (clk_is_rounding_fw_managed(core)) { > + return 0; > > So unless update scmi_clk_determine_rate() to something: > -------- > if (clk & CLK_ROUNDING_FW_MANAGED) > return 0; > > return scmi_proto_clk_ops->determine_rate(clk->ph, clk->id, &req->rate); > -------- > > It maybe better to update Brain's patch to move clk_is_rounding_fw_managed() > above the check of core->ops->determine_rate(). The clk framework has some basic sanity checks in place that are called during device probe to ensure that various ops are configured properly. I could add a check that if CLK_ROUNDING_FW_MANAGED [*] is set, and a determine_rate() op is set, then it gives an error. [*] Note: I am tentatively planning to rename that to CLK_ROUNDING_NOOP in v2 in about a week. Brian