From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 16BF13164C5 for ; Mon, 2 Mar 2026 17:39:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772473170; cv=none; b=qtxMVBeqBFbMsWP5q12TuyCfzpqQVUT8+6w11N/VZJIAOvB6+ewIZr/uYWZm/w9wkObX/7/vtmwems+5OyL6A6AwPr6z0HD+eOuff0ahy/ALhh4O/cnjNu2LqJwzaOrlW2hHLo+oBVO4xE34LCk8+Rf5MSC1gMVDwazSh/9JMQQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772473170; c=relaxed/simple; bh=uUvCAGGb52PuwK+CGHANQS62FlOFRBknxd+wtqQSDTs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=fSdnH1JDSW+PWXX6Y/2+/Ym9yYUCj4CwrJ+HpFGi2K+zM8mdNIsGVB+CzvlLbjncP6l893M3mtBZV3u9fbsgs3iwdM+vpdc9R7QmN1l3srasnBf8zmT0i/WyBFK9O+ZJvDMtdxG+cdBy1gtR8lJytrZX2nTXWiVVdqG4/8kSssw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=b3NeLuEJ; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=pSdYVrap; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="b3NeLuEJ"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="pSdYVrap" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1772473168; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=i1tUwxzrUgsmfVWvT+mkxBs36R16WUO3Sf96FjGd71g=; b=b3NeLuEJjWG7OUqxmI16AwMiYTgUQJUlrzYuKqc58N7xlgdkdh9zxvFnGwGs2s7mVPeL/6 14pdgqfLeNsbDk4NiYCT91VmFkWn+rQdB9gsCxRI0pRPlNSW/Bb5iwsxDWsS2dCpkQGmOf XPi59ZYg8Ig+3JxtKKmNPee9zPO2XLA= Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-586-fHf-OiYFPv2wrxSaHrsK9g-1; Mon, 02 Mar 2026 12:39:24 -0500 X-MC-Unique: fHf-OiYFPv2wrxSaHrsK9g-1 X-Mimecast-MFC-AGG-ID: fHf-OiYFPv2wrxSaHrsK9g_1772473163 Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-8c70e610242so97032785a.2 for ; Mon, 02 Mar 2026 09:39:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1772473163; x=1773077963; darn=vger.kernel.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=i1tUwxzrUgsmfVWvT+mkxBs36R16WUO3Sf96FjGd71g=; b=pSdYVrap5TLaq7UUWM/3I26SlPaiIhIrp4UU76aVDtSXnwEOLDj8ZpAdSo1YsQqL+1 gHHe954gF8VfwVe4lCmMWEWnjEZQ5GdjH6ijL1T0IV/ZbiuyWBgAJlXXwKM8JdGutdoQ P6Qhz5W0MOrjjmEjCRmreXzngMbcnxg9oWdQmjSHFJKBHc/J+mZ410BRQYpo0p3Vuqe4 7bhge9dgFwyldujgJhI08BYq7SKfCSJYUihhlLkCLKq9faRqYfgSO6txRJWKZC4nM8xR ONoDt2Bm+gY79LqDFNshs9bUyWx8zuCXzsmxwyGnjH2TPTbxbFXVTqWvM8p2BWR6irxj vV5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772473163; x=1773077963; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=i1tUwxzrUgsmfVWvT+mkxBs36R16WUO3Sf96FjGd71g=; b=hHd8Iohn0EiKwEpm0/WODgAIqO/EjbHU2pRAORaAYPl4xjSzkunQRRZZc08F+xSO4n SkRksg5qw+V56S7zqCWPjtIY1fpxz6y8twx2P+m+jRtGmewMxj03keR9WMdC2XAjNnNy eKOy1vUqVFPRcg+zdlbsvoxrtRU/EyYc6FJpOBE67sRVJECqzSfZvIcRkZ5kV/uqfvDs j8xGsOyY7lmAL4mJwrEbVbgSpcyNsWMT1z+QVOCax9deOqqqHAIlsu8gj7z+z4HB0wD+ L/XVuDQtFH8hD8d79axolhf8IuzsRt50Hlc56PEr+QfiyS0XDzbeYJo8xMyzU/zzQ/Lp Isyw== X-Forwarded-Encrypted: i=1; AJvYcCVZS3Mr/Gzz1Z8OGvr/ZwgckIOvbal3j5HZhohUCLmeLFx7ErIPyaHGc6cy9ooESeEFdkNV88K2WDq+OXI=@vger.kernel.org X-Gm-Message-State: AOJu0Yw9duQO9vbwbMzgAFIT3XX5mhBFuQGKEeb+7nYPwlL9XY7gmkeE L//XkSfPP/cuv+rEfzq+JUmT+bQFnZeMeloqfAdtwbkcLO6jvb50jwG6NpX7/akh3w0/oFzZ+Fl HNoCZm8XmvqABe0Qlwn5QhCqj1oaAePxmaL1/sID9Cr9VSGroWK0IJ8dfWdulL1pb8A== X-Gm-Gg: ATEYQzzpSOf+7GHM4oZB9ZILvBCsnrlnL1zEHZ4V/7dnrOL8w0kc5TWnDAm8DkGICok ghw6Ias42Qcg1Gs49Ff/U6pAGWQ3zM0L5U0+DPsa8cPpYZgXlVrDeLKQIPubb/9VGWyiFkKnJqe 8CWYxh7dFKQ/zlmc/FH2bG9yze60BEJNkKbZSqMgnd/h9BSTYvPG537ArQrjaoLbVMCbqdosAPB Zzllh0l+bvHp3Y8BK3f7ensL3RC6tfU2Ax2c8GftUMJ+jV8q9KhJJTUKxsnAZ6aOJJYi2PRweZO kb+uzyS6ngR6wJYrq6xlijJV81miGjY4zF70eOAnWBB6U2+lqBWUAdwdT753jaV4ueWReF67r2q LFMavB2Bm8t0Xul6kHMftn29cRuFbYOjPo1m0HmjQzleDliXrs/JceVGo X-Received: by 2002:a05:620a:3703:b0:8ca:7b14:16d4 with SMTP id af79cd13be357-8cbc8e2d0a6mr1630208785a.63.1772473162753; Mon, 02 Mar 2026 09:39:22 -0800 (PST) X-Received: by 2002:a05:620a:3703:b0:8ca:7b14:16d4 with SMTP id af79cd13be357-8cbc8e2d0a6mr1630204685a.63.1772473162215; Mon, 02 Mar 2026 09:39:22 -0800 (PST) Received: from redhat.com (c-73-183-52-120.hsd1.pa.comcast.net. [73.183.52.120]) by smtp.gmail.com with ESMTPSA id af79cd13be357-8cbbf64ef00sm1206428685a.10.2026.03.02.09.39.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Mar 2026 09:39:21 -0800 (PST) Date: Mon, 2 Mar 2026 12:39:20 -0500 From: Brian Masney To: dongxuyang@eswincomputing.com Cc: mturquette@baylibre.com, sboyd@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, troy.mitchell@linux.dev, ningyu@eswincomputing.com, linmin@eswincomputing.com, huangyifeng@eswincomputing.com, pinkesh.vaghela@einfochips.com, ganboing@gmail.com, marcel@ziswiler.com Subject: Re: [PATCH v14 3/4] clk: eswin: Add eic7700 clock driver Message-ID: References: <20260226090513.1696-1-dongxuyang@eswincomputing.com> <20260226090646.1867-1-dongxuyang@eswincomputing.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260226090646.1867-1-dongxuyang@eswincomputing.com> User-Agent: Mutt/2.2.14 (2025-02-20) On Thu, Feb 26, 2026 at 05:06:46PM +0800, dongxuyang@eswincomputing.com wrote: > From: Xuyang Dong > > Add clock drivers for the EIC7700 SoC. The clock controller on the ESWIN > EIC7700 provides various clocks to different IP blocks within the SoC. > > Signed-off-by: Yifeng Huang > Tested-by: Marcel Ziswiler # ebc77 > Signed-off-by: Xuyang Dong [snip] > +static struct platform_driver eic7700_clock_driver = { > + .probe = eic7700_clk_probe, > + .driver = { > + .name = "eic7700-clock", > + .of_match_table = eic7700_clock_dt_ids, > + }, > +}; > +module_platform_driver(eic7700_clock_driver); > + > +MODULE_LICENSE("GPL"); > +MODULE_AUTHOR("Yifeng Huang"); > +MODULE_AUTHOR("Xuyang Dong"); Add space between the name and <. > +MODULE_DESCRIPTION("ESWIN EIC7700 clock controller driver"); > diff --git a/drivers/clk/eswin/clk.c b/drivers/clk/eswin/clk.c > new file mode 100644 > index 000000000000..3d40d1d7e696 > --- /dev/null > +++ b/drivers/clk/eswin/clk.c > @@ -0,0 +1,588 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Copyright 2026, Beijing ESWIN Computing Technology Co., Ltd.. > + * All rights reserved. > + * > + * Authors: > + * Yifeng Huang > + * Xuyang Dong > + */ > + > +#include > +#include > +#include > +#include > +#include > +#include > + > +#include "common.h" > + > +#define PLL_EN_MASK GENMASK(1, 0) > +#define PLL_REFDIV_MASK GENMASK(17, 12) > +#define PLL_FBDIV_MASK GENMASK(31, 20) > +#define PLL_FRAC_MASK GENMASK(27, 4) > +#define PLL_POSTDIV1_MASK GENMASK(10, 8) > +#define PLL_POSTDIV2_MASK GENMASK(18, 16) > + > +struct eswin_clock_data *eswin_clk_init(struct platform_device *pdev, > + size_t nr_clks) > +{ > + struct eswin_clock_data *eclk_data; > + > + eclk_data = devm_kzalloc(&pdev->dev, > + struct_size(eclk_data, clk_data.hws, nr_clks), > + GFP_KERNEL); > + if (!eclk_data) > + return ERR_PTR(-ENOMEM); > + > + eclk_data->base = devm_platform_ioremap_resource(pdev, 0); > + if (IS_ERR(eclk_data->base)) > + return ERR_PTR(-EINVAL); > + > + eclk_data->clk_data.num = nr_clks; > + /* Avoid returning NULL for unused id */ > + memset_p((void **)eclk_data->clk_data.hws, ERR_PTR(-ENOENT), nr_clks); The (void **) cast shouldn't be needed. However, stepping back, this memory is allocated using kzalloc() above, so that range should already be zeroed. Unless I am missing something. With those two minor issues fixed, you can add: Reviewed-by: Brian Masney