From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f44.google.com (mail-dl1-f44.google.com [74.125.82.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EBE8848C3E9 for ; Mon, 2 Mar 2026 20:27:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772483247; cv=none; b=u4wCmKgsmPxMzxwcSvE9r60FC6XvaRgRRLdYLYhzlCAL1I6HhU5bnrStbphG4hVzG9hinIKWTCeIhq4hxaCbw/tiyXEDhlORwFWwhS9xdIaBNNWEWpfwIzbQ5KIUuNwY4ybpULfuAfpZK9q8w5rFF+qBHU39NRszI47ULSR3PxE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772483247; c=relaxed/simple; bh=B05mIikXXH7RcOlPNPqK3suQ42hmBbuLRO9Qq616Pg4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=OvJhM+DELOsP3QT4apgrR7geQ3vT3KJifNuzMOOOJCtgl9yWoZ9fH67xOKJn/iE/qvryA9B8jxtVZcpGCfg9KI6eI2MTGUGJGw/30SVlY3g+7sNLl5JjQ7jciaaie4vq0oTetbqHPd5DparCqTKhAj442ZPsKa2erAk4zZz4qfA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Cc14m4jO; arc=none smtp.client-ip=74.125.82.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Cc14m4jO" Received: by mail-dl1-f44.google.com with SMTP id a92af1059eb24-12713e56abdso2938394c88.1 for ; Mon, 02 Mar 2026 12:27:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772483245; x=1773088045; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=NXVMGTylc166eOKIIuxDxOR/XS/9oedP5aBtDDDLocs=; b=Cc14m4jOu4iRYcCTVZG+6aqU5yKP6cUAhFEnaM7DO1FkSnXH/lF/ZysfzDJPBiPzI9 nC2rEG6+Uj5186WAnTLi9DsrYbsw6N4wkwFwE2EqszLzjoHbsfewNHI11suFLWs52h1b fQcbTiV3alha0VcpF4ALnQihZuRwGEDtc2Uo4/SjdNZnKQAtZ80+L7YE+HB/FL8RMLnU hV6JA3WMOyeSdzu5BCaJohQRyIDpX9oZXA1MUj5PpYut7ro1MmaEeNVVRIEFpyvt4dQW nM+YOLKDiFVG6+RVba0FSYGkazdQExElmGb5Fd90mMH0NehkeDNXjvY+PsOmZVksz5ME uWcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772483245; x=1773088045; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=NXVMGTylc166eOKIIuxDxOR/XS/9oedP5aBtDDDLocs=; b=pQj2FoYdz+N8T+Tu1WNIIG8FOjwqOXaIhVUn8t2Z7ouQR15gE0V8x6mVTGdjlXKbNt OGhejURs/grveasBWf3sWVCXMfpszAB2eMDz+FMN+2JY+vLkLlgREgywDdHADdQ+b5Oz aS4XYLDdJAKXTkOvCz6tK5EpfJctIhwtZW4GWMFa7DScpqiKUJGchTbmIAatF1nvfVjm TzjXaJoqZBZMEbcIkq4htpteHpO/ql55GEtrKvQSmWzPtaSnwrlEPuFGDLSqH6iipbc1 X2Ztk4rTqu0pvg+J6Uf8HpXsunn+Ll9Iet/r1auNuiJqyHYm9tyRJeO+/79pYojTUs7+ Ctww== X-Gm-Message-State: AOJu0YxmqxPD8Zo+51J5NoJ4hWBnL0TyrjkFn7xP7qIV2aBKgcvIJpWe ma44fDPtw8Og3RtbG/fRVrRNjCtBjx2s6bmBLN2tvheluxAHUPl0nYhF X-Gm-Gg: ATEYQzwBgaYLqebAm/0c8YDghj4qy9MSGzzzqcbQLxpwOdax4Fi/vdf2aDb5ser07u6 0rmfryfQIfIKnckhZlcE6rQuAqh4yCcaO7+4dZ7iIq/rIJol19AWCKxvVyeBFrSsCkSpB8t9+CH 0n4Um651Nc7NW1TldzdUgKyOxb8IkhkYPNzV69C9TBUjK0ahCuwk2BEmCPviDly/Tvuvf7qnHEr TBwXCSjNQFOMUAo6tElL8wjEsJiSmooomfkmJWxpDzdQ27Z7TpZPF4XKZx0D/pyufdhdWuTOGB3 jkw+wYHWJ0Ie+wsJH/wqYdFqZ2RXeI0zxesUwAFHUF16j3r1BV9Z1eyJN9NjENNLntYMCsL21Bf Kf1FETMGTEAYQ2JY/lL64bXECAmXyAdrTavpXbi1McLo8S6TumgOpMtzeWkP1FIh/x8QB9ZgYHZ yTMZY0MamedGVzAOzZaD36M9e4HT1k7Q7CdA2ozoZnzzJMymPDAIW4rINUXOZFYmLDkjZH2ngnX tySgx8OUr6Gv7A= X-Received: by 2002:a05:7022:61d:b0:124:9f56:832e with SMTP id a92af1059eb24-127890fc341mr6372453c88.18.1772483244781; Mon, 02 Mar 2026 12:27:24 -0800 (PST) Received: from fedora (c-67-164-59-41.hsd1.ca.comcast.net. [67.164.59.41]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2bdfed770dfsm5982290eec.19.2026.03.02.12.27.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Mar 2026 12:27:24 -0800 (PST) Date: Mon, 2 Mar 2026 12:27:21 -0800 From: "Vishal Moola (Oracle)" To: Dave Hansen Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, "Mike Rapoport (Microsoft)" , Dave Hansen , "Matthew Wilcox (Oracle)" , akpm@linux-foundation.org, Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" Subject: Re: [PATCH v6 0/4] Convert x86/mm/pat to generic page table apis Message-ID: References: <20260219020354.321088-1-vishal.moola@gmail.com> <2fe139df-1764-40e5-983d-48d7f97c2e39@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Mon, Mar 02, 2026 at 09:33:31AM -0800, Dave Hansen wrote: > On 2/27/26 16:44, Vishal Moola (Oracle) wrote: > > On Fri, Feb 27, 2026 at 02:24:33PM -0800, Dave Hansen wrote: > >> On 2/27/26 12:07, Vishal Moola (Oracle) wrote: > >>> Do you have any more comments for this series? If not, could you please > >>> take this through the x86 tree. Thanks 🙂 > >> > >> From a 2-second glance, this doesn't have normal comment style and isn't > >> using imperative voice. Quite a few "we's". Looks like it needs some > >> more eyeballs. > > > > Ok, my mistake on the comment style. I'll fix that. > > > > Sorry I'm not the greatest at imperative voice, I'll pass all my comments > > through AI to convert them all to imperative voice. > > > > In regards to more eyeballs, I've realized I didn't cc ALL x86 > > maintainers. +CC the rest of the x86 maintainers and we'll hope > > someone else looks at it as well. > > I was actually kinda hoping you'd be able to actively go out and find > some reviewers other than the maintainers. I'd appreciate if you could give me more guidance on this. Who am I supposed to go, if not the people from ./get_maintainers? I don't know the x86 folks, I interact more with mm. You've been giving valuable feedback to ensure the stylistic choices meet your expectations. I have mentioned I'll have another version *trying* to meet those stylistic expectations. Mike has been very active in reviewing the ptdesc work (thanks!), and he's provided valuable review about the code itself. I don't know about you, but I trust his expertise on the topic of page tables. So, I don't even know what you want from the "more eyeballs." Do you want me to email a bunch of people unfamiliar with x86 and tell them to catch what you (or any other specialized individual) would catch? That doesn't sound productive *to me*. This is on the x86 mailing list. And honestly, this current iteration is simple enough that anyone specialized and interested could have taken a look at it and to provide some feedback. Please do let me know. I'd love to work with you not against you, but that's difficult when you don't provide any guidance/pointers about the issues you have with the patchset (or process?).