From: Dan Carpenter <dan.carpenter@linaro.org>
To: Josh Law <hlcj1234567@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Ovidiu Panait <ovidiu.panait.oss@gmail.com>,
Gabriel Shahrouzi <gshahrouzi@gmail.com>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
Josh Law <objecting@objecting.org>
Subject: Re: [PATCH v2 05/10] staging: axis-fifo: improve IRQ handler
Date: Tue, 3 Mar 2026 09:10:09 +0300 [thread overview]
Message-ID: <aaZ7QfW7cFAJ4m0R@stanley.mountain> (raw)
In-Reply-To: <f8772114-a495-409b-a590-a9b1d8ed1d41@gmail.com>
On Mon, Mar 02, 2026 at 03:55:36PM +0000, Josh Law wrote:
> 2 Mar 2026 08:14:53 Dan Carpenter <dan.carpenter@linaro.org>:
>
> > On Sun, Mar 01, 2026 at 09:48:10PM +0000, Josh Law wrote:
> >> From: Josh Law <objecting@objecting.org>
> >>
> >> Return IRQ_NONE when no interrupts were triggered to avoid spurious
> >> interrupt storms, and only clear the active interrupts instead of
> >> blindly clearing all interrupts by writing 'intr' to the ISR instead of
> >> XLLF_INT_CLEAR_ALL.
> >>
> >
> > Is this something you actually experienced in real life? The commit
> > message needs to be clearer about that.
> >
> > regards,
> > dan carpenter
>
> Hello Dan, It's just code optimizations, making it cleaner, etc, I
> also ran all of these latest V2 commits through check patch, to make
> sure they are compliant, I own this device so I hope I can be the
> maintainer of it one day, I'm learning this Linux system day by day,
> so I am sorry I have to annoy a professional linaro dev like you haha
>
I don't mind reviewing patches. The cleanups are easy to review. In
this case it's a behavior change and so I would want a clearer picture
the motivation and of how well these have been tested for that.
regards,
dan carpenter
next prev parent reply other threads:[~2026-03-03 6:10 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-01 21:48 [PATCH v2 01/10] staging: axis-fifo: fix alignment and line length in wait_event_interruptible Josh Law
2026-03-01 21:48 ` [PATCH v2 02/10] staging: axis-fifo: remove redundant goto end Josh Law
2026-03-01 21:48 ` [PATCH v2 03/10] staging: axis-fifo: simplify resource mapping Josh Law
2026-03-01 21:48 ` [PATCH v2 04/10] staging: axis-fifo: use dev_err_probe() for IRQ error handling Josh Law
2026-03-01 21:48 ` [PATCH v2 05/10] staging: axis-fifo: improve IRQ handler Josh Law
2026-03-02 8:05 ` Dan Carpenter
2026-03-02 15:55 ` Josh Law
2026-03-03 6:10 ` Dan Carpenter [this message]
2026-03-03 7:02 ` Josh Law
2026-03-03 7:27 ` Dan Carpenter
2026-03-03 7:30 ` Josh Law
2026-03-03 7:46 ` Dan Carpenter
2026-03-03 6:58 ` Dan Carpenter
2026-03-01 21:48 ` [PATCH v2 06/10] staging: axis-fifo: minimize lock duration in write Josh Law
2026-03-01 21:48 ` [PATCH v2 07/10] staging: axis-fifo: fix grammar in Kconfig help text Josh Law
2026-03-01 21:48 ` [PATCH v2 08/10] staging: axis-fifo: use lowercase hex constant for consistency Josh Law
2026-03-01 21:48 ` [PATCH v2 09/10] staging: axis-fifo: remove unnecessary variable initializations Josh Law
2026-03-01 21:48 ` [PATCH v2 10/10] staging: axis-fifo: simplify error returns in axis_fifo_parse_dt() Josh Law
2026-03-02 8:14 ` [PATCH v2 01/10] staging: axis-fifo: fix alignment and line length in wait_event_interruptible Dan Carpenter
2026-03-02 8:42 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aaZ7QfW7cFAJ4m0R@stanley.mountain \
--to=dan.carpenter@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=gshahrouzi@gmail.com \
--cc=hlcj1234567@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=objecting@objecting.org \
--cc=ovidiu.panait.oss@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox