From: Dan Carpenter <dan.carpenter@linaro.org>
To: Dipesh Chaudhary <me@dipeshchaudhary.in>
Cc: gregkh@linuxfoundation.org, b9788213@gmail.com,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] staging: rtl8723bs: add missing blank line after declarations
Date: Tue, 10 Mar 2026 10:29:36 +0300 [thread overview]
Message-ID: <aa_IYAWSSdrd-WuR@stanley.mountain> (raw)
In-Reply-To: <8fe61fed-a97a-440a-9cf1-f20dead4e265@smtp-relay.sendinblue.com>
On Tue, Mar 10, 2026 at 02:41:49AM +0000, Dipesh Chaudhary wrote:
> Add a blank line after the pwrpriv declaration in rtw_set_ips_deny()
> to satisfy checkpatch warnings and improve code readability.
>
> Signed-off-by: Dipesh Chaudhary <me@dipeshchaudhary.in>
> Reviewed-by: Bera Yüzlü <b9788213@gmail.com>
> ---
> v3:
> - Included Reviewed-by tag from Bera Yüzlü.
> - Corrected the changelog location to be below the --- line.
> v2:
> - Capitalized name in Signed-off-by.
> - Wrapped commit description to 72 characters.
> - Fixed duplicate submission issues.
>
> drivers/staging/rtl8723bs/core/rtw_pwrctrl.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c
> b/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c
> index 666e241704d9..bd295bdd73f6 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c
> @@ -991,6 +991,7 @@ void rtw_free_pwrctrl_priv(struct adapter *adapter)
> inline void rtw_set_ips_deny(struct adapter *padapter, u32 ms)
> {
> struct pwrctrl_priv *pwrpriv = adapter_to_pwrctl(padapter);
> +
> pwrpriv->ips_deny_time = jiffies + msecs_to_jiffies(ms);
This one got corrupted.
regards,
dan carpenter
next parent reply other threads:[~2026-03-10 7:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <8fe61fed-a97a-440a-9cf1-f20dead4e265@smtp-relay.sendinblue.com>
2026-03-10 7:29 ` Dan Carpenter [this message]
[not found] <c34f031c-3271-47cc-9a06-fc3406a25aac@smtp-relay.sendinblue.com>
2026-03-09 18:59 ` [PATCH v3] staging: rtl8723bs: add missing blank line after declarations Bera Yüzlü
2026-03-09 20:01 ` Dan Carpenter
2026-03-18 15:47 ` Greg KH
[not found] <8b574dd5-3cc3-4508-8455-a53a3d36072d@smtp-relay.sendinblue.com>
2026-03-18 15:34 ` Greg KH
2026-03-09 17:49 Dipesh Chaudhary
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aa_IYAWSSdrd-WuR@stanley.mountain \
--to=dan.carpenter@linaro.org \
--cc=b9788213@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=me@dipeshchaudhary.in \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox