Re: [PATCH v3] staging: rtl8723bs: add missing blank line after declarations

Re: [PATCH v3] staging: rtl8723bs: add missing blank line after declarations

[Dan Carpenter]

On Tue, Mar 10, 2026 at 02:41:49AM +0000, Dipesh Chaudhary wrote:
> Add a blank line after the pwrpriv declaration in rtw_set_ips_deny()
> to satisfy checkpatch warnings and improve code readability.
> 
> Signed-off-by: Dipesh Chaudhary <me@dipeshchaudhary.in>
> Reviewed-by: Bera Yüzlü <b9788213@gmail.com>
> ---
> v3:
> - Included Reviewed-by tag from Bera Yüzlü.
> - Corrected the changelog location to be below the --- line.
> v2:
> - Capitalized name in Signed-off-by.
> - Wrapped commit description to 72 characters.
> - Fixed duplicate submission issues.
> 
> drivers/staging/rtl8723bs/core/rtw_pwrctrl.c | 1 +
> 1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c
> b/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c
> index 666e241704d9..bd295bdd73f6 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c
> @@ -991,6 +991,7 @@ void rtw_free_pwrctrl_priv(struct adapter *adapter)
> inline void rtw_set_ips_deny(struct adapter *padapter, u32 ms)
> {
> struct pwrctrl_priv *pwrpriv = adapter_to_pwrctl(padapter);
> +
> pwrpriv->ips_deny_time = jiffies + msecs_to_jiffies(ms);

This one got corrupted.

regards,
dan carpenter

Re: [PATCH v3] staging: rtl8723bs: add missing blank line after declarations

[Bera Yüzlü]

> Add a blank line after the pwrpriv declaration in rtw_set_ips_deny()
> to satisfy checkpatch warnings and improve code readability.
> 
> Signed-off-by: Dipesh Chaudhary <me@dipeshchaudhary.in>
> ---

Is this patch too minor?

Reviewed-by: Bera Yüzlü <b9788213@gmail.com>

Thanks,
Bera

Re: [PATCH v3] staging: rtl8723bs: add missing blank line after declarations

[Dan Carpenter]

On Mon, Mar 09, 2026 at 09:59:26PM +0300, Bera Yüzlü wrote:
> > Add a blank line after the pwrpriv declaration in rtw_set_ips_deny()
> > to satisfy checkpatch warnings and improve code readability.
> > 
> > Signed-off-by: Dipesh Chaudhary <me@dipeshchaudhary.in>
> > ---
> 
> Is this patch too minor?
> 

No, it's fine.  These sorts of patches are easy to review.  Plus, Greg
is a glutton for punishment.

regards,
dan carpenter

Re: [PATCH v3] staging: rtl8723bs: add missing blank line after declarations

[Greg KH]

On Mon, Mar 09, 2026 at 05:49:04PM +0000, Dipesh Chaudhary wrote:
> 
> Add a blank line after the pwrpriv declaration in rtw_set_ips_deny()
> to satisfy checkpatch warnings and improve code readability.
> 
> Signed-off-by: Dipesh Chaudhary <me@dipeshchaudhary.in>
> ---
> v3:
>  - Corrected the changelog location to be below the --- line.
> v2:
>  - Capitalized name in Signed-off-by.
>  - Wrapped commit description to 72 characters.
>  - Fixed duplicate submission issues.
> 
>  drivers/staging/rtl8723bs/core/rtw_pwrctrl.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> 
> diff --git a/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c b/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c
> index 666e241704d9..bd295bdd73f6 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c
> @@ -991,6 +991,7 @@ void rtw_free_pwrctrl_priv(struct adapter *adapter)
>  inline void rtw_set_ips_deny(struct adapter *padapter, u32 ms)
>  {
>  	struct pwrctrl_priv *pwrpriv = adapter_to_pwrctl(padapter);
> +
>  	pwrpriv->ips_deny_time = jiffies + msecs_to_jiffies(ms);
>  }
>  
> -- 
> 2.47.3
> 
> 
> 
> 


Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- Your patch did not apply to any known trees that Greg is in control
  of.  Possibly this is because you made it against Linus's tree, not
  the linux-next tree, which is where all of the development for the
  next version of the kernel is at.  Please refresh your patch against
  the linux-next tree, or even better yet, the development tree
  specified in the MAINTAINERS file for the subsystem you are submitting
  a patch for, and resend it.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot

Re: [PATCH v3] staging: rtl8723bs: add missing blank line after declarations

[Greg KH]

On Tue, Mar 10, 2026 at 02:41:49AM +0000, Dipesh Chaudhary wrote:
> *Add a blank line after the pwrpriv declaration in rtw_set_ips_deny()
> to satisfy checkpatch warnings and improve code readability.
> 
> Signed-off-by: Dipesh Chaudhary
> Reviewed-by: Bera Yüzlü

You sent this in html format :(

[PATCH v3] staging: rtl8723bs: add missing blank line after declarations

[Dipesh Chaudhary]

Add a blank line after the pwrpriv declaration in rtw_set_ips_deny()
to satisfy checkpatch warnings and improve code readability.

Signed-off-by: Dipesh Chaudhary <me@dipeshchaudhary.in>
---
v3:
 - Corrected the changelog location to be below the --- line.
v2:
 - Capitalized name in Signed-off-by.
 - Wrapped commit description to 72 characters.
 - Fixed duplicate submission issues.

 drivers/staging/rtl8723bs/core/rtw_pwrctrl.c | 1 +
 1 file changed, 1 insertion(+)


diff --git a/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c b/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c
index 666e241704d9..bd295bdd73f6 100644
--- a/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c
+++ b/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c
@@ -991,6 +991,7 @@ void rtw_free_pwrctrl_priv(struct adapter *adapter)
 inline void rtw_set_ips_deny(struct adapter *padapter, u32 ms)
 {
 	struct pwrctrl_priv *pwrpriv = adapter_to_pwrctl(padapter);
+
 	pwrpriv->ips_deny_time = jiffies + msecs_to_jiffies(ms);
 }
 
-- 
2.47.3