From: Sergey Matyukevich <geomatsi@gmail.com>
To: thecharlesjenkins@gmail.com
Cc: Shuah Khan <shuah@kernel.org>, Paul Walmsley <pjw@kernel.org>,
Palmer Dabbelt <palmer@dabbelt.com>,
Andy Chiu <andybnac@gmail.com>, Deepak Gupta <debug@rivosinc.com>,
linux-kselftest@vger.kernel.org, linux-riscv@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/4] selftests: riscv: Add braces around EXPECT_EQ()
Date: Tue, 10 Mar 2026 11:17:50 +0300 [thread overview]
Message-ID: <aa_Trj0T53wMjKfk@curiosity> (raw)
In-Reply-To: <20260309-fix_selftests-v2-2-9d5a553a531e@gmail.com>
On Mon, Mar 09, 2026 at 06:52:11PM -0700, Charlie Jenkins via B4 Relay wrote:
> From: Charlie Jenkins <thecharlesjenkins@gmail.com>
>
> EXPECT_EQ() expands to multiple lines, breaking up one-line if
> statements. This issue was not present in the patch on the mailing list
> but was instead introduced by the maintainer when attempting to fix up
> checkpatch warnings. Add braces around EXPECT_EQ() to avoid the error
> even though checkpatch suggests them to be removed:
>
> validate_v_ptrace.c:626:17: error: ‘else’ without a previous ‘if’
>
> Fixes: 3789d5eecd5a ("selftests: riscv: verify syscalls discard vector context")
> Fixes: 30eb191c895b ("selftests: riscv: verify ptrace rejects invalid vector csr inputs")
> Fixes: 849f05ae1ea6 ("selftests: riscv: verify ptrace accepts valid vector csr values")
> Signed-off-by: Charlie Jenkins <thecharlesjenkins@gmail.com>
> ---
> tools/testing/selftests/riscv/vector/validate_v_ptrace.c | 15 +++++++++------
> 1 file changed, 9 insertions(+), 6 deletions(-)
Reviewed-and-Tested-by: Sergey Matyukevich <geomatsi@gmail.com>
Thanks,
Sergey
next prev parent reply other threads:[~2026-03-10 8:17 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-10 1:52 [PATCH v2 0/4] selftests: riscv: Fix compilation issues for v_ptrace and cfi Charlie Jenkins via B4 Relay
2026-03-10 1:52 ` [PATCH v2 1/4] selftests: riscv: Add definition of BIT() macro Charlie Jenkins via B4 Relay
2026-03-10 8:18 ` Sergey Matyukevich
2026-03-21 0:48 ` Paul Walmsley
2026-03-21 0:53 ` Paul Walmsley
2026-03-10 1:52 ` [PATCH v2 2/4] selftests: riscv: Add braces around EXPECT_EQ() Charlie Jenkins via B4 Relay
2026-03-10 3:50 ` Joe Perches
2026-03-10 8:17 ` Sergey Matyukevich [this message]
2026-03-21 0:24 ` Paul Walmsley
2026-03-10 1:52 ` [PATCH v2 3/4] riscv: ptrace: Fix BIT() compilation issues Charlie Jenkins via B4 Relay
2026-03-10 2:58 ` Deepak Gupta
2026-03-21 0:53 ` Paul Walmsley
2026-03-10 1:52 ` [PATCH v2 4/4] selftests: riscv: Add license to cfi selftest Charlie Jenkins via B4 Relay
2026-03-10 2:58 ` Deepak Gupta
2026-03-21 0:54 ` Paul Walmsley
2026-03-21 5:20 ` [PATCH v2 0/4] selftests: riscv: Fix compilation issues for v_ptrace and cfi patchwork-bot+linux-riscv
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aa_Trj0T53wMjKfk@curiosity \
--to=geomatsi@gmail.com \
--cc=andybnac@gmail.com \
--cc=debug@rivosinc.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=pjw@kernel.org \
--cc=shuah@kernel.org \
--cc=thecharlesjenkins@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox