From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0B70C34D917 for ; Tue, 10 Mar 2026 08:17:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773130677; cv=none; b=JnYBOhYXabMKj1FvKenopbyWubFQHCNe7j48KyYYkHBn4wUM5rX9vwCP0eEL/pmk/4CGDYTzXLcWIuL0ZiM6cwVwJYild1qFsV0jfMXnIiWhqVnKoy0YldAO2i4UxD4hzzmJEliJle4c5dGm3hqVnALGl7KSMw0VpA6OhJXj3MQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773130677; c=relaxed/simple; bh=YjbCLYKxIgLG4H1rEPcYNeJtnFYaZe6aQavV8w1OugE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=mdc80tTyqKCs+btRaxs/54BkYdnOXO98VQfSZY3fPXQqOE/Vn3lCfq8sGAm7BrbScfUkJmzJru7039LolOCLjUJbZ9dvbBXKfcdnb893AEKGhNzHGuGp/bkdhnUFFZGdGUNNq4VEFWipu4OGxH9S+kp39We/50y/eNvhJVgD9+E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=iD3DLgB2; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="iD3DLgB2" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-4852f73d0a3so23531765e9.3 for ; Tue, 10 Mar 2026 01:17:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773130674; x=1773735474; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=MO3msijVzQef0Ud33m7vixv95BaMpuOqd6DBMK2avXw=; b=iD3DLgB2G3Hv9usoaY4MxTkJVrP5XYaSa380+Yiqnf0WdlVIZ/Yxz5JGjGKtT7d5tz Nyp6I9scOxIlteWhBdwhAvfkAUDJyDveps8HRkrFm2WdvHmeol0OMvgJelhi6/lqAPQI l/AO/N1izzvGLEBhGXsaa/Rdb/oeUoexosLD7qCxNFd666eE7XKxx3aKBtaOUkN3vkbb /+jRoSkGwz6fvPsWNPDp4qIvM+oiVnatwX2T3QzFs6g+R2ybtAZ3coFNnsch84lVV8DX sIlcpHF5qAwIPRJ/ehbYRumaDUzX/UmLaaed/B2Dzf/mk3R1jVa7pBkH6oqprlpNpGkH PqBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773130674; x=1773735474; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=MO3msijVzQef0Ud33m7vixv95BaMpuOqd6DBMK2avXw=; b=j/xtg2PeIfwMns8wHzN+vsNPQ5ELETR3zZNxHOE/cEysE+k047IOSZRUnfpo6e4s0T DWuf3WHkotHbuEBgXeY47QZMg3tzwaQF4IPRzXiy8nwSRxdol1LWBiZh2S+4ASNbld3l PWZ7HN7OyWHsO+nTqcQKm/XwGAHgiFcs9klBqISWi+8X8ygsd6OSLRuQ9GHmixUFM8nm uNUkCfirbHTuP9+xDLP+mGB3qlYHmsaQfyj3rmPGMspRhzH2UtjYbKuJd3OPh+erVe3C oX0jzUsr1BEgw94os10S/2LBZefPyaFf+KtAjhmI9a55S/cQOqjdPBA9QGMrdtBW91b8 U4Fw== X-Forwarded-Encrypted: i=1; AJvYcCXdtma1ND0IdOo9FOBgoWOhdNWr7UYS1uZZuYykAUNiToDNKTbkNI5Bx70yIj2Gyrt6Un03AdMJiS4BO/8=@vger.kernel.org X-Gm-Message-State: AOJu0YzCVesEWuoqG92mIw93QLPsnUOiATN1SKqN8besYAw6WwwMdWw2 5QA6YJqF74hvcFknMDLDNZ2gtR60phcjUMoxDTr0PzL1jhzLcjO3qmFT X-Gm-Gg: ATEYQzzwUQO0BUlkhM5U7QI7E6MgZ0Dc07ZfJL7Mx84EZQl5g4b4mMpJPF/v+OiQPaT xgy8Z9WQGuXsCfv8FziKhAEH9GP2W4tQoFvdomDx3il4mSbeZ8SU+s7vT/XCsEOH9Oc24k9Hb3B GRQYZ0NmnmVxr+qxzmKmzd8bes940ht+a52x4C10ixQjnZnThGzAaOa4jZhx7CZ3p1s/vE8r/uw yE/7ey35zJvwQenlUfe3EwR/sgQYLzmDa3XG24druTuS5Xwm98lgc+FozKdFLFgh71nv41XfMgV NqvSvgYermzE+qoXuKucwmohO362PAVCzBgtQ+akIwD2JIwXWIScRhdDreD29N7PncNPx6RD2r5 2xF+2xwkH+oJJQ0e5EpWJSrWZbYYWvmLfff6u76Q0w7E7rVKGY+CbAejVt39fIjrWRi/ZwcURrw +c66Q84+o3RrLLGTmG X-Received: by 2002:a05:600c:c107:b0:485:3eba:ab96 with SMTP id 5b1f17b1804b1-4853ebab021mr60513855e9.3.1773130673962; Tue, 10 Mar 2026 01:17:53 -0700 (PDT) Received: from curiosity ([80.211.22.60]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4853588758fsm109596125e9.4.2026.03.10.01.17.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Mar 2026 01:17:53 -0700 (PDT) Date: Tue, 10 Mar 2026 11:17:50 +0300 From: Sergey Matyukevich To: thecharlesjenkins@gmail.com Cc: Shuah Khan , Paul Walmsley , Palmer Dabbelt , Andy Chiu , Deepak Gupta , linux-kselftest@vger.kernel.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/4] selftests: riscv: Add braces around EXPECT_EQ() Message-ID: References: <20260309-fix_selftests-v2-0-9d5a553a531e@gmail.com> <20260309-fix_selftests-v2-2-9d5a553a531e@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260309-fix_selftests-v2-2-9d5a553a531e@gmail.com> On Mon, Mar 09, 2026 at 06:52:11PM -0700, Charlie Jenkins via B4 Relay wrote: > From: Charlie Jenkins > > EXPECT_EQ() expands to multiple lines, breaking up one-line if > statements. This issue was not present in the patch on the mailing list > but was instead introduced by the maintainer when attempting to fix up > checkpatch warnings. Add braces around EXPECT_EQ() to avoid the error > even though checkpatch suggests them to be removed: > > validate_v_ptrace.c:626:17: error: ‘else’ without a previous ‘if’ > > Fixes: 3789d5eecd5a ("selftests: riscv: verify syscalls discard vector context") > Fixes: 30eb191c895b ("selftests: riscv: verify ptrace rejects invalid vector csr inputs") > Fixes: 849f05ae1ea6 ("selftests: riscv: verify ptrace accepts valid vector csr values") > Signed-off-by: Charlie Jenkins > --- > tools/testing/selftests/riscv/vector/validate_v_ptrace.c | 15 +++++++++------ > 1 file changed, 9 insertions(+), 6 deletions(-) Reviewed-and-Tested-by: Sergey Matyukevich Thanks, Sergey