From: Ram Prakash Gupta <quic_rampraka@quicinc.com>
To: Krzysztof Kozlowski <krzk@kernel.org>,
Ulf Hansson <ulf.hansson@linaro.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
Bjorn Andersson <andersson@kernel.org>,
"Konrad Dybcio" <konradybcio@kernel.org>
Cc: <linux-mmc@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <linux-arm-msm@vger.kernel.org>,
<dmitry.baryshkov@oss.qualcomm.com>, <quic_pragalla@quicinc.com>,
<quic_sayalil@quicinc.com>, <quic_nitirawa@quicinc.com>,
<quic_bhaskarv@quicinc.com>, <kernel@oss.qualcomm.com>,
Sachin Gupta <quic_sachgupt@quicinc.com>
Subject: Re: [PATCH v5 1/4] dt-bindings: mmc: Add dll-presets values for HS400 and HS200 modes
Date: Wed, 22 Oct 2025 12:17:24 +0530 [thread overview]
Message-ID: <aaa3c616-a317-7a87-e6ef-82ebbb06d67d@quicinc.com> (raw)
In-Reply-To: <20251020-talented-inquisitive-bulldog-64aba0@kuoka>
On 10/20/2025 3:39 PM, Krzysztof Kozlowski wrote:
> On Tue, Oct 14, 2025 at 02:06:46AM +0200, Krzysztof Kozlowski wrote:
>> On 13/10/2025 16:53, Ram Prakash Gupta wrote:
>>> From: Sachin Gupta <quic_sachgupt@quicinc.com>
>>>
>>> Document the 'dll-presets' property for MMC device tree bindings.
>>> The 'dll-presets' property defines the DLL configurations for HS400
>>> and HS200 modes.
>>>
>>> QC SoCs can have 0 to 4 SDHCI instances, and each one may need
>>> different tuning.
>>>
>>> Signed-off-by: Sachin Gupta <quic_sachgupt@quicinc.com>
>>> Signed-off-by: Ram Prakash Gupta <quic_rampraka@quicinc.com>
>>> ---
>>> Documentation/devicetree/bindings/mmc/sdhci-msm.yaml | 5 +++++
>>> 1 file changed, 5 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml b/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml
>>> index 594bd174ff21..f7b3b1ced3ce 100644
>>> --- a/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml
>>> +++ b/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml
>>> @@ -138,6 +138,11 @@ properties:
>>> $ref: /schemas/types.yaml#/definitions/uint32
>>> description: platform specific settings for DLL_CONFIG reg.
>>>
>>> + qcom,dll-presets:
>>> + maxItems: 10
>>> + $ref: /schemas/types.yaml#/definitions/uint32-array
>>> + description: platform specific settings for DLL registers.
>> One of my questions, never answered in original submission and in your
>> versions, was to see the DTS user of it. I still do not see the DTS user.
> There is no answer, so I mark the patch as changes requested.
>
> Best regards,
> Krzysztof
ok, I will provide this in next patchset.
Thanks,
Ram
>
next prev parent reply other threads:[~2025-10-22 6:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-13 14:53 [PATCH v5 0/4] mmc: sdhci-msm: Rectify DLL programming sequence for SDCC Ram Prakash Gupta
2025-10-13 14:53 ` [PATCH v5 1/4] dt-bindings: mmc: Add dll-presets values for HS400 and HS200 modes Ram Prakash Gupta
2025-10-14 0:06 ` Krzysztof Kozlowski
2025-10-20 10:09 ` Krzysztof Kozlowski
2025-10-22 6:47 ` Ram Prakash Gupta [this message]
2025-10-13 14:53 ` [PATCH v5 2/4] mmc: sdhci-msm: Add core_major, minor to msm_host structure Ram Prakash Gupta
2025-10-13 14:53 ` [PATCH v5 3/4] mmc: sdhci-msm: Add device tree parsing logic for DLL settings Ram Prakash Gupta
2025-10-15 18:28 ` Adrian Hunter
2025-10-13 14:53 ` [PATCH v5 4/4] mmc: sdhci-msm: Rectify DLL programming sequence for SDCC Ram Prakash Gupta
2025-10-16 6:24 ` Adrian Hunter
2025-10-22 6:45 ` Ram Prakash Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aaa3c616-a317-7a87-e6ef-82ebbb06d67d@quicinc.com \
--to=quic_rampraka@quicinc.com \
--cc=adrian.hunter@intel.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=kernel@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=quic_bhaskarv@quicinc.com \
--cc=quic_nitirawa@quicinc.com \
--cc=quic_pragalla@quicinc.com \
--cc=quic_sachgupt@quicinc.com \
--cc=quic_sayalil@quicinc.com \
--cc=robh@kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox