From: Catalin Marinas <catalin.marinas@arm.com>
To: Josh Law <hlcj1234567@gmail.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Will Deacon <will@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Josh Law <objecting@objecting.org>
Subject: Re: [PATCH 1/2] arm64: lib: xor-neon: remove redundant filename comment
Date: Tue, 3 Mar 2026 10:50:36 +0000 [thread overview]
Message-ID: <aaa8_DhVHZfGBBS7@arm.com> (raw)
In-Reply-To: <71ef2e5a-1c6c-42df-9aac-17185bf92ad3@gmail.com>
On Mon, Mar 02, 2026 at 04:01:45PM +0000, Josh Law wrote:
> 2 Mar 2026 13:52:07 Christoph Hellwig <hch@infradead.org>:
> > On Sun, Mar 01, 2026 at 03:28:19PM +0000, Josh Law wrote:
> >> The filename in the header comment is redundant and not recommended
> >> by Linux kernel coding style.
> >
> > I have a pretty big series pending that changes this file in
> > meaninful ways. But even without that please never send standalone
> > patches for trivial cleanups like this, only do them if you have to
> > touch the code for another reason anyway.
>
> Hello Cristoph, I am sorry, again
> Since I am new to Linux kernel development
> I sometimes make mistakes, it's normal.
> Patch 2 should be more relevant, all of those I got under checkpatch.pl
Patch 2 is not relevant either. Unnecessary change that will make things
harder to backport, conflict with other changes.
Please don't run checkpatch.pl on existing code, only on new patches
before they are upstreamed.
--
Catalin
prev parent reply other threads:[~2026-03-03 10:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-01 15:28 [PATCH 1/2] arm64: lib: xor-neon: remove redundant filename comment Josh Law
2026-03-01 15:28 ` [PATCH 2/2] arm64: lib: xor-neon: fix pointer spacing for __restrict Josh Law
2026-03-02 13:52 ` [PATCH 1/2] arm64: lib: xor-neon: remove redundant filename comment Christoph Hellwig
2026-03-02 16:01 ` Josh Law
2026-03-03 10:50 ` Catalin Marinas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aaa8_DhVHZfGBBS7@arm.com \
--to=catalin.marinas@arm.com \
--cc=hch@infradead.org \
--cc=hlcj1234567@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=objecting@objecting.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox