From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id B5A0D390987 for ; Tue, 3 Mar 2026 10:50:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772535047; cv=none; b=T8AYdGE4nrFW7CL00AXA8J9cQes4tZ0EWyxrBu+VG1ItSsep//WHbHVtm9G+ZoZSQ9h7iVfjiVsEhOtJN9eNPZ4oR6KdOe6rf64EZRrLO1BUhyAZF7zC7zwR7PPtj4HVpvARSHNxKcWgLExd0jzJYRVYPl7G2bnCvJ6fKKDqc4U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772535047; c=relaxed/simple; bh=6WfMGt0d53AitnI68s9dB0JdYyAiBR9+Xn3Fq7aCwDo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Bx/o/+995xIwzU+CKPxW3wp+Ks7ZUu90vRtMitoOIrsjxxhddsnal/VRT9NWdVy+2KBO1pvf+x1gscOZvj0UhesCRp/NAsrTn+kdBBlu7upSNB0Q1G60T2XqJWKACHAzV1KfxNGL6GZf/ROkxc2btpyEn9xofBZB2zh6xGhe2Ys= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id AF577497; Tue, 3 Mar 2026 02:50:33 -0800 (PST) Received: from arm.com (usa-sjc-mx-foss1.foss.arm.com [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 25DF53F7BD; Tue, 3 Mar 2026 02:50:39 -0800 (PST) Date: Tue, 3 Mar 2026 10:50:36 +0000 From: Catalin Marinas To: Josh Law Cc: Christoph Hellwig , Will Deacon , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Josh Law Subject: Re: [PATCH 1/2] arm64: lib: xor-neon: remove redundant filename comment Message-ID: References: <20260301152820.2589291-1-objecting@objecting.org> <71ef2e5a-1c6c-42df-9aac-17185bf92ad3@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <71ef2e5a-1c6c-42df-9aac-17185bf92ad3@gmail.com> On Mon, Mar 02, 2026 at 04:01:45PM +0000, Josh Law wrote: > 2 Mar 2026 13:52:07 Christoph Hellwig : > > On Sun, Mar 01, 2026 at 03:28:19PM +0000, Josh Law wrote: > >> The filename in the header comment is redundant and not recommended > >> by Linux kernel coding style. > > > > I have a pretty big series pending that changes this file in > > meaninful ways.  But even without that please never send standalone > > patches for trivial cleanups like this, only do them if you have to > > touch the code for another reason anyway. > > Hello Cristoph, I am sorry, again > Since I am new to Linux kernel development > I sometimes make mistakes, it's normal. > Patch 2 should be more relevant, all of those I got under checkpatch.pl Patch 2 is not relevant either. Unnecessary change that will make things harder to backport, conflict with other changes. Please don't run checkpatch.pl on existing code, only on new patches before they are upstreamed. -- Catalin