From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7B59535898 for ; Tue, 3 Mar 2026 06:58:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772521088; cv=none; b=Igtd1Tp3l6PC2zPATTphTP6RVP6m6dloDvozYoVLgDcXmgee7AwjMwHMO3hX1ep1EMxDhb8TiNzIzFTpwAXqT1V4D4CqYA6eDZbMloQ2uCjLxnA6jkZGb/D3mNUsUAjm4w9vKEco4kNEVF8wk5UsF99Zd4TqiTDMhT6WsAC8peE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772521088; c=relaxed/simple; bh=D2Yfujhx6iSDuZ83eJlmYUy8xlVHiP48gwcfLTirYCU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ild5wqjMZ0U4xoURiPHFBK+sFVYYZ4nrRzK1JDxH6nCns7Jq2l9vA2frTX3964bUaIphQIOaZFm8weccIpj0aB/WmU6cwO2mU39NnMTaKwYtzheIExousQTexS6vmvxgcGZijF5Lu9yCf5IWqR1KoQvqUNCzfVcl62gcXLfWlho= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=DtabyLp+; arc=none smtp.client-ip=209.85.221.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="DtabyLp+" Received: by mail-wr1-f45.google.com with SMTP id ffacd0b85a97d-439a89b6fd0so2394043f8f.2 for ; Mon, 02 Mar 2026 22:58:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1772521086; x=1773125886; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=yNDJLLeSJmwJKOPj1eJd/1ZsJIZjKzORivaRrmEhEJY=; b=DtabyLp+5xGSJyiJAEwifrVrzLO2XpO9VMJur68Gz3AUf/DrkrVmwdWv/bLF5lUjG8 NuJ9QD7Suk9OKAckDBMm/v5FgKGHrcTTTch8L+D9xSsV51ZkUWdDLPehVKt9gpbQIgY/ lp+52oUXirrBy5oOjJfmzffPElDhgVToTetN9AUUPM3oC/f1kgRm2KHv4ch7LeBAENF+ RJ288tZAqWcPStpU6EYwoi+Ryppx0W/bFWPXEAAc2lYebxShYlOYRu7NbIzt4ol/mcst 68k0fujFAddLj8jLTFqPJkCaaehRQtfdRPRgmKvtpkDOvxmnVJ8qOX/TSacqYiZAr6Ix JR0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772521086; x=1773125886; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yNDJLLeSJmwJKOPj1eJd/1ZsJIZjKzORivaRrmEhEJY=; b=EQVR+lfdcV4czR0hmgVdX0bMNQ329tGwR7wjaEheYh9OMgmd6Y3LAyct2e/1Yzrmro 0bId4cakxqdf02IjM6KPFwTQtm15dzD1vcOD9bgEWNvjZvTTg8ru8E6Ko5efkNBkfgi2 9ZWz9uUhzWW6sAQ0JR5+7cz/m8b+9iCqE5ykuBpYy/LAcaT7rznG2zIT3g0bnLbFg5R+ UEpNvrSRQiNNcc8wgqAZXSUD31YO4YL0A4tpOjDmxG6h592Hcu2897OhlQSnUrWD6+wI /hrBl7b+0xqyUSGMys+CBh0OYGRkDiOt9OP4tXLOn18NEK/VM3GeCYxJ5MO8NI4xiG5M ggMA== X-Forwarded-Encrypted: i=1; AJvYcCXDtbu0Rf8VbLKD4votxdn6jMiEwp/KRaKMS7/Y/lq+45HLq4x68dHzrGcdAxHtFX1xGUlgZE47Wcdsvlo=@vger.kernel.org X-Gm-Message-State: AOJu0YyTIB4Fl6JlWysIOZhnTcD56okO4e/nvYQ0X0WxJ9VJ6U5VoYSn +usIpP1ze8+kbfcDoORc5f/LmdF6jCM71wQ9ZaXrf8Pr42ocLyrgHoh5sle5r7jj6eI= X-Gm-Gg: ATEYQzwcME1jCSGwuQ6KDZ/XUrCIMAk4PIVMPVvlONpRqMqfg0tYMqkJ13pQ1noIvXu azVhdFY57+Cxikp6VZW9IaY+fNvUiswL/AO7nag8v4pJspNgBUgcCTXjFq13XiSpuiU37Aerd1l 5LQEseO8crcUrgccPrYdzseCJNo3+h2jaSvzeyfs4Afw36iGI8Ek+tDbJYC5PFNqXCdZVpWiVPY sUB+kiO88xMA60mjdcTKxoP4ERgzs67jbjUmpXqdggOLZRXY8wgU0aimq7ju37KwVOSyltgIX5h cU++w0fDU+ymOF0jFvkgjMNkgWrHRt8j77yg/pEg7Y8EDqh44U9JM8N1Z+1J8sWKMtzbMNd7m5U 10waixtOXuV3PtESdi8zqVOcjRZU59O2MxCLsf8KI/8IJmEGS0wkvFHYcQN83PL57I8KdwOfODD w/05P8JKzRIIk4dyR2gBig53jk6SNh X-Received: by 2002:a05:6000:4312:b0:439:bf55:f5ec with SMTP id ffacd0b85a97d-439bf55f749mr3448556f8f.50.1772521085733; Mon, 02 Mar 2026 22:58:05 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4399c765c38sm31809353f8f.31.2026.03.02.22.58.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Mar 2026 22:58:05 -0800 (PST) Date: Tue, 3 Mar 2026 09:58:01 +0300 From: Dan Carpenter To: Josh Law Cc: Greg Kroah-Hartman , Ovidiu Panait , Gabriel Shahrouzi , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Josh Law Subject: Re: [PATCH v2 05/10] staging: axis-fifo: improve IRQ handler Message-ID: References: <20260301214815.2628942-1-objecting@objecting.org> <20260301214815.2628942-5-objecting@objecting.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260301214815.2628942-5-objecting@objecting.org> On Sun, Mar 01, 2026 at 09:48:10PM +0000, Josh Law wrote: > From: Josh Law > > Return IRQ_NONE when no interrupts were triggered to avoid spurious > interrupt storms, and only clear the active interrupts instead of > blindly clearing all interrupts by writing 'intr' to the ISR instead of > XLLF_INT_CLEAR_ALL. > XLLF_ISR_OFFSET is the IRQs which are triggered and XLLF_IER_OFFSET are the IRQs that we care about. The intr variable is the IRQs which are both, they are triggered and we care about them. In the original code it clears out all the IRQs that have triggered regardless of whether or not we care about them. You're saying clearing all the IRQs "blindly" is wrong, but to me it feels like the correct behavior. In real life it probably doesn't matter at all since we probably care about all the IRQs. And apparently in your testing it makes no difference either way... I feel like leaving the flags set feels like it would be more likely to trigger and IRQ storm. But we're debating the number of angels dancing on a pin. Let's just leave it as-is unless we can show it helps. regards, dan carpenter