From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4C9BC433EF for ; Fri, 11 Feb 2022 04:50:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244157AbiBKEuK (ORCPT ); Thu, 10 Feb 2022 23:50:10 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:41922 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229540AbiBKEuF (ORCPT ); Thu, 10 Feb 2022 23:50:05 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 8E01A25D7 for ; Thu, 10 Feb 2022 20:50:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1644555003; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dTN6FickAcVPgVjW2UUCx0PlKyGKDjTzkZ/0MQ6fTqs=; b=Z8i4tThqiQM0z95hsb0AunDuM5bg4X/wlrSmZTeI5ZJ30zcLG+HfpWjIqrdLnCZMkUdHqx UBtAG+Rl0P1usA4GNdnJ4Jbd/R2gFxinmha9gAp7oeQtxh9sww9p5QLeBzqbynC8SnfvAK Pswz0i4BA9C9Js/++FUG/ghdHw07nHc= Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-501-rjBgemJ0OxeCLx6C97nC0g-1; Thu, 10 Feb 2022 23:50:02 -0500 X-MC-Unique: rjBgemJ0OxeCLx6C97nC0g-1 Received: by mail-qt1-f199.google.com with SMTP id a28-20020ac84d9c000000b002d05c958a84so6065072qtw.0 for ; Thu, 10 Feb 2022 20:50:02 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=dTN6FickAcVPgVjW2UUCx0PlKyGKDjTzkZ/0MQ6fTqs=; b=cSoxoMAu02hroCqCSuRdPtBwR6VLOC0pnG21xrL7Q8d+gYe5rToNGGGS2NU17BeNzD P4v2IEkXv94Zj3W+9tldu/ox3owyRNTV8yEoXoVL/2mFP6ABqEgbDLhVwyBSrjxskyMt th9aHo1RlG7loibQmfV6MokGvPvyxf7LbNg7RkbgjsUekNDw22wH36yueyKfx8r6U1cw r3JcADaYuvtXRBZLZb41e2JmVdw2YbahBwfeBS9SrKbiFl1yWm9Bdjy98PzyZd4QsKeQ Kk7Jxr5v71CG/C9pUiJ8BNK6GgCgLATZn1Bz6W6dIl1atCcvwgKn1hiwyu1qXTUZ2Ptp Y8Jw== X-Gm-Message-State: AOAM530LUJcSxurC5uUIpYDJflghOYUi7D5CtpWi+9LpEbrYueFDpixS ZVnMnaj08xcUhA3+u47/0aBt0s164Uwn6NHRm9x1KeWaEd/YUUX5/hQYNSCD4fMoI6zN3tn2bzM vsVF7E1J9Abjne+39c0uUiwrB X-Received: by 2002:a05:622a:5ce:: with SMTP id d14mr7366625qtb.7.1644555001917; Thu, 10 Feb 2022 20:50:01 -0800 (PST) X-Google-Smtp-Source: ABdhPJx7bVqaMXRkOzVf++7UD3m0x4aXle0i8TevJDeQKqz/0UREQhvZ7AVvKjH9oIg1JO06qDwrkA== X-Received: by 2002:a05:622a:5ce:: with SMTP id d14mr7366622qtb.7.1644555001709; Thu, 10 Feb 2022 20:50:01 -0800 (PST) Received: from localhost.localdomain (024-205-208-113.res.spectrum.com. [24.205.208.113]) by smtp.gmail.com with ESMTPSA id bp18sm3323284qtb.72.2022.02.10.20.49.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 10 Feb 2022 20:50:01 -0800 (PST) Subject: Re: [PATCH] spi: Fix warning for Clang build To: =?UTF-8?B?TGggS3VvIOmDreWKm+ixqg==?= , Mark Brown , Li-hao Kuo Cc: "linux-spi@vger.kernel.org" , "linux-kernel@vger.kernel.org" , =?UTF-8?B?V2VsbHMgTHUg5ZGC6Iqz6aiw?= References: <691d52b72f978f562136c587319852f5c65f08fe.1644460444.git.lhjeff911@gmail.com> <99ab624e2af4414bb2a785f64f35bd95@sphcmbx02.sunplus.com.tw> From: Tom Rix Message-ID: Date: Thu, 10 Feb 2022 20:49:58 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <99ab624e2af4414bb2a785f64f35bd95@sphcmbx02.sunplus.com.tw> Content-Type: text/plain; charset=big5; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/10/22 7:32 PM, Lh Kuo ³˘¤Oğ¨ wrote: >> The return here means that the initialization is now redundant and will stop the compiler spotting any >> future similar issues which isn't ideal. > I got it, so do I need to submit a new patch? Assuming yes, so something else.. Looking again at the function, there are 3 sets of if-check blocks these could be combined into the first one. The later two are variations on is this an rx or a tx, the first check does that. T > >