From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44591C433E0 for ; Sat, 16 May 2020 02:59:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1E82D20728 for ; Sat, 16 May 2020 02:59:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="tSZQ862Q" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727999AbgEPC7H (ORCPT ); Fri, 15 May 2020 22:59:07 -0400 Received: from mail26.static.mailgun.info ([104.130.122.26]:61964 "EHLO mail26.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726247AbgEPC7G (ORCPT ); Fri, 15 May 2020 22:59:06 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1589597946; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=vAHRZO2aoumgoKX5GjqHJFJCsrd29AsXO2S+dqIqaKk=; b=tSZQ862Qz8L83QMflslATfkssGOTMYhFA+iSEf9HEhHTXeQBoYbPLINEgQ7hbF89AkJLfgDr 00aGyyTTb9BkSWqiITbhZbDSCMc/+t8I6rlylNvHz37KnuYkyJCvDTpvdj4DGarUOm7mSBnF fTaO/hw/R1AjQRoggIx2TZ2gl6E= X-Mailgun-Sending-Ip: 104.130.122.26 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n02.prod.us-east-1.postgun.com with SMTP id 5ebf56e1aefa5a01cc046e39 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Sat, 16 May 2020 02:58:41 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 822EBC432C2; Sat, 16 May 2020 02:58:40 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: bbhatt) by smtp.codeaurora.org (Postfix) with ESMTPSA id F1ED0C433D2; Sat, 16 May 2020 02:58:39 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Fri, 15 May 2020 19:58:39 -0700 From: bbhatt@codeaurora.org To: Jeffrey Hugo Cc: manivannan.sadhasivam@linaro.org, hemantk@codeaurora.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kernel-owner@vger.kernel.org Subject: Re: [PATCH] bus: mhi: core: Use current ee in intvec handler In-Reply-To: <1589509049-14532-1-git-send-email-jhugo@codeaurora.org> References: <1589509049-14532-1-git-send-email-jhugo@codeaurora.org> Message-ID: X-Sender: bbhatt@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020-05-14 19:17, Jeffrey Hugo wrote: > The intvec handler stores the caches ee in a local variable for use in > processing the intvec. It should instead use the current ee which is > read at the beginning of the intvec incase that the intvec is related > to > an ee change. Otherwise, the handler might make the wrong decision > based on an incorrect ee. > > Fixes: 3000f85b8f47 (bus: mhi: core: Add support for basic PM > operations) > Signed-off-by: Jeffrey Hugo > --- > drivers/bus/mhi/core/main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/bus/mhi/core/main.c b/drivers/bus/mhi/core/main.c > index 7272a5a..0a41fe5 100644 > --- a/drivers/bus/mhi/core/main.c > +++ b/drivers/bus/mhi/core/main.c > @@ -386,8 +386,8 @@ irqreturn_t mhi_intvec_threaded_handler(int > irq_number, void *dev) > write_lock_irq(&mhi_cntrl->pm_lock); > if (MHI_REG_ACCESS_VALID(mhi_cntrl->pm_state)) { > state = mhi_get_mhi_state(mhi_cntrl); > - ee = mhi_cntrl->ee; > mhi_cntrl->ee = mhi_get_exec_env(mhi_cntrl); > + ee = mhi_cntrl->ee; > } > > if (state == MHI_STATE_SYS_ERR) { Hi Jeff, Let's hold off on this change for now please as we have some good set of bug fixes and improvements coming in very soon. They're only pending post to LKML. Thanks