From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [78.32.30.218]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AE595480978; Tue, 3 Mar 2026 15:13:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=78.32.30.218 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772550791; cv=none; b=LaG23/3IwsMX/Az6HGXvzzL80aMhY6+0vMmZbrr3XifFkv1HCMGvMarw8G2E3/Qn8dJGpm/fCVY/cvHMz0e5koMAz525jJBoUJywRm88oPdg8AdKPHRw+a4g/UBovNb1t1uAZwomu2sGNI4MJse1IbvMnEQbGIrwNBJhJaw1j74= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772550791; c=relaxed/simple; bh=ZUuBdXlabAKnNnIZ3Gl8Tm4xd9RNOR5maKUH0bsKVbY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=JKJOzd1TVCHXC2nCg8sCEVlu+eXgGEmiLqZuwyRur3jHGEsmb7APaxNfe22WXdtSHEWHlHMrQSqNOdYpblETGk9IcIdaIimx8k45iJcb+/nqHUvXvHy3gRiA+5nINsF4vAVI3YFlCHizuK6Y7vxJAO+Gl5UZo0HikhC6mATMdrg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=armlinux.org.uk; spf=none smtp.mailfrom=armlinux.org.uk; dkim=pass (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b=tm7jhcaD; arc=none smtp.client-ip=78.32.30.218 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=armlinux.org.uk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="tm7jhcaD" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=rSM3jEZffCw3A4oMljmCNtPxUoaBFLdJTlI4x5TlvQM=; b=tm7jhcaDdh9zeIBPtz6c+Il+8a Zk3vnR9L7eL8Q4f4X7FCo3R0j+x8RqlDKPw1ad6eeV4gaosRV0lB+8NcdhzczrAAushj3oq0VMsl6 Kj2e0sLArVNSevmBEkE2unbjE/3VOR1f2n4FM0NdYP58ahNiL4VhcwWNGowap1jivHb9rZF4kQV/W 39/CKoUpv5MgkaJoBPlZfj37JF0X34hYD9zQEEqeQMM0wplbPU3J4dvpW0UxsqQtqWNd2AZgHV/Rn iG3qeNxOlbTpN6Wf6tgNqxc9jpdP/GuNbMN8GVeOZuDwOgXh3ui4zpEKxA5xMNUDuSWAvqb9wJMct ng3R3eFQ==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:45204) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1vxRQf-000000005Fi-2EmF; Tue, 03 Mar 2026 15:12:57 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.98.2) (envelope-from ) id 1vxRQe-0000000071z-1F3j; Tue, 03 Mar 2026 15:12:56 +0000 Date: Tue, 3 Mar 2026 15:12:56 +0000 From: "Russell King (Oracle)" To: Romain Gantois Cc: Mark Brown , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andrew Lunn , Heiner Kallweit , Liam Girdwood , Maxime Chevallier , Thomas Petazzoni , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next 2/2] net: sfp: manage receiver and transmitter regulators Message-ID: References: <20260303-sfp-regulators-v1-0-7101ae34cb84@bootlin.com> <20260303-sfp-regulators-v1-2-7101ae34cb84@bootlin.com> <2344035.iZASKD2KPV@fw-rgant> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2344035.iZASKD2KPV@fw-rgant> Sender: Russell King (Oracle) On Tue, Mar 03, 2026 at 03:40:54PM +0100, Romain Gantois wrote: > Hello Mark, > > On Tuesday, 3 March 2026 15:22:40 CET Mark Brown wrote: > > On Tue, Mar 03, 2026 at 02:54:27PM +0100, Romain Gantois wrote: > > > If phandles to receiver and/or transmitter regulators for an SFP device > > > are > > > found, enable them at probe time. > > > > The driver should unconditionally request whatever power the device > > needs. > > Ok, I'll use devm_regulator_get_enable() instead then. What Mark is suggesting will break existing users. So, I'm afraid we can't proceed with this proposal. Sorry. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!