From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f45.google.com (mail-dl1-f45.google.com [74.125.82.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 42D7539D6F1 for ; Tue, 3 Mar 2026 20:04:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772568298; cv=none; b=f/DqNKRMQ8izrCy0se4h+RBcKenrLQXiT4DTvpLvxbE54+qVNIwtrd555Oc+ScvsgTxPUTQF/y4ArJ17jkIV/3m7jNfInVF6NGH6tAJj7rrCLmhiLvGbMpgA4ejszLyTA6AYQwho8GG+gWe+i8tNr0XXoBJqf4A9jR9ZY3v1U/0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772568298; c=relaxed/simple; bh=WqioFlj+oFVWDFK9ka+TQnPUjSV/CQU/CJyshbZ5Zz4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=fI9/B/Ypy3EmOxe/wBq39wNu5kB2kvpSDweRkhqC3qdnhbw47eQMxDrLSKjxTjYq67eeZXGu8mZ6Z8UwH+xAQNMvb1PD/qv9ByFVeVBQhwDWjY9F8UkyEu+qJwxmGWXTwtpVAdk14X+Mn9QY9idWq1qETGvpGNG9Ndo/6VsBXxo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=JSwXP7/m; arc=none smtp.client-ip=74.125.82.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JSwXP7/m" Received: by mail-dl1-f45.google.com with SMTP id a92af1059eb24-12732165d1eso6594494c88.1 for ; Tue, 03 Mar 2026 12:04:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772568296; x=1773173096; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Fz+KY6uKkd+TFMj791GXA5EfreSXyJZk4nTlfifWkf8=; b=JSwXP7/m7ueTtpNN9ry5iAoAUeyvyWGFGYXTCq69ltyzeTA4DFAgMCIQvt1b1qUEEn pIMSrPEQwTNEvPtN/DsR8cKiSftbe47lU/JYf2JnoPQqaZMuu6G+Fsqhvsd7mWKQjHrC /q1T1NgEzHubCp+hZPSPcPVEv0N8QPB9YtgvlLBDo/dz04r9ndGhIiuCM+PUu5ArQgBp FuRK52UrFIa8XjQli7/2wHoXv5jjeMuCfJ1QGCtxuj6CbIgB8T6LJxKdwM0aB0jT9b9M QUwYf/h/cAspQmnmW8gS4HtJsfMuNMIIPo+n6R6iBZqwIM16HrDLzDDfLwmeqWjqGrAu K2gg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772568296; x=1773173096; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Fz+KY6uKkd+TFMj791GXA5EfreSXyJZk4nTlfifWkf8=; b=dFyV+/H8oelQomqcroCheemWidwncCX9O8Cbi28GaMpyyr+5dJHfQGv9wooFKhlLLp 8k5AKwR4gnpMkCgaRB7vLHga+gnoa0pk+WiI9C7BWM9g7j0WmoxYVDeTlg1NrE+EynOU mQsmvf99gwA1O9xk4nciOSd9IozpZMgtaa/OhzAAN5dHSr8C7a14Uv//NqAiCCHZsXZu nRKKcCJz35q9qWBMyPeMXcDj/tosIt6fY+wJfFYnggoYt0eXAgKikFQHV8wCq9hGo5UH 94G9stsdslw6Hfm2NQlUummi05QIK7xcOE+0PzVjQsR+Q9RkP92JsuNy0xMcuiaDIzRu zU3Q== X-Forwarded-Encrypted: i=1; AJvYcCWwNcwIZwSFOUKhGLOpYiMc6a2afdue+0oI4CHH54KPBg6dOSTQpRz+1++nzdhKqMTXurHH+5SJnJyjVNE=@vger.kernel.org X-Gm-Message-State: AOJu0YygN7P3HSiAaU5gd//UEiYdKLkVR42ut/Fq8Extss1jKPtn8KC5 9JgylT009BAE1d21VVnTkIr8nAvFBbm2uxyG3Y0t4OL5Z6tt/zjTHfNn X-Gm-Gg: ATEYQzylbGGjlmawVesG7tkHaiAyUVH5y0DREF+tEVJuk7Za47ohRHyxD5so7ujWKzz Yo1Yu9X/epjKNTUV09wuzA8UieMQO5maDN5iwgyZwm/pmYVay1RJbDcYJ2jAXBCUOHVkpSaFC/+ pMdhUS2YGP2yoen7chO5NgXwxgngizC9zmhXRjaDfc5wiK1U2YUD6egYnk21jxTBbAgi/xxnPky D0sd/gjP81QtDYovuRWNBcg8NWI68TIYW4MtVO+LwQlM4xWOfyR2BbGyo6Ce91giH3XA+1tPbP8 LTzb/zZltSNUppjk+ys/XLpTk5WS3+Y1GtDLcMDH90+Pu/WcKkJ8oLcILOM3yl0d2hgAKw/4w7W 5lt1bCYGkeJr8oTl73yT5C8j0c9WRImOg31zhl8ZLQmedpuXGXWTAECSDGhwZMZVPoAR4s7MOXa btQ0mJh2VdWcV88hIroQQFltsd0ibUMREqtnq9LY1VcSIAJwq+WswKINjgbVEScf64T6kMJAi7+ w8i/XGPzDb/xzY= X-Received: by 2002:a05:7022:4591:b0:123:2d9d:a90d with SMTP id a92af1059eb24-1278fc21264mr5538380c88.17.1772568296176; Tue, 03 Mar 2026 12:04:56 -0800 (PST) Received: from fedora (c-67-164-59-41.hsd1.ca.comcast.net. [67.164.59.41]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-127899eab46sm17006945c88.8.2026.03.03.12.04.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Mar 2026 12:04:55 -0800 (PST) Date: Tue, 3 Mar 2026 12:04:53 -0800 From: "Vishal Moola (Oracle)" To: "Uladzislau Rezki (Sony)" Cc: linux-mm@kvack.org, Andrew Morton , Michal Hocko , Mikulas Patocka , Baoquan He , LKML Subject: Re: [PATCH] mm/vmalloc: Fix incorrect size reporting on allocation failure Message-ID: References: <20260302114740.2668450-1-urezki@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260302114740.2668450-1-urezki@gmail.com> On Mon, Mar 02, 2026 at 12:47:39PM +0100, Uladzislau Rezki (Sony) wrote: > When __vmalloc_area_node() fails to allocate pages, the failure > message may report an incorrect allocation size, for example: > > vmalloc error: size 0, failed to allocate pages, ... > > This happens because the warning prints area->nr_pages * PAGE_SIZE. > At this point, area->nr_pages may be zero or partly populated thus > it is not valid. > > Report the originally requested allocation size instead by using > nr_small_pages * PAGE_SIZE, which reflects the actual number of > pages being requested by user. > > Signed-off-by: Uladzislau Rezki (Sony) Reviewed-by: Vishal Moola (Oracle)