From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Danilo Krummrich <dakr@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Arnd Bergmann <arnd@kernel.org>,
Bartosz Golaszewski <brgl@kernel.org>,
Hans de Goede <hansg@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/3] Allow attaching software node when registering platform devices
Date: Tue, 3 Mar 2026 07:55:34 -0800 [thread overview]
Message-ID: <aacD3_dc2lZ7bDhe@google.com> (raw)
In-Reply-To: <DGSDH9UPOXSQ.ER0SWY2L2ZQL@kernel.org>
Hi Danilo,
On Mon, Mar 02, 2026 at 03:39:51PM +0100, Danilo Krummrich wrote:
> On Mon Mar 2, 2026 at 1:42 AM CET, Danilo Krummrich wrote:
> > On Sun Mar 1, 2026 at 6:02 AM CET, Dmitry Torokhov wrote:
> >>> Unless there there is any contrary feedback from Greg or Rafael, I can pick up
> >>> the series after -rc1 is out and hand out a signed tag for the two of those.
> >>
> >> Yes, could this be applied please? I have a few patches that depend on
> >> this that I'd like to send out.
> >
> > Sorry for the delay, will do tomorrow!
>
> Again, sorry for the delay, I gave this some extra cycles to make sure Greg and
> Rafael have a chance to comment (especially since this will be shared with other
> trees).
>
> I now applied this to driver-core-testing; I will share a signed tag once I have
> the 0day result.
Thank you!
>
> I have one consideration about the
>
> if (pdevinfo->swnode && pdevinfo->properties)
> return ERR_PTR(-EINVAL);
>
> case (which I hate we can't catch at compile time). Maybe it is worth to at
> least print a warning?
I am not sure how much it will help: the setup is typically static so
the developer using this change/api will immediately run into this error
if they try to set both, users will not see it.
OTOH it is a single message...
Thanks.
--
Dmitry
next prev parent reply other threads:[~2026-03-03 15:55 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-14 2:52 [PATCH v2 0/3] Allow attaching software node when registering platform devices Dmitry Torokhov
2026-02-14 2:52 ` [PATCH v2 1/3] driver core: platform: add kerneldoc to struct platform_device_info Dmitry Torokhov
2026-02-16 13:31 ` Bartosz Golaszewski
2026-02-14 2:52 ` [PATCH v2 2/3] driver core: platform: allow attaching software nodes when creating devices Dmitry Torokhov
2026-02-16 13:31 ` Bartosz Golaszewski
2026-02-14 2:52 ` [PATCH v2 3/3] driver core: platform: fix various formatting issues Dmitry Torokhov
2026-02-16 13:31 ` Bartosz Golaszewski
2026-02-14 10:55 ` [PATCH v2 0/3] Allow attaching software node when registering platform devices Danilo Krummrich
2026-03-01 5:02 ` Dmitry Torokhov
2026-03-02 0:42 ` Danilo Krummrich
2026-03-02 14:39 ` Danilo Krummrich
2026-03-03 15:55 ` Dmitry Torokhov [this message]
2026-03-03 16:45 ` Danilo Krummrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aacD3_dc2lZ7bDhe@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=arnd@kernel.org \
--cc=brgl@kernel.org \
--cc=dakr@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hansg@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox