From: Carlos Llamas <cmllamas@google.com>
To: HONG Yifan <elsk@google.com>
Cc: Josh Poimboeuf <jpoimboe@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
kernel-team@android.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] objtool: HAVE_XXHASH test uses HOSTCFLAGS.
Date: Tue, 3 Mar 2026 18:24:38 +0000 [thread overview]
Message-ID: <aacnZknv8F0PUB_j@google.com> (raw)
In-Reply-To: <20260303010340.306164-1-elsk@google.com>
On Tue, Mar 03, 2026 at 01:03:39AM +0000, 'HONG Yifan' via kernel-team wrote:
> Previously, HAVE_XXHASH is tested by invoking HOSTCC without HOSTCFLAGS.
>
> Consider the following scenario:
>
> - The host machine has libxxhash installed
> - We build the kernel with HOSTCFLAGS containing a --sysroot that does
> not have xxhash.h (for hermetic builds)
>
> In this case, HAVE_XXHASH is set to y, but when it builds objtool with
> HOSTCFLAGS, because the --sysroot does not contain xxhash.h, the
> following error is raised:
>
> <...>/common/tools/objtool/include/objtool/checksum_types.h:12:10: fatal error: 'xxhash.h' file not found
> 12 | #include <xxhash.h>
> | ^~~~~~~~~~
>
> To resolve the error, we test HAVE_XXHASH by invoking HOSTCC with
> HOSTCFLAGS.
>
> Signed-off-by: HONG Yifan <elsk@google.com>
> ---
Reviewed-by: Carlos Llamas <cmllamas@google.com>
next prev parent reply other threads:[~2026-03-03 18:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-03 1:03 [PATCH v1] objtool: HAVE_XXHASH test uses HOSTCFLAGS HONG Yifan
2026-03-03 1:16 ` Hong, Yifan
2026-03-03 18:24 ` Carlos Llamas [this message]
2026-03-05 20:02 ` Josh Poimboeuf
2026-03-09 19:54 ` [tip: objtool/urgent] objtool: Use HOSTCFLAGS for HAVE_XXHASH test tip-bot2 for HONG Yifan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aacnZknv8F0PUB_j@google.com \
--to=cmllamas@google.com \
--cc=elsk@google.com \
--cc=jpoimboe@kernel.org \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox