From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6842238657A for ; Tue, 3 Mar 2026 18:24:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772562288; cv=none; b=lxzdN7G/5TMTK1299Zec8Q7Jkivb6vy4IL7QMQ/dqoq62vVeokwqg3PafF4lfWuURtCiQExrg7hqSuk6SyswlzWzSvvliXlh5gap+yC+OccXJElaLmNByRo2mCfZZ2lpx4FS+T3mC9eplAaKmTWQDBcjeDkk8Skyk6JJpv04Fy4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772562288; c=relaxed/simple; bh=RMvceXOiVAR7Jn57A9qn+SE17AzDwgwUiaszNbdD8Lo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=gQOIXw5e/CzOAG6mDB3O6TrSaE4o6wfqiNd31iSF8YrfgnkcIRoONPnd9AMwH1AS7sRxWUtqztU4PMMrIvTT8Kd6bQTiQuT6AJO8xalTE4109KERFxGDcjxpfAYdWWjVf0fRG0htTQLMT5m1vy/NnGTopxjkg+UVZWKBahwsrzo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=gIdH33gC; arc=none smtp.client-ip=209.85.214.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="gIdH33gC" Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-2ae49120e97so90075ad.0 for ; Tue, 03 Mar 2026 10:24:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1772562285; x=1773167085; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=0duYOuknE+yzpNPQ67a8kLR3gg72MNlIP+DWZZYJPvQ=; b=gIdH33gCXfuOUeJ4YuanEvCE3+icBESXsitexJmVSdnu8w1K9ZdzXMJAgMfEdpLRzx Hlbb5h0+4fSN1UtLSyxBmFQVCM2yZi68O/9IBd4uwSxnh5ZFFAoVnM9q1okqRYWLww2c l5pJBRGnPPziciOf1cgvs+PJTUn06Swpx0UMqap4NIR9fOgS2ct7xXGoKhPkEQthx29Z bN37saa+/iW1bsp2pfc8w3ynda+srGD9OQTFVRRFTe9TPXVp2SpylsfRfqcO77vqkhg+ wrAQsXLxrAfRDdPIOFxqVwpkRza1X4ZI1awN//EvrEFm4ToB81L98VdQh/xssF3QJDgM 7/kA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772562285; x=1773167085; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0duYOuknE+yzpNPQ67a8kLR3gg72MNlIP+DWZZYJPvQ=; b=n2if8iM0UWkG0zYNWFBoOgQD5WF2p67CGUMQOzWF0klPwE/uUgZHhh1PtbtkCR+bZs vPJBefDRjvDM2oms+WJHu5VNvBKqkN/S6tlHA4KoLncKx7dvyb3NQw3fMvRIyYdu5mUW oCleUnX0KeHmKrXAvRGFWms0L9cLGNrZb2yV8kN6J4lo821IUHJKadr+xsYLDrsEPl7U dI/JLqQdsazXbCpt6lJ+gS86xEwXBRzX1pLPPPL7c8ct/LkKsbGsgXztFbxwxqUzsrLX 0fyy9zs+ojJ9AHeS2WZ1Ikjxkq0pXaik3eCY8KNc8iLASZfyqRrfRv5w3JdLqPdU6TAF SHvQ== X-Forwarded-Encrypted: i=1; AJvYcCWNdRIDMYjCtv8ugg5iMo1GOzwZLFhDxhu6vpuBkd92ktS4plat47PRp7qHQ8YPlOsNH5tlc36FlOTeaFU=@vger.kernel.org X-Gm-Message-State: AOJu0Yyz6dRbs7ils/1Dal5LD3qEfkEzxB3XZTkNCeLVWIj49hnNuS1u BDJFNQK1YV3xn2RiFo1R/JrRyZ0bc7ai5w3B1e8LxgYJ1k3EW8WF9vpgaugjHNr/Mg== X-Gm-Gg: ATEYQzwoknA4Z3/KK5lqbkmwKNN6m4fI4dpVVfRPWyqAX8wkiW7L3e/ItDC82uIMII2 B1i0RNFyWKCGwNmkpjNnkQnGwyyTYOC2z1hRan+PtSELUY9zf0QGjrJQsGkpYc42OFeHm8n84FE gESOVcK8WutQ0y+Qk+f23MHnPMpubEFkoSRZ50DuiawfMxtQPGi7j/HBy61NrSOtHpMHwDDY2bv 4qgZRlQZR9CqxBnnkmwkl6ZWn3gWFSZSONP+opbvxN2HxCATFhmZp4glh1SwPAdv96TUw38snZD fNU+w64awZjD3mqvDe2lm6kG/v3MZ5t/o8MHyD7qEIMxPr/GQ9GaBCoIe7BZM4dYNjaJfYcgtnE NkoL7/r0G5NfPyKqfgjurCkTke1YECjf7fq9BE9tfaA5PDRmQtXUlK1O5a7KyTyHV4lDanrXgVE IUcXEim/PI7jD3BM0qs5Ct4zQBYu6Q2TNwxlpqIhR0p/jKJloZ9v/fRixRjpJc4A== X-Received: by 2002:a17:903:3201:b0:2a0:7fac:c031 with SMTP id d9443c01a7336-2ae39799b45mr8358055ad.14.1772562283873; Tue, 03 Mar 2026 10:24:43 -0800 (PST) Received: from google.com (154.52.125.34.bc.googleusercontent.com. [34.125.52.154]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ae472255ccsm88532105ad.38.2026.03.03.10.24.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Mar 2026 10:24:43 -0800 (PST) Date: Tue, 3 Mar 2026 18:24:38 +0000 From: Carlos Llamas To: HONG Yifan Cc: Josh Poimboeuf , Peter Zijlstra , kernel-team@android.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1] objtool: HAVE_XXHASH test uses HOSTCFLAGS. Message-ID: References: <20260303010340.306164-1-elsk@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260303010340.306164-1-elsk@google.com> On Tue, Mar 03, 2026 at 01:03:39AM +0000, 'HONG Yifan' via kernel-team wrote: > Previously, HAVE_XXHASH is tested by invoking HOSTCC without HOSTCFLAGS. > > Consider the following scenario: > > - The host machine has libxxhash installed > - We build the kernel with HOSTCFLAGS containing a --sysroot that does > not have xxhash.h (for hermetic builds) > > In this case, HAVE_XXHASH is set to y, but when it builds objtool with > HOSTCFLAGS, because the --sysroot does not contain xxhash.h, the > following error is raised: > > <...>/common/tools/objtool/include/objtool/checksum_types.h:12:10: fatal error: 'xxhash.h' file not found > 12 | #include > | ^~~~~~~~~~ > > To resolve the error, we test HAVE_XXHASH by invoking HOSTCC with > HOSTCFLAGS. > > Signed-off-by: HONG Yifan > --- Reviewed-by: Carlos Llamas