From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 471C9C2D0E4 for ; Fri, 18 Dec 2020 20:54:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EE62823B7A for ; Fri, 18 Dec 2020 20:54:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726066AbgLRUyh (ORCPT ); Fri, 18 Dec 2020 15:54:37 -0500 Received: from mail.kernel.org ([198.145.29.99]:50644 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725808AbgLRUyg (ORCPT ); Fri, 18 Dec 2020 15:54:36 -0500 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6260D23B6C; Fri, 18 Dec 2020 20:53:55 +0000 (UTC) Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94) (envelope-from ) id 1kqMl7-002Ncg-Bq; Fri, 18 Dec 2020 20:53:53 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Fri, 18 Dec 2020 20:53:53 +0000 From: Marc Zyngier To: Valentin Schneider Cc: linux-kernel@vger.kernel.org, Guenter Roeck , tglx@linutronix.de Subject: Re: [irqchip: irq/irqchip-next] irqchip/bcm2836: Fix IPI acknowledgement after conversion to handle_percpu_devid_irq In-Reply-To: References: <160831684292.22759.15563002516530918910.tip-bot2@tip-bot2> User-Agent: Roundcube Webmail/1.4.9 Message-ID: X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: valentin.schneider@arm.com, linux-kernel@vger.kernel.org, linux@roeck-us.net, tglx@linutronix.de X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020-12-18 20:36, Valentin Schneider wrote: > On 18/12/20 18:40, irqchip-bot for Marc Zyngier wrote: >> The following commit has been merged into the irq/irqchip-next branch >> of irqchip: >> >> Commit-ID: d7f39c40ebb6986e7371510d1c20a4efee4a7f0d >> Gitweb: >> https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms/d7f39c40ebb6986e7371510d1c20a4efee4a7f0d >> Author: Marc Zyngier >> AuthorDate: Fri, 18 Dec 2020 18:03:46 >> Committer: Marc Zyngier >> CommitterDate: Fri, 18 Dec 2020 18:34:17 >> >> irqchip/bcm2836: Fix IPI acknowledgement after conversion to >> handle_percpu_devid_irq >> >> It appears that despite its name, the bcm2836_arm_irqchip_ipi_eoi() >> callback is an acknowledgement, and not an EOI. This means that >> we lose IPIs that are made pending between the handling of the >> IPI and the write to LOCAL_MAILBOX0_CLR0. With the right timing, >> things fail nicely. >> >> This used to work with handle_percpu_devid_fasteoi_ipi(), which >> started by eoi-ing the interrupt. With the standard fasteoi flow, >> this doesn't work anymore. >> >> So let's use this callback for what it is, an ack. Your favourite >> RPi-2/3 is back up and running. >> > > Thanks for cleaning up my mess! Shared responsibilities... ;-) M. -- Jazz is not dead. It just smells funny...